Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 15705,
    "url": "http://patches.dpdk.org/api/patches/15705/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1473348597-11904-1-git-send-email-droidluo@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1473348597-11904-1-git-send-email-droidluo@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1473348597-11904-1-git-send-email-droidluo@gmail.com",
    "date": "2016-09-08T15:29:57",
    "name": "[dpdk-dev] mempool: fix corruption due to invalid handler",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "74668232e3acd1101695a2f92519a11be65b6919",
    "submitter": {
        "id": 561,
        "url": "http://patches.dpdk.org/api/people/561/?format=api",
        "name": "Weiliang Luo",
        "email": "droidluo@gmail.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1473348597-11904-1-git-send-email-droidluo@gmail.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/15705/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/15705/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BE97D5398;\n\tThu,  8 Sep 2016 17:31:01 +0200 (CEST)",
            "from mail-pa0-f66.google.com (mail-pa0-f66.google.com\n\t[209.85.220.66]) by dpdk.org (Postfix) with ESMTP id 221A09E7\n\tfor <dev@dpdk.org>; Thu,  8 Sep 2016 17:31:00 +0200 (CEST)",
            "by mail-pa0-f66.google.com with SMTP id ez1so2535884pab.3\n\tfor <dev@dpdk.org>; Thu, 08 Sep 2016 08:31:00 -0700 (PDT)",
            "from localhost.localdomain (rrcs-97-105-183-34.sw.biz.rr.com.\n\t[97.105.183.34]) by smtp.gmail.com with ESMTPSA id\n\tm82sm34199130pfk.64.2016.09.08.08.30.12\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tThu, 08 Sep 2016 08:30:18 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=5opUi2qW3pvno8XYNzNlm7YahL2DqdRaDQOozP7RuzU=;\n\tb=PCumJZMyThwXezBnzPyDIF8Sa6cu/98LQtqz4EG3UG8TwwswVtN9mlg8EtcGfn0EON\n\td+PVHlqggMjQkOGRj2ZLcoG+oGbtC40QPG4moA8XJh+riSV8DdN4HsVJNe0IiVc3364s\n\tHAhnHeV+P3wkpDWFz7XJuU5MOCoq0IWfjX42+R/ogRDQnJWBJcMDYaA6kjBGB5/W5Gk7\n\tibWJsbSARYtVtce1FfXdXuT62Y8DvPm7qXsPKFr6zAR2TXNRDNHtLW0aLG2DVuiGXKY1\n\ts1n60F5dtNHMAlLG1P6iWA7zZZVLXsKp79Eb/24Lpi6jy5WpQu2hzXJZ1tl52KQHf1FE\n\t4+lw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=5opUi2qW3pvno8XYNzNlm7YahL2DqdRaDQOozP7RuzU=;\n\tb=ddXFk7gjuWTn3NVXfbVbYFTyrXfEBx6eoCHnGi7mz5oluOXwAp42oVYjVyIRlBdScN\n\tlrVULpvjVVJW5rVzsyyMiwljWJz1y97syzcfCaYdK4V0lRbIifiZIuh8YaDseENKnwie\n\tupgzhCRVSw/ACURUAEew5Bms3TVa+1NzhK6JBIf/K9lHSvtD/UKu34uMRtGH8DTKbwOY\n\t/1bTy+/2z9FSZrbxQuKrXn7eyhuS/mrXu04m9tg/ws2F+Y74YH3mRV0pdY0L6Df+HIgs\n\tbK+lfEyAL0aI4g+4nbGBvkFgMpNmNcjjmKuBblntGbEwmYldSCmkx49EV3Tgxdu2lymk\n\trdfw==",
        "X-Gm-Message-State": "AE9vXwMDMti9WslytFzXBUH+hsgqPJ+UCD/YlB4l9S5koZNLKocMkIiPGzpO0w6rT8xuiQ==",
        "X-Received": "by 10.66.47.67 with SMTP id b3mr374055pan.43.1473348659444;\n\tThu, 08 Sep 2016 08:30:59 -0700 (PDT)",
        "From": "Weiliang Luo <droidluo@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "Weiliang Luo <droidluo@gmail.com>",
        "Date": "Thu,  8 Sep 2016 10:29:57 -0500",
        "Message-Id": "<1473348597-11904-1-git-send-email-droidluo@gmail.com>",
        "X-Mailer": "git-send-email 2.7.4 (Apple Git-66)",
        "Subject": "[dpdk-dev] [PATCH] mempool: fix corruption due to invalid handler",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When using rte_mempool_create(), the mempool handler is selected\ndepending on the flags given by the user:\n  - multi-consumer / multi-producer\n  - multi-consumer / single-producer\n  - single-consumer / multi-producer\n  - single-consumer / single-producer\n\nThe flags were not properly tested, resulting in the selection of sc/sp\nhandler if sc/mp or mc/sp was asked. This can lead to corruption or\ncrashes because the get/put operations are not atomic.\n\nFixes: 449c49b93a6b (\"mempool: support handler operations\")\n\nSigned-off-by: Weiliang Luo <droidluo@gmail.com>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_mempool/rte_mempool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 2e28e2e..350d77a 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -879,7 +879,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,\n \t * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to\n \t * set the correct index into the table of ops structs.\n \t */\n-\tif (flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET))\n+\tif ((flags & MEMPOOL_F_SP_PUT) && (flags & MEMPOOL_F_SC_GET))\n \t\trte_mempool_set_ops_byname(mp, \"ring_sp_sc\", NULL);\n \telse if (flags & MEMPOOL_F_SP_PUT)\n \t\trte_mempool_set_ops_byname(mp, \"ring_sp_mc\", NULL);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}