Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 15597,
    "url": "http://patches.dpdk.org/api/patches/15597/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20160902150521.680-1-matthias.gatto@outscale.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20160902150521.680-1-matthias.gatto@outscale.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20160902150521.680-1-matthias.gatto@outscale.com",
    "date": "2016-09-02T15:05:21",
    "name": "[dpdk-dev] virtio: remove obsolete comment",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b39f7334a4ee3d5d72612ca86ba7af12da23a47f",
    "submitter": {
        "id": 555,
        "url": "http://patches.dpdk.org/api/people/555/?format=api",
        "name": "Matthias Gatto",
        "email": "matthias.gatto@outscale.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20160902150521.680-1-matthias.gatto@outscale.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/15597/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/15597/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E9916532C;\n\tFri,  2 Sep 2016 17:05:31 +0200 (CEST)",
            "from dv-adm01.admin\n\t(ows-185-21-195-233.eu-west-1.compute.outscale.com [185.21.195.233])\n\tby dpdk.org (Postfix) with ESMTP id D6D6B4CE7\n\tfor <dev@dpdk.org>; Fri,  2 Sep 2016 17:05:30 +0200 (CEST)",
            "from localhost.localdomain (unknown [172.19.166.138])\n\tby dv-adm01.admin (Postfix) with ESMTP id 6B94140319;\n\tFri,  2 Sep 2016 15:05:27 +0000 (UTC)"
        ],
        "From": "Matthias Gatto <matthias.gatto@outscale.com>",
        "To": "dev@dpdk.org",
        "Cc": "Matthias Gatto <matthias.gatto@outscale.com>, huawei.xie@intel.com,\n\tyuanhan.liu@linux.intel.com",
        "Date": "Fri,  2 Sep 2016 17:05:21 +0200",
        "Message-Id": "<20160902150521.680-1-matthias.gatto@outscale.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "Subject": "[dpdk-dev] [PATCH] virtio: remove obsolete comment",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As new_device and destroy_device use an int instead of a \"struct virtio_net *\",\nThe comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus\nIf I've correctly understand the code, the drivers take care of\nsetting the flag before calling the callbacks, so I guess that this comment\nis obsolet and I've remove it.\n\nSigned-off-by: Matthias Gatto <matthias.gatto@outscale.com>\n---\n lib/librte_vhost/rte_virtio_net.h | 4 ----\n 1 file changed, 4 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h\nindex 9caa622..a88aecd 100644\n--- a/lib/librte_vhost/rte_virtio_net.h\n+++ b/lib/librte_vhost/rte_virtio_net.h\n@@ -59,10 +59,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};\n \n /**\n  * Device and vring operations.\n- *\n- * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and\n- * remove it in destroy_device.\n- *\n  */\n struct virtio_net_device_ops {\n \tint (*new_device)(int vid);\t\t/**< Add device. */\n",
    "prefixes": [
        "dpdk-dev"
    ]
}