Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 15257,
    "url": "http://patches.dpdk.org/api/patches/15257/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1471938058-12385-1-git-send-email-yuanhan.liu@linux.intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1471938058-12385-1-git-send-email-yuanhan.liu@linux.intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1471938058-12385-1-git-send-email-yuanhan.liu@linux.intel.com",
    "date": "2016-08-23T07:40:58",
    "name": "[dpdk-dev] net/virtio: fix build error with clang",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d72908516cc51ade5527202851005f77b49577fa",
    "submitter": {
        "id": 307,
        "url": "http://patches.dpdk.org/api/people/307/?format=api",
        "name": "Yuanhan Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1471938058-12385-1-git-send-email-yuanhan.liu@linux.intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/15257/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/15257/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3436B37B3;\n\tTue, 23 Aug 2016 09:31:18 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 36EBF2956\n\tfor <dev@dpdk.org>; Tue, 23 Aug 2016 09:31:16 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga101.jf.intel.com with ESMTP; 23 Aug 2016 00:31:15 -0700",
            "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga005.fm.intel.com with ESMTP; 23 Aug 2016 00:31:13 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.28,564,1464678000\"; d=\"scan'208\";a=\"785344\"",
        "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Yuanhan Liu <yuanhan.liu@linux.intel.com>,\n\tJerin Jacob <jerin.jacob@caviumnetworks.com>",
        "Date": "Tue, 23 Aug 2016 15:40:58 +0800",
        "Message-Id": "<1471938058-12385-1-git-send-email-yuanhan.liu@linux.intel.com>",
        "X-Mailer": "git-send-email 1.9.0",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: fix build error with clang",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Interestingly, clang and gcc has different prototype for _mm_prefetch().\nFor gcc, we have\n\n   _mm_prefetch (const void *__P, enum _mm_hint __I)\n\nWhile for clang, it's\n\n   #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel)))\n\nThat how the following error comes with clang:\n\n   error: cast from 'const void *' to 'void *' drops const qualifier\n   [-Werror,-Wcast-qual]\n           _mm_prefetch((const void *)rused, _MM_HINT_T0);\n   /usr/lib/llvm-3.8/bin/../lib/clang/3.8.0/include/xmmintrin.h:684:58:\n   note: expanded from macro '_mm_prefetch'\n            #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a),\n                                          0, (sel)))\n\nWhat's weird is that the build was actaully Okay before. I met it while\napply Jerin's vector support for ARM patch set: he just move this peiece\nof code to another file, nothing else changed.\n\nThis patch fix the issue when Jerin's patchset is applied. Thus, I think\nit's still needed.\n\nFixes: fc3d66212fed (\"virtio: add vector Rx\")\n\nCc: Jerin Jacob <jerin.jacob@caviumnetworks.com>\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n drivers/net/virtio/virtio_rxtx_simple.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx_simple.c b/drivers/net/virtio/virtio_rxtx_simple.c\nindex 6517aa8..56195e5 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple.c\n@@ -200,7 +200,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tsw_ring  = &vq->sw_ring[desc_idx];\n \tsw_ring_end = &vq->sw_ring[vq->vq_nentries];\n \n-\t_mm_prefetch((const void *)rused, _MM_HINT_T0);\n+\t_mm_prefetch(rused, _MM_HINT_T0);\n \n \tif (vq->vq_free_cnt >= RTE_VIRTIO_VPMD_RX_REARM_THRESH) {\n \t\tvirtio_rxq_rearm_vec(rxvq);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}