Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15016/?format=api
{ "id": 15016, "url": "http://patches.dpdk.org/api/patches/15016/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1469476476-2148-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1469476476-2148-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1469476476-2148-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-07-25T19:54:36", "name": "[dpdk-dev,v2] mempool: fix unsafe removal from list by callback", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1cd20254515e301769f3740ebb05aeef4ef4d385", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1469476476-2148-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/15016/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/15016/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id ED3293777;\n\tMon, 25 Jul 2016 21:54:47 +0200 (CEST)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 3AA7E3772\n\tfor <dev@dpdk.org>; Mon, 25 Jul 2016 21:54:47 +0200 (CEST)", "by mail-wm0-f52.google.com with SMTP id f65so148281348wmi.0\n\tfor <dev@dpdk.org>; Mon, 25 Jul 2016 12:54:47 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tv189sm28925247wmv.12.2016.07.25.12.54.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 25 Jul 2016 12:54:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Vyep2dnlDzaNX8l8vrUF7fyI7985eDLXCD7aka1BU98=;\n\tb=0RurQD1QdLDupUg0EUK7mVzGmRkeTxLCSYmk7DWfrprqppNQDTHAgd2ZBzlOStkO1X\n\tKjUTDz2uB3Syp0XEjvTmBqbcMIrLWZT5Af58/GIdMjGAj8nGaS7IFFpAvuWG5T1lUV6F\n\tw5WSXP2h1E48xcHbxUoI5pH6zJpSCY4ymN4fnMsWjus21TJq4na0P1HYrbq72Op3SrkO\n\tH/CrHTIwp3P4ThRbi0436JQ/T5loxe/zgd8lhE1wElWfgTRSgk3p+uDMPjb/bkLSm20l\n\tkOrnVrlLGHkOsL1pIvwYOVVu0zC8wZzStzacjVvD3rLNWvHV0uc2r7MBp/k2zGN+Qoz4\n\t1jwQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Vyep2dnlDzaNX8l8vrUF7fyI7985eDLXCD7aka1BU98=;\n\tb=gnVCS/bZ9euqpSxkqyIMSIoqeWKGa0gJ32Ud8O/IACjc8qWT/6z78IDPDpCk//lEzz\n\tJWXn8IexvP/lGxWHMvoHURIfDeS3WvtkqvR6hh5pde7ZyokO77bCfdyTFDYRC8tm1+3d\n\ttKXQfFxH4s4X/wqnW4k3YXI4+VgJu5FirNzKaTjMHCVWkLV/U1DuFZyL8ej3iXikskcz\n\tTcFF8oW2fmIB13gqiIW9+Dnga2ktRuCJwbLBWeh+Hs2WD1xsyi4RT0e55lTuvNcMJe9p\n\tg3Nswai/iQs8pbuV8fip55iqPRmwCMuQiTq468h2PpM8hU6d9weQzfBEmkZXCfYY108F\n\t/JdA==", "X-Gm-Message-State": "ALyK8tKc1cqPH4AYHDLKjzQDtdTuat9LfeZ8+V+/qcrYOtRGn3daZp3OTBqeVMT9e8I+oJ6/", "X-Received": "by 10.28.22.70 with SMTP id 67mr44162059wmw.52.1469476485938;\n\tMon, 25 Jul 2016 12:54:45 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "olivier.matz@dpdk.org", "Cc": "dev@dpdk.org", "Date": "Mon, 25 Jul 2016 21:54:36 +0200", "Message-Id": "<1469476476-2148-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<b7fe1c73-aba2-f6e8-0526-fcfd8824905a@6wind.com>", "References": "<b7fe1c73-aba2-f6e8-0526-fcfd8824905a@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2] mempool: fix unsafe removal from list by\n\tcallback", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a mempool is removed from the list by a callback function\nduring rte_mempool_walk(), the TAILQ_FOREACH loop will fail unexpectedly.\nIt is fixed by using the safe version of the loop macro.\n\nReported-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n lib/librte_mempool/rte_mempool.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 8806633..2e28e2e 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -1283,12 +1283,13 @@ void rte_mempool_walk(void (*func)(struct rte_mempool *, void *),\n {\n \tstruct rte_tailq_entry *te = NULL;\n \tstruct rte_mempool_list *mempool_list;\n+\tvoid *tmp_te;\n \n \tmempool_list = RTE_TAILQ_CAST(rte_mempool_tailq.head, rte_mempool_list);\n \n \trte_rwlock_read_lock(RTE_EAL_MEMPOOL_RWLOCK);\n \n-\tTAILQ_FOREACH(te, mempool_list, next) {\n+\tTAILQ_FOREACH_SAFE(te, mempool_list, next, tmp_te) {\n \t\t(*func)((struct rte_mempool *) te->data, arg);\n \t}\n \n", "prefixes": [ "dpdk-dev", "v2" ] }