Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14950,
    "url": "http://patches.dpdk.org/api/patches/14950/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1469089470-5764-1-git-send-email-xiao.w.wang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1469089470-5764-1-git-send-email-xiao.w.wang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1469089470-5764-1-git-send-email-xiao.w.wang@intel.com",
    "date": "2016-07-21T08:24:30",
    "name": "[dpdk-dev] net/fm10k: fix RSS hash config",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9b233b05bb80ee117c2e6e007ef2f3652e1af625",
    "submitter": {
        "id": 281,
        "url": "http://patches.dpdk.org/api/people/281/?format=api",
        "name": "Xiao Wang",
        "email": "xiao.w.wang@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1469089470-5764-1-git-send-email-xiao.w.wang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/14950/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/14950/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 12F533989;\n\tThu, 21 Jul 2016 10:24:42 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id CEDB23979\n\tfor <dev@dpdk.org>; Thu, 21 Jul 2016 10:24:39 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 21 Jul 2016 01:24:39 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 21 Jul 2016 01:24:36 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u6L8OYrX024085;\n\tThu, 21 Jul 2016 16:24:34 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u6L8OV5v005799; Thu, 21 Jul 2016 16:24:33 +0800",
            "(from xiaowan1@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u6L8OVEc005795; \n\tThu, 21 Jul 2016 16:24:31 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.28,398,1464678000\"; d=\"scan'208\";\n\ta=\"1011100776\"",
        "From": "Xiao Wang <xiao.w.wang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jing.d.chen@intel.com, xueqin.lin@intel.com,\n\tXiao Wang <xiao.w.wang@intel.com>",
        "Date": "Thu, 21 Jul 2016 16:24:30 +0800",
        "Message-Id": "<1469089470-5764-1-git-send-email-xiao.w.wang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Sometimes app just wants to update the RSS hash function and no RSS key\nupdate is needed, but fm10k pmd will return EINVAL for this case.\n\nIf the rss_key is NULL, we don't need to check the rss_key_len.\n\nFixes: 57033cdf8fdc (\"fm10k: add PF RSS\")\n\nReported-by: Xueqin Lin <xueqin.lin@intel.com>\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 144b2de..01f4a72 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tif (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *\n-\t\tFM10K_RSSRK_ENTRIES_PER_REG)\n+\tif (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *\n+\t\t\t\tFM10K_RSSRK_ENTRIES_PER_REG))\n \t\treturn -EINVAL;\n \n \tif (hf == 0)\n@@ -2202,8 +2202,8 @@ fm10k_rss_hash_conf_get(struct rte_eth_dev *dev,\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tif (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *\n-\t\t\t\tFM10K_RSSRK_ENTRIES_PER_REG)\n+\tif (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *\n+\t\t\t\tFM10K_RSSRK_ENTRIES_PER_REG))\n \t\treturn -EINVAL;\n \n \tif (key != NULL)\n",
    "prefixes": [
        "dpdk-dev"
    ]
}