Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14780/?format=api
{ "id": 14780, "url": "http://patches.dpdk.org/api/patches/14780/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com", "date": "2016-07-12T09:30:25", "name": "[dpdk-dev] net/virtio-user: Fix missing brackets in if condition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "788a2b1353ac7dc2173120035fc9f3c7ae571dd1", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14780/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 760C4F94;\n\tTue, 12 Jul 2016 11:30:43 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 6A71CF94\n\tfor <dev@dpdk.org>; Tue, 12 Jul 2016 11:30:42 +0200 (CEST)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BC63D80E47;\n\tTue, 12 Jul 2016 09:30:41 +0000 (UTC)", "from max-t460s.redhat.com (vpn-202-34.tlv.redhat.com\n\t[10.35.202.34])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u6C9UcPY014292; Tue, 12 Jul 2016 05:30:39 -0400" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "huawei.xie@intel.com, yuanhan.liu@linux.intel.com", "Cc": "dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tJianfeng Tan <jianfeng.tan@intel.com>", "Date": "Tue, 12 Jul 2016 11:30:25 +0200", "Message-Id": "<1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]); Tue, 12 Jul 2016 09:30:41 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH] net/virtio-user: Fix missing brackets in if\n\tcondition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The error is reported using test build script:\n\n$ scripts/test-build.sh x86_64-native-linuxapp-gcc\n...\ndrivers/net/virtio/virtio_user_ethdev.c: In function ‘virtio_user_pmd_devinit’:\ndrivers/net/virtio/virtio_user_ethdev.c:345:2: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]\n if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)\n ^~\n\nFixes: 404bd6bfe360 (\"net/virtio-user: fix return value not checked\")\n\nCc: Jianfeng Tan <jianfeng.tan@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 782d7d3..6b4f66e 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -342,7 +342,7 @@ virtio_user_pmd_devinit(const char *name, const char *params)\n \t\tgoto end;\n \t}\n \n-\tif (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)\n+\tif (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1) {\n \t\tret = rte_kvargs_process(kvlist, VIRTIO_USER_ARG_PATH,\n \t\t\t\t\t &get_string_arg, &path);\n \t\tif (ret < 0) {\n@@ -350,7 +350,7 @@ virtio_user_pmd_devinit(const char *name, const char *params)\n \t\t\t\t VIRTIO_USER_ARG_PATH);\n \t\t\tgoto end;\n \t\t}\n-\telse {\n+\t} else {\n \t\tPMD_INIT_LOG(ERR, \"arg %s is mandatory for virtio-user\\n\",\n \t\t\t VIRTIO_USER_ARG_QUEUE_SIZE);\n \t\tgoto end;\n", "prefixes": [ "dpdk-dev" ] }