Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1478/?format=api
{ "id": 1478, "url": "http://patches.dpdk.org/api/patches/1478/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1416792142-23132-15-git-send-email-chaozhu@linux.vnet.ibm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416792142-23132-15-git-send-email-chaozhu@linux.vnet.ibm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416792142-23132-15-git-send-email-chaozhu@linux.vnet.ibm.com", "date": "2014-11-24T01:22:22", "name": "[dpdk-dev,v3,14/14] Fix the compiling of test-pmd on IBM Power Architecture", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "83bafd5f90d6077413b644d9baa9fb5a7c7d5750", "submitter": { "id": 114, "url": "http://patches.dpdk.org/api/people/114/?format=api", "name": "Chao Zhu", "email": "chaozhu@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1416792142-23132-15-git-send-email-chaozhu@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/1478/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/1478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id ABE7C8052;\n\tSun, 23 Nov 2014 14:11:50 +0100 (CET)", "from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141])\n\tby dpdk.org (Postfix) with ESMTP id 78E6B7FCB\n\tfor <dev@dpdk.org>; Sun, 23 Nov 2014 14:11:40 +0100 (CET)", "from /spool/local\n\tby e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <dev@dpdk.org> from <chaozhu@linux.vnet.ibm.com>;\n\tSun, 23 Nov 2014 23:22:22 +1000", "from d23dlp01.au.ibm.com (202.81.31.203)\n\tby e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSun, 23 Nov 2014 23:22:20 +1000", "from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33])\n\tby d23dlp01.au.ibm.com (Postfix) with ESMTP id 848602CE8052\n\tfor <dev@dpdk.org>; Mon, 24 Nov 2014 00:22:20 +1100 (EST)", "from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tsANDMCan41681020 for <dev@dpdk.org>; Mon, 24 Nov 2014 00:22:20 +1100", "from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tsANDLmRs017525 for <dev@dpdk.org>; Mon, 24 Nov 2014 00:21:48 +1100", "from os_controller.crl.ibm.com ([9.186.57.97])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tsANDLYg5017172 for <dev@dpdk.org>; Mon, 24 Nov 2014 00:21:47 +1100" ], "From": "Chao Zhu <chaozhu@linux.vnet.ibm.com>", "To": "dev@dpdk.org", "Date": "Sun, 23 Nov 2014 20:22:22 -0500", "Message-Id": "<1416792142-23132-15-git-send-email-chaozhu@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<1416792142-23132-1-git-send-email-chaozhu@linux.vnet.ibm.com>", "References": "<1416792142-23132-1-git-send-email-chaozhu@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "14112313-0029-0000-0000-000000A742B6", "Subject": "[dpdk-dev] [PATCH v3 14/14] Fix the compiling of test-pmd on IBM\n\tPower Architecture", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes compiling problems on IBM Power architecture and turn\non the test-pmd compiling option in configuration file. Actually, this\nis an big endian compiling fix.\n\nSigned-off-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>\n---\n app/test-pmd/config.c | 33 +++++++++++++++++++--------------\n config/common_linuxapp_powerpc | 6 +++---\n 2 files changed, 22 insertions(+), 17 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 9bc08f4..ba26da1 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -612,8 +612,13 @@ ring_dma_zone_lookup(const char *ring_name, uint8_t port_id, uint16_t q_id)\n union igb_ring_dword {\n \tuint64_t dword;\n \tstruct {\n+#ifdef RTE_ARCH_BIG_ENDIAN\n+\t\tuint32_t lo;\n+\t\tuint32_t hi;\n+#else\n \t\tuint32_t hi;\n \t\tuint32_t lo;\n+#endif\n \t} words;\n };\n \n@@ -656,23 +661,23 @@ ring_rx_descriptor_display(const struct rte_memzone *ring_mz,\n \t\t/* 32 bytes RX descriptor, i40e only */\n \t\tstruct igb_ring_desc_32_bytes *ring =\n \t\t\t(struct igb_ring_desc_32_bytes *)ring_mz->addr;\n+ ring[desc_id].lo_dword.dword = rte_le_to_cpu_64(ring[desc_id].lo_dword.dword);\n+\t\tring_rxd_display_dword(ring[desc_id].lo_dword);\n+\t\tring[desc_id].hi_dword.dword = rte_le_to_cpu_64(ring[desc_id].hi_dword.dword);\n+\t\tring_rxd_display_dword(ring[desc_id].hi_dword);\n+ ring[desc_id].resv1.dword = rte_le_to_cpu_64(ring[desc_id].resv1.dword);\n+\t\tring_rxd_display_dword(ring[desc_id].resv1);\n+\t\tring[desc_id].resv2.dword = rte_le_to_cpu_64(ring[desc_id].resv2.dword);\n+\t\tring_rxd_display_dword(ring[desc_id].resv2);\t\t\n \n-\t\tring_rxd_display_dword(rte_le_to_cpu_64(\n-\t\t\t\tring[desc_id].lo_dword));\n-\t\tring_rxd_display_dword(rte_le_to_cpu_64(\n-\t\t\t\tring[desc_id].hi_dword));\n-\t\tring_rxd_display_dword(rte_le_to_cpu_64(\n-\t\t\t\tring[desc_id].resv1));\n-\t\tring_rxd_display_dword(rte_le_to_cpu_64(\n-\t\t\t\tring[desc_id].resv2));\n \t\treturn;\n \t}\n #endif\n \t/* 16 bytes RX descriptor */\n-\tring_rxd_display_dword(rte_le_to_cpu_64(\n-\t\t\tring[desc_id].lo_dword));\n-\tring_rxd_display_dword(rte_le_to_cpu_64(\n-\t\t\tring[desc_id].hi_dword));\n+ ring[desc_id].lo_dword.dword = rte_le_to_cpu_64(ring[desc_id].lo_dword.dword);\n+\tring_rxd_display_dword(ring[desc_id].lo_dword);\n+\tring[desc_id].hi_dword.dword = rte_le_to_cpu_64(ring[desc_id].hi_dword.dword);\n+\tring_rxd_display_dword(ring[desc_id].hi_dword);\t\n }\n \n static void\n@@ -682,8 +687,8 @@ ring_tx_descriptor_display(const struct rte_memzone *ring_mz, uint16_t desc_id)\n \tstruct igb_ring_desc_16_bytes txd;\n \n \tring = (struct igb_ring_desc_16_bytes *)ring_mz->addr;\n-\ttxd.lo_dword = rte_le_to_cpu_64(ring[desc_id].lo_dword);\n-\ttxd.hi_dword = rte_le_to_cpu_64(ring[desc_id].hi_dword);\n+\ttxd.lo_dword.dword = rte_le_to_cpu_64(ring[desc_id].lo_dword.dword);\n+\ttxd.hi_dword.dword = rte_le_to_cpu_64(ring[desc_id].hi_dword.dword);\n \tprintf(\" 0x%08X - 0x%08X / 0x%08X - 0x%08X\\n\",\n \t\t\t(unsigned)txd.lo_dword.words.lo,\n \t\t\t(unsigned)txd.lo_dword.words.hi,\ndiff --git a/config/common_linuxapp_powerpc b/config/common_linuxapp_powerpc\nindex d230a0b..68f1b6b 100644\n--- a/config/common_linuxapp_powerpc\n+++ b/config/common_linuxapp_powerpc\n@@ -146,8 +146,8 @@ CONFIG_RTE_NIC_BYPASS=n\n #\n # Compile burst-oriented IGB & EM PMD drivers\n #\n-CONFIG_RTE_LIBRTE_EM_PMD=n\n-CONFIG_RTE_LIBRTE_IGB_PMD=n\n+CONFIG_RTE_LIBRTE_EM_PMD=y\n+CONFIG_RTE_LIBRTE_IGB_PMD=y\n CONFIG_RTE_LIBRTE_E1000_DEBUG_INIT=n\n CONFIG_RTE_LIBRTE_E1000_DEBUG_RX=n\n CONFIG_RTE_LIBRTE_E1000_DEBUG_TX=n\n@@ -389,6 +389,6 @@ CONFIG_RTE_APP_TEST=y\n #\n # Compile the PMD test application\n #\n-CONFIG_RTE_TEST_PMD=n\n+CONFIG_RTE_TEST_PMD=y\n CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES=n\n CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS=n\n", "prefixes": [ "dpdk-dev", "v3", "14/14" ] }