Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14743/?format=api
{ "id": 14743, "url": "http://patches.dpdk.org/api/patches/14743/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1468248045-3495-9-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1468248045-3495-9-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1468248045-3495-9-git-send-email-david.marchand@6wind.com", "date": "2016-07-11T14:40:43", "name": "[dpdk-dev,v4,08/10] net/bnx2x: move PCI device ids to the driver", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a3a8ba24e77d37b75899726411b7e641103780d9", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1468248045-3495-9-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14743/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AF1F8532E;\n\tMon, 11 Jul 2016 16:41:15 +0200 (CEST)", "from mail-wm0-f53.google.com (mail-wm0-f53.google.com\n\t[74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 9356047D2\n\tfor <dev@dpdk.org>; Mon, 11 Jul 2016 16:41:13 +0200 (CEST)", "by mail-wm0-f53.google.com with SMTP id i5so20272068wmg.0\n\tfor <dev@dpdk.org>; Mon, 11 Jul 2016 07:41:13 -0700 (PDT)", "from gloops.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\th7sm158371wji.47.2016.07.11.07.41.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 11 Jul 2016 07:41:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=JzT0cZTeqvN2Rf/R8F5hiMzpo1Dhcc7A3GLy3AQUydw=;\n\tb=P2IKhhzuEdC22bpDi5YATm+oZVkdIkoRYq/Tz9oK4CrbNoRaT7C8uZ3UuyieLWY/tz\n\tDB4+uTWQhJOELo3O3suyQ1UYkJ9Ub45w7xGXc85WiC8Qt3YWcZwLSy4RkzWUhDoGZJHK\n\t0orgcw60P7c13r1W+K2bA/cFerAkp2qoCvacB5cuN70UvDAm0phLFGouHkxCkjEOJio+\n\tcrVYu/n52N12sIEeKSG+IZJ9HLj8na4WJHvLLN5KQXyEvMQ5b/9JqsJz1lSG7iYsM5In\n\tkmG/Vxzz8psUNiVJ0/AO7bOTB/SS2/TyqdiDWe2MHfCvaLv/KXh2Nh0OzL+pRMUbQjSI\n\tJtWg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=JzT0cZTeqvN2Rf/R8F5hiMzpo1Dhcc7A3GLy3AQUydw=;\n\tb=Y3S3CirDZFNkN0VgunO5pVouE/VyqDyTg3amEsKjyBeW92tRvcSpuvTT/1hYCtcgE3\n\t4hwx7pUAw1hASW/HlxD8/ThjJoJNCwjJR+2GZwq2hABMhm1vzgDRWYtEKf0Ri56Ezuh+\n\t1JHw2G/G4NmmLX4eQ53b82mFbCLC46KMzE7oPxpflfvhxh5iA4gXhrGxEEEnKK/IQvCB\n\tXi0Zd87FzRZBztw00nVMdvFySq/VFq0dXKVyqxFDvAj41Z6xfbs5UasiWyqGnlPvdo/x\n\tFRibH/1Jws1V3ueCG/aSqjLa+ZsA1B/S7CgKV8USpOKY+2QelKp82ZU3QWoFbtHOn9y0\n\tWn9w==", "X-Gm-Message-State": "ALyK8tIp8v47Z9PWyT6LiPsU2g+ZaRfanGY9TumL1VPnMN1p0OPcUwPjn7OgfYTAA9OdbkbJ", "X-Received": "by 10.28.10.196 with SMTP id 187mr20972881wmk.48.1468248072602; \n\tMon, 11 Jul 2016 07:41:12 -0700 (PDT)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, thomas.monjalon@6wind.com,\n\tnhorman@tuxdriver.com, pmatilai@redhat.com,\n\tchristian.ehrhardt@canonical.com, stephen@networkplumber.com,\n\tSony Chacko <sony.chacko@qlogic.com>,\n\tHarish Patil <harish.patil@qlogic.com>,\n\tRasesh Mody <rasesh.mody@qlogic.com>", "Date": "Mon, 11 Jul 2016 16:40:43 +0200", "Message-Id": "<1468248045-3495-9-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1468248045-3495-1-git-send-email-david.marchand@6wind.com>", "References": "<1461156236-25349-1-git-send-email-david.marchand@6wind.com>\n\t<1468248045-3495-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH v4 08/10] net/bnx2x: move PCI device ids to the\n\tdriver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reused defines from the driver and moved broadcom vendor id macro.\nUsed RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n drivers/net/bnx2x/bnx2x.c | 3 +-\n drivers/net/bnx2x/bnx2x_ethdev.c | 21 ++++++++--\n lib/librte_eal/common/include/rte_pci_dev_ids.h | 55 -------------------------\n 3 files changed, 18 insertions(+), 61 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 10859c1..95fbad8 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -22,7 +22,6 @@\n #include \"ecore_init_ops.h\"\n \n #include \"rte_version.h\"\n-#include \"rte_pci_dev_ids.h\"\n \n #include <sys/types.h>\n #include <sys/stat.h>\n@@ -9572,7 +9571,7 @@ void bnx2x_load_firmware(struct bnx2x_softc *sc)\n \tint f;\n \tstruct stat st;\n \n-\tfwname = sc->devinfo.device_id == BNX2X_DEV_ID_57711\n+\tfwname = sc->devinfo.device_id == CHIP_NUM_57711\n \t\t? FW_NAME_57711 : FW_NAME_57810;\n \tf = open(fwname, O_RDONLY);\n \tif (f < 0) {\ndiff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex 84c9662..c8d2bf2 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -16,15 +16,28 @@\n /*\n * The set of PCI devices this driver supports\n */\n+#define BROADCOM_PCI_VENDOR_ID 0x14E4\n static struct rte_pci_id pci_id_bnx2x_map[] = {\n-#define RTE_PCI_DEV_ID_DECL_BNX2X(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n-#include \"rte_pci_dev_ids.h\"\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) },\n+#ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) },\n+#endif\n \t{ .vendor_id = 0, }\n };\n \n static struct rte_pci_id pci_id_bnx2xvf_map[] = {\n-#define RTE_PCI_DEV_ID_DECL_BNX2XVF(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n-#include \"rte_pci_dev_ids.h\"\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800_VF) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) },\n+\t{ RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) },\n \t{ .vendor_id = 0, }\n };\n \ndiff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h\nindex ef85d08..fd2eb5d 100644\n--- a/lib/librte_eal/common/include/rte_pci_dev_ids.h\n+++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h\n@@ -73,14 +73,6 @@\n #define RTE_PCI_DEV_ID_DECL_IXGBEVF(vend, dev)\n #endif\n \n-#ifndef RTE_PCI_DEV_ID_DECL_BNX2X\n-#define RTE_PCI_DEV_ID_DECL_BNX2X(vend, dev)\n-#endif\n-\n-#ifndef RTE_PCI_DEV_ID_DECL_BNX2XVF\n-#define RTE_PCI_DEV_ID_DECL_BNX2XVF(vend, dev)\n-#endif\n-\n #ifndef RTE_PCI_DEV_ID_DECL_BNXT\n #define RTE_PCI_DEV_ID_DECL_BNXT(vend, dev)\n #endif\n@@ -334,51 +326,6 @@ RTE_PCI_DEV_ID_DECL_IXGBEVF(PCI_VENDOR_ID_INTEL, IXGBE_DEV_ID_X550EM_A_VF_HV)\n RTE_PCI_DEV_ID_DECL_IXGBEVF(PCI_VENDOR_ID_INTEL, IXGBE_DEV_ID_X550EM_X_VF)\n RTE_PCI_DEV_ID_DECL_IXGBEVF(PCI_VENDOR_ID_INTEL, IXGBE_DEV_ID_X550EM_X_VF_HV)\n \n-/****************** QLogic devices ******************/\n-\n-/* Broadcom/QLogic BNX2X */\n-#define BNX2X_DEV_ID_57710\t0x164e\n-#define BNX2X_DEV_ID_57711\t0x164f\n-#define BNX2X_DEV_ID_57711E\t0x1650\n-#define BNX2X_DEV_ID_57712\t0x1662\n-#define BNX2X_DEV_ID_57712_MF\t0x1663\n-#define BNX2X_DEV_ID_57712_VF\t0x166f\n-#define BNX2X_DEV_ID_57713\t0x1651\n-#define BNX2X_DEV_ID_57713E\t0x1652\n-#define BNX2X_DEV_ID_57800\t0x168a\n-#define BNX2X_DEV_ID_57800_MF\t0x16a5\n-#define BNX2X_DEV_ID_57800_VF\t0x16a9\n-#define BNX2X_DEV_ID_57810\t0x168e\n-#define BNX2X_DEV_ID_57810_MF\t0x16ae\n-#define BNX2X_DEV_ID_57810_VF\t0x16af\n-#define BNX2X_DEV_ID_57811\t0x163d\n-#define BNX2X_DEV_ID_57811_MF\t0x163e\n-#define BNX2X_DEV_ID_57811_VF\t0x163f\n-\n-#define BNX2X_DEV_ID_57840_OBS\t\t0x168d\n-#define BNX2X_DEV_ID_57840_OBS_MF\t0x16ab\n-#define BNX2X_DEV_ID_57840_4_10\t\t0x16a1\n-#define BNX2X_DEV_ID_57840_2_20\t\t0x16a2\n-#define BNX2X_DEV_ID_57840_MF\t\t0x16a4\n-#define BNX2X_DEV_ID_57840_VF\t\t0x16ad\n-\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57800)\n-RTE_PCI_DEV_ID_DECL_BNX2XVF(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57800_VF)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57711)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57810)\n-RTE_PCI_DEV_ID_DECL_BNX2XVF(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57810_VF)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57811)\n-RTE_PCI_DEV_ID_DECL_BNX2XVF(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57811_VF)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57840_OBS)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57840_4_10)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57840_2_20)\n-RTE_PCI_DEV_ID_DECL_BNX2XVF(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57840_VF)\n-#ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57810_MF)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57811_MF)\n-RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57840_MF)\n-#endif\n-\n /****************** Broadcom bnxt devices ******************/\n \n #define BROADCOM_DEV_ID_57301 0x16c8\n@@ -406,8 +353,6 @@ RTE_PCI_DEV_ID_DECL_BNXT(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57314)\n /*\n * Undef all RTE_PCI_DEV_ID_DECL_* here.\n */\n-#undef RTE_PCI_DEV_ID_DECL_BNX2X\n-#undef RTE_PCI_DEV_ID_DECL_BNX2XVF\n #undef RTE_PCI_DEV_ID_DECL_IGB\n #undef RTE_PCI_DEV_ID_DECL_IGBVF\n #undef RTE_PCI_DEV_ID_DECL_IXGBE\n", "prefixes": [ "dpdk-dev", "v4", "08/10" ] }