Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14679/?format=api
{ "id": 14679, "url": "http://patches.dpdk.org/api/patches/14679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1467988944-25004-5-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1467988944-25004-5-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1467988944-25004-5-git-send-email-thomas.monjalon@6wind.com", "date": "2016-07-08T14:42:18", "name": "[dpdk-dev,v3,04/10] mk: fix driver build with installed SDK", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7266b8f5b0d040c973d06e389529801772088df4", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1467988944-25004-5-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14679/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A15A095CE;\n\tFri, 8 Jul 2016 16:42:34 +0200 (CEST)", "from mail-wm0-f54.google.com (mail-wm0-f54.google.com\n\t[74.125.82.54]) by dpdk.org (Postfix) with ESMTP id E685591B8\n\tfor <dev@dpdk.org>; Fri, 8 Jul 2016 16:42:32 +0200 (CEST)", "by mail-wm0-f54.google.com with SMTP id n127so14311313wme.1\n\tfor <dev@dpdk.org>; Fri, 08 Jul 2016 07:42:32 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tqf7sm1713958wjc.41.2016.07.08.07.42.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 08 Jul 2016 07:42:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Fx/WCoDwNA3xvhMph4GkIMRf16fzJyTBtXe9Xbm7vic=;\n\tb=MDtiYBh3T2ELAkmpvDA+AwvkI9ayel6IyVHbuRFxLZakZ5nDNK5/iIrMIv4Ttp8q2r\n\trZotXPgqyZ6re9ks4b2GxoV9//NL1rPYcMjqN9JcUQY1L/1Kn8BrLAw8vj81H9wlF1r+\n\t20mxwERPnQXGe52s9oL47ZC2oD2XT2DzYIoGlNx8mwCZZ/v57yweJSD0taDpSZQL5SF5\n\tEYR4CGQMOmqZXU5AEMLamBX33kEh1HueXYLAb3nekC5xiSGmksAGHutoDamPxdTv3Qd+\n\tZAlbGqxgGT21p7sHbcARdT8tJkmIZjOCCkqnpuwKKLc79Lvh50gamVGe4Pq23y+PISAo\n\tj5Zw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Fx/WCoDwNA3xvhMph4GkIMRf16fzJyTBtXe9Xbm7vic=;\n\tb=cui2AUfZb2IAwXjV6OhDgSZGF27rWbU+FznPJThDAKkj05CAfSbQGVQ+7qSRWbGYho\n\tiu/oAzR6XWOV2M9SMoVKgT+Hvoc0ZPZEiIKwfFqyJWTanL7yPsio2dxkWKx0MF2XhsCz\n\t6f/wL9tmmvj4eCSdBN+bzl+1x1X3Y3aLVAChoKQe8kGArJUDs+/7FMpw9b5Vg+ES79dW\n\tb3go3AWITCoe70+wUeuWLarz6ifGdGRTBc5QTV73IoJO9y/C4WJ6ImShoMfaitJjEzBG\n\tS9gwTzp6MhUc4f5Vyj67PW2D/SFaRzx4HiyUiiLsncDA44dzgWJOOEE8idCLtyB+N3A8\n\tUD0w==", "X-Gm-Message-State": "ALyK8tINDY/UxT8wZfne7wK5q/t8Oa2rb+pJyeqzZQ5Cue26GLSK7PXINbBcx00e64mSXJtd", "X-Received": "by 10.194.200.136 with SMTP id js8mr5633619wjc.72.1467988952704; \n\tFri, 08 Jul 2016 07:42:32 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Neil Horman <nhorman@tuxdriver.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 8 Jul 2016 16:42:18 +0200", "Message-Id": "<1467988944-25004-5-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1467988944-25004-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1467972855-21873-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1467988944-25004-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 04/10] mk: fix driver build with installed SDK", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The tool pmdinfogen was called from RTE_OUTPUT/app/ which does not exist\nif building a driver outside of the SDK build.\nWhen building DPDK, RTE_SDK_BIN is RTE_OUTPUT. When building an external\ndriver, RTE_SDK_BIN must point to the installed DPDK directory containing\nincludes, libs, etc.\n\nThat's why pmdinfogen must be installed in the SDK directory and be part\nof the SDK installation.\n\nFixes: 3d781ca32874 (\"mk: do post processing on objects that register a driver\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/internal/rte.compile-pre.mk | 2 +-\n mk/rte.sdkinstall.mk | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk\nindex 5632d6e..87d2d93 100644\n--- a/mk/internal/rte.compile-pre.mk\n+++ b/mk/internal/rte.compile-pre.mk\n@@ -92,7 +92,7 @@ C_TO_O_DO = @set -e; \\\n \tif [ \\$$? -eq 0 ]; then \\\n \t\techo \\\" PMDINFOGEN\\\" $@; \\\n \t\tOBJF=`readlink -f $@`; \\\n-\t\t${RTE_OUTPUT}/app/pmdinfogen \\$$OBJF \\$$OBJF.pmd.c; \\\n+\t\t$(RTE_SDK_BIN)/app/pmdinfogen \\$$OBJF \\$$OBJF.pmd.c; \\\n \t\tif [ \\$$? -eq 0 ]; \\\n \t\tthen \\\n \t\t\techo \\\" PMDINFOBUILD\\\" $@; \\\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex b0d985c..7cd352c 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -117,6 +117,7 @@ install-runtime:\n \t$(Q)cp -a $O/lib/* $(DESTDIR)$(libdir)\n \t$(Q)$(call rte_mkdir, $(DESTDIR)$(bindir))\n \t$(Q)tar -cf - -C $O --exclude 'app/*.map' \\\n+\t\t--exclude app/pmdinfogen \\\n \t\t--exclude 'app/cmdline*' --exclude app/test \\\n \t\t--exclude app/testacl --exclude app/testpipeline app | \\\n \t tar -xf - -C $(DESTDIR)$(bindir) --strip-components=1 \\\n@@ -126,10 +127,8 @@ install-runtime:\n \t$(Q)$(call rte_mkdir, $(DESTDIR)$(sbindir))\n \t$(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/tools/dpdk_nic_bind.py, \\\n \t $(DESTDIR)$(sbindir)/dpdk_nic_bind)\n-\t$(Q)$(call rte_symlink, $(DESTDIR)$(bindir)/pmdinfogen, \\\n-\t\t\t\t $(DESTDIR)$(bindir)/dpdk_pmdinfogen)\n \t$(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/tools/pmdinfo.py, \\\n-\t\t\t\t $(DESTDIR)$(bindir)/dpdk_pmdinfo)\n+\t $(DESTDIR)$(bindir)/dpdk_pmdinfo)\n \n install-kmod:\n ifneq ($(wildcard $O/kmod/*),)\n@@ -145,8 +144,9 @@ install-sdk:\n \t$(Q)$(call rte_mkdir, $(DESTDIR)$(sdkdir))\n \t$(Q)cp -a $(RTE_SDK)/mk $(DESTDIR)$(sdkdir)\n \t$(Q)cp -a $(RTE_SDK)/scripts $(DESTDIR)$(sdkdir)\n-\t$(Q)$(call rte_mkdir, $(DESTDIR)$(targetdir))\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(targetdir)/app)\n \t$(Q)cp -a $O/.config $(DESTDIR)$(targetdir)\n+\t$(Q)cp -a $O/app/pmdinfogen $(DESTDIR)$(targetdir)/app\n \t$(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include)\n \t$(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib)\n \n", "prefixes": [ "dpdk-dev", "v3", "04/10" ] }