Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14607,
    "url": "http://patches.dpdk.org/api/patches/14607/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1467818542-30609-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1467818542-30609-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1467818542-30609-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2016-07-06T15:22:22",
    "name": "[dpdk-dev] app/test: remove useless clock estimation",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f210bd3df6d3086cb04b20e59d4780ae6a446de1",
    "submitter": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1467818542-30609-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/14607/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/14607/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 877A38D37;\n\tWed,  6 Jul 2016 17:22:53 +0200 (CEST)",
            "from mail-wm0-f42.google.com (mail-wm0-f42.google.com\n\t[74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 3D7906CCF\n\tfor <dev@dpdk.org>; Wed,  6 Jul 2016 17:22:52 +0200 (CEST)",
            "by mail-wm0-f42.google.com with SMTP id 187so33070863wmz.1\n\tfor <dev@dpdk.org>; Wed, 06 Jul 2016 08:22:52 -0700 (PDT)",
            "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\ts67sm2794189wmf.3.2016.07.06.08.22.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 06 Jul 2016 08:22:51 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=UeiEZ/N1gYWNOSH8jsVxYDupWi4Dm2fdCHhrItUgGlo=;\n\tb=EXnqXHHZQRCt+2xYyKJDR8BT3LJdV8SiCbN2mt5qsbqzCj/WcyP/a2uA4YYT94M1Fh\n\tl55gR2rrrgcgdgVmNpOB+FebdZ4uAH2OtqkQctzOSba9hhFlp8qLEbKo9Afa6hwp8SyR\n\twEhkKQbipzsRBHjBN9l/WwirLSaEi9N9hVBmMjFtRtGahyQpVi6Qq7T3GCEz+eofSgxs\n\twMfAcHRi74EgtBgBlSnkQH4y/TBvrktaxAfyhbd/jwOaQADyTIYd7Zl7QfexkBF7jrH2\n\tdaDCkSaAq0bRsjBTS3TJHjrn2suLMcuM0T5wdvmQr7a+rUIl3KI9V3Bk1YzrS+2dm/Sk\n\twcng==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=UeiEZ/N1gYWNOSH8jsVxYDupWi4Dm2fdCHhrItUgGlo=;\n\tb=ELZHxlbEJS5B8l2jLPXsCbe50Nwx/M4TceC3ZyAyBr0fDTkyvSnVtppjGbWMhPUrCf\n\t0YUv+wv3ikxT4aMUKeNNkEkM5NYTHZT8a6M2RwV1esXAUP7ExG2iCYNTDyZZgI0Ea659\n\t4Rtqg9TZVULfSw6r61mbU71JSuHlhceVQuBSoksEK0EAYMWKiiNqUviUycsk/RwlQJ2V\n\tYynMAc93e8AmN7ibS6mxscZYgDPt/MtMHB1TFKSzFpyRTjTln0OimdiKb+kGXfKKHMyf\n\temMx5H6fVvhoi9OVcOcbZ1a3ckg4DCXlFKWDi6AoCZ3vjLEQ1wx+nkOih8U4Pgu3qC99\n\tLXwQ==",
        "X-Gm-Message-State": "ALyK8tLzocXXQ/8PamVkBAZWEVo6mCNtVAuEj+CIrOlFw5oYy7kvrX0ro7eikoglsOXfWlrx",
        "X-Received": "by 10.28.9.213 with SMTP id 204mr22940950wmj.88.1467818571984;\n\tWed, 06 Jul 2016 08:22:51 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "tomasz.kantecki@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Wed,  6 Jul 2016 17:22:22 +0200",
        "Message-Id": "<1467818542-30609-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.7.0",
        "Subject": "[dpdk-dev] [PATCH] app/test: remove useless clock estimation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The function get_machclk_freq() in RED test can be replaced by\nrte_get_timer_hz() which already estimates the clock frequency at EAL init.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/test/test_red.c | 42 +-----------------------------------------\n 1 file changed, 1 insertion(+), 41 deletions(-)",
    "diff": "diff --git a/app/test/test_red.c b/app/test/test_red.c\nindex 2384c55..7d1c32c 100644\n--- a/app/test/test_red.c\n+++ b/app/test/test_red.c\n@@ -274,46 +274,6 @@ static int check_avg(double *diff, double avg, double exp_avg, double tolerance)\n }\n \n /**\n- * get the clk frequency in Hz\n- */\n-static uint64_t get_machclk_freq(void)\n-{\n-\tuint64_t start = 0;\n-\tuint64_t end = 0;\n-\tuint64_t diff = 0;\n-\tstatic uint64_t clk_freq_hz;\n-\tstruct timespec tv_start = {0, 0}, tv_end = {0, 0};\n-\tstruct timespec req = {0, 0};\n-\n-\tif (clk_freq_hz != 0)\n-\t\treturn clk_freq_hz;\n-\n-\treq.tv_sec = 0;\n-\treq.tv_nsec = NSEC_PER_SEC / 4;\n-\n-\tclock_gettime(CLOCK_REALTIME, &tv_start);\n-\tstart = rte_rdtsc();\n-\n-\tif (nanosleep(&req, NULL) != 0) {\n-\t\tperror(\"get_machclk_freq()\");\n-\t\texit(EXIT_FAILURE);\n-\t}\n-\n-\tclock_gettime(CLOCK_REALTIME, &tv_end);\n-\tend = rte_rdtsc();\n-\n-\tdiff = (uint64_t)(tv_end.tv_sec - tv_start.tv_sec) * USEC_PER_SEC\n-\t\t+ ((tv_end.tv_nsec - tv_start.tv_nsec + TEST_NSEC_MARGIN) /\n-\t\t   USEC_PER_MSEC); /**< diff is in micro secs */\n-\n-\tif (diff == 0)\n-\t\treturn 0;\n-\n-\tclk_freq_hz = ((end - start) * USEC_PER_SEC / diff);\n-\treturn clk_freq_hz;\n-}\n-\n-/**\n  * initialize the test rte_red config\n  */\n static enum test_result\n@@ -321,7 +281,7 @@ test_rte_red_init(struct test_config *tcfg)\n {\n \tunsigned i = 0;\n \n-\ttcfg->tvar->clk_freq = get_machclk_freq();\n+\ttcfg->tvar->clk_freq = rte_get_timer_hz();\n \tinit_port_ts( tcfg->tvar->clk_freq );\n \n \tfor (i = 0; i < tcfg->tconfig->num_cfg; i++) {\n",
    "prefixes": [
        "dpdk-dev"
    ]
}