Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14394,
    "url": "http://patches.dpdk.org/api/patches/14394/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1466955978-24386-3-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1466955978-24386-3-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1466955978-24386-3-git-send-email-helin.zhang@intel.com",
    "date": "2016-06-26T15:46:18",
    "name": "[dpdk-dev,v2,2/2] i40e: fix missing break in switch",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fae51c26490345eb44dbc316634956b5e8aacfee",
    "submitter": {
        "id": 14,
        "url": "http://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patches.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1466955978-24386-3-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/14394/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/14394/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 549E169A4;\n\tSun, 26 Jun 2016 17:46:34 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id F19B86948\n\tfor <dev@dpdk.org>; Sun, 26 Jun 2016 17:46:29 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 26 Jun 2016 08:46:29 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 26 Jun 2016 08:46:28 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u5QFkQTG015729;\n\tSun, 26 Jun 2016 23:46:26 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u5QFkOCb024435; Sun, 26 Jun 2016 23:46:26 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u5QFkOoN024431; \n\tSun, 26 Jun 2016 23:46:24 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.26,532,1459839600\"; d=\"scan'208\";a=\"995368384\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Helin Zhang <helin.zhang@intel.com>",
        "Date": "Sun, 26 Jun 2016 23:46:18 +0800",
        "Message-Id": "<1466955978-24386-3-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1466955978-24386-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1461210177-29330-1-git-send-email-helin.zhang@intel.com>\n\t<1466955978-24386-1-git-send-email-helin.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/2] i40e: fix missing break in switch",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "It fixes the issue reported by Coverity of 'Missing break in\nswitch', by deleting 'case I40E_VIRTCHNL_OP_FCOE', as it is\nnot necessary at all.\n\nCoverity ID 13265: Missing break in switch.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n drivers/net/i40e/i40e_pf.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c\nindex 1bd599b..b47a374 100644\n--- a/drivers/net/i40e/i40e_pf.c\n+++ b/drivers/net/i40e/i40e_pf.c\n@@ -997,11 +997,9 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev,\n \t\tPMD_DRV_LOG(INFO, \"OP_CFG_VLAN_PVID received\");\n \t\ti40e_pf_host_process_cmd_cfg_pvid(vf, msg, msglen);\n \t\tbreak;\n-\t /* Don't add command supported below, which will\n-\t *  return an error code.\n+\t/* Don't add command supported below, which will\n+\t * return an error code.\n \t */\n-\tcase I40E_VIRTCHNL_OP_FCOE:\n-\t\tPMD_DRV_LOG(ERR, \"OP_FCOE received, not supported\");\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"%u received, not supported\", opcode);\n \t\ti40e_pf_host_send_msg_to_vf(vf, opcode, I40E_ERR_PARAM,\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/2"
    ]
}