Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 143,
    "url": "http://patches.dpdk.org/api/patches/143/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1407789890-17355-13-git-send-email-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1407789890-17355-13-git-send-email-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1407789890-17355-13-git-send-email-bruce.richardson@intel.com",
    "date": "2014-08-11T20:44:48",
    "name": "[dpdk-dev,RFC,12/14] ixgbe: Make vector stores unaligned",
    "commit_ref": "",
    "pull_url": "",
    "state": "rfc",
    "archived": true,
    "hash": "fea9f16ef2bf2dab0627acdad8e2a7f0bce47b7f",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1407789890-17355-13-git-send-email-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/143/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/143/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<bricha3@ecsmtp.ir.intel.com>",
        "Received": [
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\r\n\tby dpdk.org (Postfix) with ESMTP id 42FABB391\r\n\tfor <dev@dpdk.org>; Mon, 11 Aug 2014 22:44:07 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\r\n\tby orsmga102.jf.intel.com with ESMTP; 11 Aug 2014 13:41:06 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\r\n\tby orsmga002.jf.intel.com with ESMTP; 11 Aug 2014 13:44:53 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\r\n\t[10.237.217.46])\r\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\r\n\ts7BKiq8V020967; Mon, 11 Aug 2014 21:44:52 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\r\n\tby sivswdev02.ir.intel.com with ESMTP id s7BKiqE6017723;\r\n\tMon, 11 Aug 2014 21:44:52 +0100",
            "(from bricha3@localhost)\r\n\tby sivswdev02.ir.intel.com with  id s7BKiqh1017719;\r\n\tMon, 11 Aug 2014 21:44:52 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.01,844,1400050800\"; d=\"scan'208\";a=\"586659696\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 11 Aug 2014 21:44:48 +0100",
        "Message-Id": "<1407789890-17355-13-git-send-email-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>",
        "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>",
        "Subject": "[dpdk-dev] [RFC PATCH 12/14] ixgbe: Make vector stores unaligned",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-List-Received-Date": "Mon, 11 Aug 2014 20:44:08 -0000"
    },
    "content": "When writing to the mbuf array for receiving packets, do not assume\n16-byte alignment by using aligned stores. If the pointers are only\n8-byte aligned, the program will crash due to incorrect alignment.\nChanging \"store\" to \"storeu\" fixes this.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\r\nindex 39c06e2..07314e9 100644\r\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\r\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\r\n@@ -246,7 +246,7 @@ ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\r\n \t\tdescs[3] = _mm_loadu_si128((__m128i *)(rxdp + 3));\r\n \r\n \t\t/* B.2 copy 2 mbuf point into rx_pkts  */\r\n-\t\t_mm_store_si128((__m128i *)&rx_pkts[pos], mbp1);\r\n+\t\t_mm_storeu_si128((__m128i *)&rx_pkts[pos], mbp1);\r\n \r\n \t\t/* B.1 load 1 mbuf point */\r\n \t\tmbp2 = _mm_loadu_si128((__m128i *)&sw_ring[pos+2]);\r\n@@ -257,7 +257,7 @@ ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\r\n \t\tdescs[0] = _mm_loadu_si128((__m128i *)(rxdp));\r\n \r\n \t\t/* B.2 copy 2 mbuf point into rx_pkts  */\r\n-\t\t_mm_store_si128((__m128i *)&rx_pkts[pos+2], mbp2);\r\n+\t\t_mm_storeu_si128((__m128i *)&rx_pkts[pos+2], mbp2);\r\n \r\n \t\t/* avoid compiler reorder optimization */\r\n \t\trte_compiler_barrier();\r\n",
    "prefixes": [
        "dpdk-dev",
        "RFC",
        "12/14"
    ]
}