Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14271,
    "url": "http://patches.dpdk.org/api/patches/14271/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1466688410-13826-2-git-send-email-zr@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1466688410-13826-2-git-send-email-zr@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1466688410-13826-2-git-send-email-zr@semihalf.com",
    "date": "2016-06-23T13:26:50",
    "name": "[dpdk-dev,v4,2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "f3aa6f6f95854dceb72c672e1bd2fd40bb77ac28",
    "submitter": {
        "id": 483,
        "url": "http://patches.dpdk.org/api/people/483/?format=api",
        "name": "Zyta Szpak",
        "email": "zr@semihalf.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1466688410-13826-2-git-send-email-zr@semihalf.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/14271/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/14271/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B9F3CC53A;\n\tThu, 23 Jun 2016 15:26:58 +0200 (CEST)",
            "from mail-lf0-f41.google.com (mail-lf0-f41.google.com\n\t[209.85.215.41]) by dpdk.org (Postfix) with ESMTP id E3873C538\n\tfor <dev@dpdk.org>; Thu, 23 Jun 2016 15:26:57 +0200 (CEST)",
            "by mail-lf0-f41.google.com with SMTP id f6so95398364lfg.0\n\tfor <dev@dpdk.org>; Thu, 23 Jun 2016 06:26:57 -0700 (PDT)",
            "from zr-HP-Pro-3500-Series.semihalf.local\n\t(31-172-191-173.noc.fibertech.net.pl. [31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id p6sm20255lbj.24.2016.06.23.06.26.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 23 Jun 2016 06:26:56 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=p316yf+FuQkZgIfXSxdMAB3tuL2+bUMxRN+nfyOLyCY=;\n\tb=ma1xaCsm9XtazaBkKAl8lxmAYTgwlbkwcCrOGJ3FPA+YwF5ziLJDtPwhU9/gyewdoW\n\tx6VzvB4/lIoTFvGVMYLUgIJKHOU3btjH3wjSVp22uF2J3d6TtVNlKuRILJPCGUEynFmQ\n\tfKGcgyOh/9apPfai9u2FjxSEE54dbPE6w8A9rrh+R5b1ViYnHvm5czKFBGNu48GvFMYV\n\tz7Rx7Ac0ikJb86K12fwu7bltrBhL3qG+wH/a85gpOEe+rmjpifZjpOV4Z50p+PJ6sRww\n\tQQSCMngKH6EoAAsivONEK36eANJTnamUmb0ilBtDM1dlLeyHpP8KN0huy3FYHF5CHotK\n\tDsJw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=p316yf+FuQkZgIfXSxdMAB3tuL2+bUMxRN+nfyOLyCY=;\n\tb=LqMEGryIald/8IrlIYtzBVdiK9NkMKwktUcTrUoUgzJ1BWoybL5wEaD1XEKGnU6KWj\n\tqVU9ntToX6PML55thaQyFIAKklj/+g4jesj1NIG/55b3sokJQL6lPtjEGwXcaE/DjqUD\n\t6HNORoa+qxi3Wfo5exAJCH1IfqkpQKp8IWLxHZMw7Rm0GdYpajONRdbQdakrDOakbEqG\n\tJ7aqtBZsoynI3dRE0C/I6fGMAYlNAuSFsFEQg4A1juwi9JFGeKusFSl4dx5iknDgSxDI\n\thlMalrLmvq4HrXckKFH5TJ13+WuueAEm91G8rv8GMqh72iDpatm/9bJXXaPZJPmzeerY\n\tS6WQ==",
        "X-Gm-Message-State": "ALyK8tIMdAPX1eb26Fy2GRfbHSL6lkY02uQLksfOogzaH9O1a1yWg2lOoXthFdwjDNmjgg==",
        "X-Received": "by 10.46.0.219 with SMTP id e88mr11387619lji.55.1466688417647;\n\tThu, 23 Jun 2016 06:26:57 -0700 (PDT)",
        "From": "zr@semihalf.com",
        "To": "remy.horton@intel.com, thomas.monjalon@6wind.com, wenzhuo.lu@intel.com, \n\thelin.zhang@intel.com, konstantin.ananyev@intel.com,\n\tjingjing.wu@intel.com",
        "Cc": "dev@dpdk.org,\n\tZyta Szpak <zr@semihalf.com>",
        "Date": "Thu, 23 Jun 2016 15:26:50 +0200",
        "Message-Id": "<1466688410-13826-2-git-send-email-zr@semihalf.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1466688410-13826-1-git-send-email-zr@semihalf.com>",
        "References": "<1466688410-13826-1-git-send-email-zr@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH v4 2/2] examples/ethtool: use\n\trte_eth_dev_get_reg_info for reg params",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Zyta Szpak <zr@semihalf.com>\n\nVersion 4 of fixing the fixed register width assumption.\nThe app was allocating too little space for 64-bit registers\nwhich resulted in memory corruption. This commit resolves\nthis by getting the number of registers and size of register\nby rte_eth_dev_get_reg_info function called first time\nwith data=NULL.\n\nSigned-off-by: Zyta Szpak <zr@semihalf.com>\n---\n examples/ethtool/lib/rte_ethtool.c | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c\nindex 54391f2..a1f91d4 100644\n--- a/examples/ethtool/lib/rte_ethtool.c\n+++ b/examples/ethtool/lib/rte_ethtool.c\n@@ -46,6 +46,7 @@ int\n rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo)\n {\n \tstruct rte_eth_dev_info dev_info;\n+\tstruct rte_dev_reg_info reg_info;\n \tint n;\n \n \tif (drvinfo == NULL)\n@@ -65,7 +66,9 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo)\n \t\tdev_info.pci_dev->addr.domain, dev_info.pci_dev->addr.bus,\n \t\tdev_info.pci_dev->addr.devid, dev_info.pci_dev->addr.function);\n \n-\tn = rte_eth_dev_get_reg_length(port_id);\n+\tmemset(&reg_info, 0, sizeof(reg_info));\n+\trte_eth_dev_get_reg_info(port_id, &reg_info);\n+\tn = reg_info.length;\n \tif (n > 0)\n \t\tdrvinfo->regdump_len = n;\n \telse\n@@ -86,12 +89,16 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo)\n int\n rte_ethtool_get_regs_len(uint8_t port_id)\n {\n-\tint count_regs;\n+\tstruct rte_dev_reg_info reg_info;\n+\tint ret;\n+\n+\tmemset(&reg_info, 0, sizeof(reg_info));\n+\n+\tret = rte_eth_dev_get_reg_info(port_id, &reg_info);\n+\tif (ret)\n+\t\treturn ret;\n \n-\tcount_regs = rte_eth_dev_get_reg_length(port_id);\n-\tif (count_regs > 0)\n-\t\treturn count_regs * sizeof(uint32_t);\n-\treturn count_regs;\n+\treturn reg_info.length * reg_info.width;\n }\n \n int\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "2/2"
    ]
}