Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14220/?format=api
{ "id": 14220, "url": "http://patches.dpdk.org/api/patches/14220/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1466586396-22618-15-git-send-email-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1466586396-22618-15-git-send-email-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1466586396-22618-15-git-send-email-shreyansh.jain@nxp.com", "date": "2016-06-22T09:06:33", "name": "[dpdk-dev,v5,14/17] ethdev: do not scan all pci devices on attach", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cc9e7b2e9a27609618cc78cb2f7286055af3609a", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1466586396-22618-15-git-send-email-shreyansh.jain@nxp.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14220/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0A3FDC578;\n\tWed, 22 Jun 2016 11:08:06 +0200 (CEST)", "from na01-bl2-obe.outbound.protection.outlook.com\n\t(mail-bl2on0061.outbound.protection.outlook.com [65.55.169.61])\n\tby dpdk.org (Postfix) with ESMTP id 217F3C4C0\n\tfor <dev@dpdk.org>; Wed, 22 Jun 2016 11:06:50 +0200 (CEST)", "from BN3PR0301CA0069.namprd03.prod.outlook.com (10.160.152.165) by\n\tCO2PR03MB2376.namprd03.prod.outlook.com (10.166.93.24) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id\n\t15.1.523.12; Wed, 22 Jun 2016 09:06:49 +0000", "from BL2FFO11FD040.protection.gbl (2a01:111:f400:7c09::190) by\n\tBN3PR0301CA0069.outlook.office365.com (2a01:111:e400:401e::37) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via\n\tFrontend Transport; Wed, 22 Jun 2016 09:06:49 +0000", "from az84smr01.freescale.net (192.88.158.2) by\n\tBL2FFO11FD040.mail.protection.outlook.com (10.173.161.136) with\n\tMicrosoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport;\n\tWed, 22 Jun 2016 09:06:48 +0000", "from Tophie.ap.freescale.net (Tophie.ap.freescale.net\n\t[10.232.14.199])\n\tby az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tu5M9663n022009; Wed, 22 Jun 2016 02:06:46 -0700" ], "Authentication-Results": "spf=fail (sender IP is 192.88.158.2)\n\tsmtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed)\n\theader.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.158.2 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.158.2; helo=az84smr01.freescale.net;", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "<dev@dpdk.org>", "CC": "<viktorin@rehivetech.com>, <thomas.monjalon@6wind.com>", "Date": "Wed, 22 Jun 2016 14:36:33 +0530", "Message-ID": "<1466586396-22618-15-git-send-email-shreyansh.jain@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com>", "References": "<1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>\n\t<1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com>", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131110600085701626;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()", "X-Forefront-Antispam-Report": "CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(11100500001)(81156014)(2906002)(6806005)(5890100001)(586003)(68736007)(92566002)(19580395003)(5003940100001)(356003)(104016004)(7846002)(8676002)(81166006)(189998001)(50226002)(8936002)(110136002)(4326007)(76176999)(97736004)(229853001)(2351001)(77096005)(106466001)(87936001)(86362001)(48376002)(33646002)(50986999)(575784001)(2950100001)(50466002)(47776003)(36756003)(85426001)(69596002)(19580405001)(105606002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2376;\n\tH:az84smr01.freescale.net; FPR:; \n\tSPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BL2FFO11FD040;\n\t1:vlECXwVyRvPd8x4onUeESB1Bua5SC+suxjLr4jQ26uHV6SqoowVuZdEi3XzjEETM7JzHQfOpQ/mpqJOct1lmm2YtwzPCN5eH+NzquShl73XmBp+CcAKiVVQTLFk+nyhS03WS7KZf8fh4V+GI98skv0UaovtInT7AYjhnWV3PNdvvbYGOlSDFRIcMYKPq7+5s9YX1c6+ZVcb4FlgQ9cghaRrvFB7ECbn+bO2Lhqqifq/uKPsnWRGF9PYxKZCKT3r+5le9lRcFktrg865jawNlqRNSjUVo69eLN6h1ZU5TlxtFuCXuQKwyQX89JxfrHbizN+TxePjR7F3ZNnSppQk+N/T80kAv5n8E4kOzgrweQOgRNkZR9/08M4LklkPvYaBk0XH/3rpLaTBBC7M6wGlCasDYqURztJLJXhIoQMUllq/N6ZU3uz274dgIfkGh3qaIoAX3o6xDIooFpNV8W+LBOtpz9FfqUXzb8kzJassEXtPsJ74ATegk2X9jHWSasn6w4sfKvNAOv+43duYeTW2aLQ4YvktQPi4tQMagcAnUTqDA8dRWDwfGKgGd0SCTNfXz5tiZR+PRs+a8/zH6msSgRg==", "1; CO2PR03MB2376;\n\t2:ynBLXQUdlVLEFRaz8xqa0srZxP9+5vYyD5n+4owc67vTYoAHJgjmCe3nIoQMS9m8guDYBSRBEqoxDsGUbZtJx6BZnLR6zon13HKdHCLJKB8P3peVuvfieNmrJVB7AgclJ6ozaPkwROKN6NW99soRK5vdHb5l5Vk6blDjlnfRdEDtR82I+kWW+pEpoucohdZO;\n\t3:OSV/7MJfHVbdNR6Zum3WNtt5Q0UH3iy4OV1qCZcIen2VvqMB4bAL0W1gn0eB6QeKCv+PMWV2XupJ07ONVTgrzWZAKY1xMkM0LvRano/79Hov5AppNYeqsgqJFlRVW28lRoaa6dVezv+eJgMxAPg6hEzxIFqp7lwa+XNUetYSesgiIkcbZG0Lgp7B1QocJNi/J8W8T1mX6J6w36hfIttrS5z65l+dqvXqVjNONqnUjRY=;\n\t25:Rhhjla84ulksM7KDEK+0f9IwTPf8VAStdWVRCIF28UTZnWw9IeM3cr87/z/MGcFuSANhpQQ+POMXvZHv9X4Ada7UGI0yCzSLeIldCMCkE6qAz4oR/Nm+62hayrg/XhnDZLTF1OnGBA76eHskP9oKr/33GGwk1P0u9aTRXa5Q6hjorJd1EXOjm53LI9IR8S5pQaw44tBShW/fKQoB0VeoTfSCf/iGP1LWHerxZBaC1wO+X3ZPyHGGnbw5UQPZeZxwlD1oG0NAqjwApDlhl5eAmmfyM3VyzLMWFjw0sUigDT+nPEA7MS5qpECttB84V+LbH9/XVX6mLV98LnSQlUgGGz7NFlx0vn0t9P6CUAf3xLruPGG/kCAAgoJsvlAVy0koMTwz93Y/IAImsTAEETDwYH19FE8EuX/bH6+WDtjDD0g=", "1; CO2PR03MB2376;\n\t4:tr5w5JzD0Ie0Q7vl50Vy6wQUUtFvxf0AyrqVCxQNBP5Qjf14Fyd2/dZRVv2W8RihbLwfuBHEms6m0ve13eUbo7KmTAefZpC2pnCKoE4B7qJXCjU/It+xZWfEHL8KU6/OIYli8ctFfeB7+qCoBhcQY7Y4Q8vVEarCVwlneBTzXvcNRk5Udh5SV/fO1lzhg/rQXQdH6LotGo1Lc4rmHKYMkJp2zNVnIGTi5SFxiy6M134OzYvjzn0Q/Ov5eXUvzmHaEmx2e6mo4gOh93pe017zuTBrM46NJ5Sc0SIKaOT4j/8jbl2KjFesNESqK/+AIxrpCPxZgQQFaySCHWAlNI76jAQW3e0uu/Pjny0LsWZ0Q5WP6p/iQsnEztXg0sOmR16d/fRvwekhWrwhbDLtVmvCz28h/ZvUfXKihOv9MFZvlk8xesmCKDODl/alWPXl+lHENX0+ZCDGEDLZG+lvXJZFViL2nVJUG7MjV7Wi8ohtrS1YGYWQEiQXFRqzJBpbC8Q1zAHNSeQA74xAtxrpNfVdWQ==", "=?us-ascii?Q?1; CO2PR03MB2376;\n\t23:3FN/cgh+QXIIyxxXdOlcdQ08cQF/NDCYU/Hdjww6o?=\n\t=?us-ascii?Q?3gqBW90nH7LckTyuDeHopja1Y/vp02iKVNVfu/mu4bHskmsQHTLQHH0KsWyc?=\n\t=?us-ascii?Q?oTgY9sOZa0lcKmezJ92XC4p6qXmZPfpX20x4PLSiFn5veC+7ronLbJzFLTjQ?=\n\t=?us-ascii?Q?yl7fq4JPSoecfU9ZM7H8kodUvNh+juz12VAD9gRmuSXson+HnxIhUwYyDzLk?=\n\t=?us-ascii?Q?glmjNFA6bbzQyKrGLWF0X/e0AjQv18ANfUX4GeWIfmJWmKc7gUF2nl1kRJyS?=\n\t=?us-ascii?Q?KblInr74Xkxgfx8pevOmYh9CY9tqnrlgqQiRazhNufqo5IGCSaTkuGfr2vKv?=\n\t=?us-ascii?Q?vkEBMn9bb6ZUE1PNNToTF7H4Q4zsKb0X0BgYat4ykyPfe/mTQR9VrLAdSVDM?=\n\t=?us-ascii?Q?F0maoowfjB+1Kuli1TxiwcXvAGb7KnYFg342ztIUY7HDJr+/3yOxNCcA2N5U?=\n\t=?us-ascii?Q?wPuwx6H/1adL0yeVqwGWoxNw3fkXLEWcj9FDbA7Umx1xjqnswOxUVHNSXlQN?=\n\t=?us-ascii?Q?aNTerTEV3uSXPnA+qH2VNfXXtcS74v7X9ruxg+BP62mt2hr5xODUJvlzqGWG?=\n\t=?us-ascii?Q?zglajfJkpFK1Nvc3XnMWRwNpp6fdC64UQHgrIpoMEOkRurIx0tiGmdb0wNqh?=\n\t=?us-ascii?Q?A/MpyUfqDAUygftK4mIRq3iP+bQZ9pvek4utAzTun48iz1M7HyjbwtDfs1xq?=\n\t=?us-ascii?Q?YnNZxfu/wXGc2eRMnSRzoOlz+lqxudYXvOvmjpVYBHaXtOlPElNoL7b5m5Jk?=\n\t=?us-ascii?Q?TSacvD9ln7a1RRp5K9qK8nW67m6DpKgNn/dMbC439DwTnAslS9rPzIKwkxn4?=\n\t=?us-ascii?Q?71VfzvWqIWyXx8FTDrgKoPJ/5aDWm+zeG89ehOOZNZK9xVEMmyW1y99bjNCe?=\n\t=?us-ascii?Q?WO1hpnr/eczWASyy5nBp7RgGd/bR8MzrIVUW/YTDPXLjJzYLg2HEkew5bFFy?=\n\t=?us-ascii?Q?jgNSXVV/iQisM9OIytYp6XlAzZxQ5sX46oEFul2WxwEgQYJHI3mxLhjZumq1?=\n\t=?us-ascii?Q?k8GlSwS/VqO1/dCJ2C7iqZKIbxw3kySmD6gofRy4hv6Hd1y8J8WwqvEMZbjg?=\n\t=?us-ascii?Q?lE6qPVzDchqN4CZtZVJZkUIhIYu5Q3YzV+4ZJXPs/K5wVbu6V1rm0T00mLwj?=\n\t=?us-ascii?Q?ZP5d/+/maQYZxpz/TeVbLmRyboWHfahOxTv475n1maSKM2KXCKeOQ=3D=3D?=", "1; CO2PR03MB2376;\n\t6:aiU2h7lz4mBw8RJvyxKWJ5hFmwC/Q19ePH3KxlWExd5BeSupqzGYwLseEvVSMo+pEG1Wp5AYuU28Q2HXXDwKR9IBuhNwV1gUJ+I1iEtltAZi/3ThNfEvYdvAEh74hfwktwdf+XYKunQezd6tkVlco9egcnqo6VVzww3DegWCLooaoxITfPFzbpNGtmRD4j9E6frmIwDRoFPt1G/SKby2omSuuU8Pp8mFVxSDVqsxVJENoxim2i68u1mzQPlCbO2tDNdqEC4g3b4VOSBtxi6HDpMUhJ+Zozegb3ny/VSwEFgvZWpPt2zTWs1Uw6K4hO5E;\n\t5:MRS/h7DnGumKjbCxu4q8QAe1T9PIlVQ3m4XV/YjuhRx8TrpvCDRA/XpaRQcrUSLqlQCjv21pS27jdt8yVf5uIHNt9upctxVwhRD4Fc1gDbVIq2sGx0n4tppxxW7x6QJj9DgF1FCLSD4mzEpid5gv/cvr6+/A4RIGlwPCFkuEnQE=;\n\t24:cVoeFVseoItzdnY66rhkbBEUXKOz5IoAr0pbCrqOQMCAmfefjIFpYU5Vae6hpc9RxMxDg+hC6hYWYZ7aKGfVC0U6Yrf06Xd7wFL4+EnOJUA=;\n\t7:JRuvUlEaPyRgLDJYnLGXQZr1RyqA323VFwrVbaH7/g8cfmQCSpY1XBUplU7OysCaUOZMIOxrg/TRNgsHkwWNDeeEPDbm8oZ7hpYCvnw2al6ub8+kQ/L/i9tSYYJAHb8h1V7ofwRTouS4M7OsR5N58Jtu+SH541rTrDAeg4pDvDxz/8KsR3i8nHkjlNTqVDYqK6LgfE8+puKcrAz6TfVObP190IcNyjQeMKFr4M5hsM09Aa4mDCdRwX5xx/QjfaGnGe7BjZNfMtBUB7BpaU/lqw==" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "32ca6fc2-3cfc-499a-2298-08d39a7c8ada", "X-Microsoft-Antispam": "UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR03MB2376;", "X-Microsoft-Antispam-PRVS": "<CO2PR03MB2376E6A10B3D6EBA4D569466902C0@CO2PR03MB2376.namprd03.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(601004)(2401047)(13023025)(13018025)(8121501046)(13017025)(13015025)(13024025)(5005006)(3002001)(10201501046)(6055026);\n\tSRVR:CO2PR03MB2376; BCL:0; PCL:0; RULEID:(400006); SRVR:CO2PR03MB2376;", "X-Forefront-PRVS": "0981815F2F", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Jun 2016 09:06:48.3361\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.158.2]; \n\tHelo=[az84smr01.freescale.net]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO2PR03MB2376", "Subject": "[dpdk-dev] [PATCH v5 14/17] ethdev: do not scan all pci devices on\n\tattach", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "No need to scan all devices, we only need to update the device being\nattached.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n lib/librte_eal/common/eal_common_pci.c | 11 ++++++++---\n lib/librte_ether/rte_ethdev.c | 3 ---\n 2 files changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex dfd0a8c..d05dda4 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -339,6 +339,11 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)\n \tif (addr == NULL)\n \t\treturn -1;\n \n+\t/* update current pci device in global list, kernel bindings might have\n+\t * changed since last time we looked at it */\n+\tif (pci_update_device(addr) < 0)\n+\t\tgoto err_return;\n+\n \tTAILQ_FOREACH(dev, &pci_device_list, next) {\n \t\tif (rte_eal_compare_pci_addr(&dev->addr, addr))\n \t\t\tcontinue;\n@@ -351,9 +356,9 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)\n \treturn -1;\n \n err_return:\n-\tRTE_LOG(WARNING, EAL, \"Requested device \" PCI_PRI_FMT\n-\t\t\t\" cannot be used\\n\", dev->addr.domain, dev->addr.bus,\n-\t\t\tdev->addr.devid, dev->addr.function);\n+\tRTE_LOG(WARNING, EAL,\n+\t\t\"Requested device \" PCI_PRI_FMT \" cannot be used\\n\",\n+\t\taddr->domain, addr->bus, addr->devid, addr->function);\n \treturn -1;\n }\n \ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex ace8353..6f2b169 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -469,9 +469,6 @@ rte_eth_dev_is_detachable(uint8_t port_id)\n static int\n rte_eth_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id)\n {\n-\t/* re-construct pci_device_list */\n-\tif (rte_eal_pci_scan())\n-\t\tgoto err;\n \t/* Invoke probe func of the driver can handle the new device. */\n \tif (rte_eal_pci_probe_one(addr))\n \t\tgoto err;\n", "prefixes": [ "dpdk-dev", "v5", "14/17" ] }