Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140178/?format=api
{ "id": 140178, "url": "http://patches.dpdk.org/api/patches/140178/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240517174044.90952-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517174044.90952-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517174044.90952-7-stephen@networkplumber.org", "date": "2024-05-17T17:35:13", "name": "[v7,6/9] test/pmd_ring: initialize mbufs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6627c62076b945eb0f0f71963365284d79890ba1", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240517174044.90952-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31946, "url": "http://patches.dpdk.org/api/series/31946/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31946", "date": "2024-05-17T17:35:07", "name": "Use weak atomic operations for SW PMD counters", "version": 7, "mbox": "http://patches.dpdk.org/series/31946/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/140178/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/140178/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4B9E44052;\n\tFri, 17 May 2024 19:41:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 075F74069F;\n\tFri, 17 May 2024 19:40:58 +0200 (CEST)", "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 11E5740689\n for <dev@dpdk.org>; Fri, 17 May 2024 19:40:53 +0200 (CEST)", "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1ec41d82b8bso19064605ad.2\n for <dev@dpdk.org>; Fri, 17 May 2024 10:40:53 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0bf31032sm158830485ad.131.2024.05.17.10.40.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 May 2024 10:40:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715967652;\n x=1716572452; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=emfW8pqQWo/kkBypu+P+JiAY/UdpbCFtvVnSZa+FuiE=;\n b=jsAf8g5s7eKgn/8mR5FUy6CUUz+y4fV0gRYZmusX1bm9twicnVchk4zqeqA6TFFaK+\n 8pKb9cLZysB7sfzUCCSvuMVcWqCb2mli6zjllFxHryoHJSGjlQIqlDHxVvvpXDfjNMx+\n dKBh9uwnVtFvOKsdLMTH4xUeeY/HlOb7Bt0JWeTTIXL5IK402MFATvY5JH3zz6OgeCV+\n bc5Ks3+BZBcjLyH8d4Dchou0oJ90s7soYkjXWoUmL43Z60jfryjsr6arCxI5ZovbT13e\n 0iqPUoz9igQ9s18JMJqEvCaVpvoApSfxvxESuYh2RFsADSywGk+Wea0uhjQfTVa4PqOX\n kHIA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715967652; x=1716572452;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=emfW8pqQWo/kkBypu+P+JiAY/UdpbCFtvVnSZa+FuiE=;\n b=fKvSFbEYfmuZl1TY62sWsF084gM2C/bsTPDP/uqYfIcDoqiP1vqK+x/+nwDhvmuIVa\n Bi2lwH0RRH7YrQwsSd/KC+2rZK2FdqbbO3hawkveuDJo/S0kI1LsgKUG9NKyS8q6WMBI\n TjeCHz6+7yPEc5lnErPEYqoBv6T5UGnXOuBkoqn+o8DIsontTWpid4OTLhKUdz+45zp9\n 3ZUbVGyRKWVOmGCt4GWM9xL7ZtugG48LbSnEageFqbFkv3/WNN7BjITkwUXB8pck9nQT\n EE7q5arsW166cmbMwYPbJXFJh+Ugt2gvMuc2XxsA6Bd5N9uQYeRfrqPLiOwNSfal0rJq\n f2+A==", "X-Gm-Message-State": "AOJu0YzGV3Yq7gDqRn9KRTx3LP57y4hM4BSBiuY1oIPNeqa2wBfiGJN6\n MtNgtKf/ofTtcHtLlB7DZClATKmdSN92RSrDpkcEfqiXJ1ME3hMMxUjyc8b3+37FrHXgewMI9lW\n TW5I=", "X-Google-Smtp-Source": "\n AGHT+IGZKEzGHAkzv2n28S9NoaKcdrhnPjLayp8QyPL66E+m1yDhyOERcs9eeh0CYjhOj0tvfRf2EA==", "X-Received": "by 2002:a17:902:e80d:b0:1e3:d4a2:3882 with SMTP id\n d9443c01a7336-1ef43d0ad97mr296814685ad.2.1715967652181;\n Fri, 17 May 2024 10:40:52 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v7 6/9] test/pmd_ring: initialize mbufs", "Date": "Fri, 17 May 2024 10:35:13 -0700", "Message-ID": "<20240517174044.90952-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517174044.90952-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517174044.90952-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Do not pass uninitialized data into the ring PMD.\nThe mbufs should be initialized first so that length is zero.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_pmd_ring.c | 26 +++++++++++++++++++++-----\n 1 file changed, 21 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/test_pmd_ring.c b/app/test/test_pmd_ring.c\nindex e83b9dd6b8..55455ece7f 100644\n--- a/app/test/test_pmd_ring.c\n+++ b/app/test/test_pmd_ring.c\n@@ -19,6 +19,14 @@ static struct rte_mempool *mp;\n struct rte_ring *rxtx[NUM_RINGS];\n static int tx_porta, rx_portb, rxtx_portc, rxtx_portd, rxtx_porte;\n \n+/* make a valid zero sized mbuf */\n+static void\n+test_mbuf_init(struct rte_mbuf *mbuf)\n+{\n+\tmemset(mbuf, 0, sizeof(*mbuf));\n+\trte_pktmbuf_reset(mbuf);\n+}\n+\n static int\n test_ethdev_configure_port(int port)\n {\n@@ -68,14 +76,16 @@ test_ethdev_configure_port(int port)\n static int\n test_send_basic_packets(void)\n {\n-\tstruct rte_mbuf bufs[RING_SIZE];\n+\tstruct rte_mbuf bufs[RING_SIZE];\n \tstruct rte_mbuf *pbufs[RING_SIZE];\n \tint i;\n \n \tprintf(\"Testing send and receive RING_SIZE/2 packets (tx_porta -> rx_portb)\\n\");\n \n-\tfor (i = 0; i < RING_SIZE/2; i++)\n+\tfor (i = 0; i < RING_SIZE / 2; i++) {\n+\t\ttest_mbuf_init(&bufs[i]);\n \t\tpbufs[i] = &bufs[i];\n+\t}\n \n \tif (rte_eth_tx_burst(tx_porta, 0, pbufs, RING_SIZE/2) < RING_SIZE/2) {\n \t\tprintf(\"Failed to transmit packet burst port %d\\n\", tx_porta);\n@@ -99,14 +109,16 @@ test_send_basic_packets(void)\n static int\n test_send_basic_packets_port(int port)\n {\n-\tstruct rte_mbuf bufs[RING_SIZE];\n+\tstruct rte_mbuf bufs[RING_SIZE];\n \tstruct rte_mbuf *pbufs[RING_SIZE];\n \tint i;\n \n \tprintf(\"Testing send and receive RING_SIZE/2 packets (cmdl_port0 -> cmdl_port0)\\n\");\n \n-\tfor (i = 0; i < RING_SIZE/2; i++)\n+\tfor (i = 0; i < RING_SIZE / 2; i++) {\n+\t\ttest_mbuf_init(&bufs[i]);\n \t\tpbufs[i] = &bufs[i];\n+\t}\n \n \tif (rte_eth_tx_burst(port, 0, pbufs, RING_SIZE/2) < RING_SIZE/2) {\n \t\tprintf(\"Failed to transmit packet burst port %d\\n\", port);\n@@ -134,10 +146,11 @@ test_get_stats(int port)\n \tstruct rte_eth_stats stats;\n \tstruct rte_mbuf buf, *pbuf = &buf;\n \n+\ttest_mbuf_init(&buf);\n+\n \tprintf(\"Testing ring PMD stats_get port %d\\n\", port);\n \n \t/* check stats of RXTX port, should all be zero */\n-\n \trte_eth_stats_get(port, &stats);\n \tif (stats.ipackets != 0 || stats.opackets != 0 ||\n \t\t\tstats.ibytes != 0 || stats.obytes != 0 ||\n@@ -173,6 +186,8 @@ test_stats_reset(int port)\n \tstruct rte_eth_stats stats;\n \tstruct rte_mbuf buf, *pbuf = &buf;\n \n+\ttest_mbuf_init(&buf);\n+\n \tprintf(\"Testing ring PMD stats_reset port %d\\n\", port);\n \n \trte_eth_stats_reset(port);\n@@ -228,6 +243,7 @@ test_pmd_ring_pair_create_attach(void)\n \tint ret;\n \n \tmemset(&null_conf, 0, sizeof(struct rte_eth_conf));\n+\ttest_mbuf_init(&buf);\n \n \tif ((rte_eth_dev_configure(rxtx_portd, 1, 1, &null_conf) < 0)\n \t\t\t|| (rte_eth_dev_configure(rxtx_porte, 1, 1,\n", "prefixes": [ "v7", "6/9" ] }