Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140176/?format=api
{ "id": 140176, "url": "http://patches.dpdk.org/api/patches/140176/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240517174044.90952-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517174044.90952-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517174044.90952-5-stephen@networkplumber.org", "date": "2024-05-17T17:35:11", "name": "[v7,4/9] net/af_xdp: use generic SW stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "be123097703ee9661784161f4db8b367eafb38af", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240517174044.90952-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31946, "url": "http://patches.dpdk.org/api/series/31946/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31946", "date": "2024-05-17T17:35:07", "name": "Use weak atomic operations for SW PMD counters", "version": 7, "mbox": "http://patches.dpdk.org/series/31946/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/140176/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/140176/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A214044052;\n\tFri, 17 May 2024 19:41:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5F7F2406BA;\n\tFri, 17 May 2024 19:40:55 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id 1E0BE40649\n for <dev@dpdk.org>; Fri, 17 May 2024 19:40:51 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-1ee42b97b32so16713655ad.2\n for <dev@dpdk.org>; Fri, 17 May 2024 10:40:51 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0bf31032sm158830485ad.131.2024.05.17.10.40.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 May 2024 10:40:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715967650;\n x=1716572450; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=M92z2FKHJ+0H0kLF2iGoaoslWHmfp5DjMjDw1u/F2fI=;\n b=1CdK8wER0orH7RQ7aCOwjs7DM+RZTz7Aa7tU3FOoqkU55YcCnF7HzBa4NX6m7ing5/\n Y9Oo0/8jDa+RwNwc9HKSdEuLEvVUj5s+P4blzEH3F6/d5ahjxz0lZAT3yOFhqPUbjsJl\n zOqUckLYRowZcuxZsinV7l5xoq9Gp64ytv4kTcovV6JC3jxiHqruuIbEhQosGvCRIPw9\n f6tlZPChNiC/VG7nIVPZeol/L0CLomCKw7X4n2Xh4AINVef56HEb+elTlwEZTWTqEq9a\n A53DJpc7+pJu79bqlYxbfL7aYML1ePanOH1hTNBXL0wFOQFJtAT9cwpTTAK7rNfgG3lh\n mJkg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715967650; x=1716572450;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=M92z2FKHJ+0H0kLF2iGoaoslWHmfp5DjMjDw1u/F2fI=;\n b=GCnfMbhNhRJs7iPSXtVND+Dju3MVJLYanNksB8p8+rlEmRg31i6J/ABj+bKrfrfDfx\n R1i2ZsUgtpQ2P4bXQpFlnM7NC1BVYkmudfS580ZKHflaOdhS5DM2p9SJ0CtSZia5JW3Y\n YzpBn8VBaU7zj8wqlo7ptiWWHq33ztltTG6cUcT/00oUy/ten6/z/TIdg1pBufmictPa\n TXDdEMsTMmXf0rTxxYSVj5O4dOLOzcUrKClbtHPIhqU63PVPCmBoCKH14Srqf1uL+3if\n 9bjkSlJnWQXje3tLEpaMlDu0drLaZDzQPKCA8LX4O53Ct+C/pB/0PWHYgRWHXg+imG7g\n AbFg==", "X-Gm-Message-State": "AOJu0Ywc57ujpTYNR7QVyqzYnqKCUVozlQaTijKXDGh8KdYAAMgWXMZ5\n Y2G//yoKTJV6SHsG8ViT4wTNJhfLuFaBpQtQANYElo6kfMHjm3N0S+gVporvzl2MT5WBwSldEph\n VyME=", "X-Google-Smtp-Source": "\n AGHT+IG78XxxW/PkfES21go0+AQuorzk+4tuMixpSfimJW0JqGpSmn6rZHkWbdh54/sdIbKfdCtBsg==", "X-Received": "by 2002:a17:902:ce10:b0:1f2:ecb5:f24a with SMTP id\n d9443c01a7336-1f2ecb5f339mr238815ad.17.1715967650215;\n Fri, 17 May 2024 10:40:50 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Ciara Loftus <ciara.loftus@intel.com>", "Subject": "[PATCH v7 4/9] net/af_xdp: use generic SW stats", "Date": "Fri, 17 May 2024 10:35:11 -0700", "Message-ID": "<20240517174044.90952-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517174044.90952-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517174044.90952-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use common code for all SW stats.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 97 +++++++----------------------\n 1 file changed, 24 insertions(+), 73 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 6ba455bb9b..e5228a1dc1 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -20,6 +20,7 @@\n #include <rte_ethdev.h>\n #include <ethdev_driver.h>\n #include <ethdev_vdev.h>\n+#include <ethdev_swstats.h>\n #include <rte_kvargs.h>\n #include <bus_vdev_driver.h>\n #include <rte_string_fns.h>\n@@ -120,19 +121,13 @@ struct xsk_umem_info {\n \tuint32_t max_xsks;\n };\n \n-struct rx_stats {\n-\tuint64_t rx_pkts;\n-\tuint64_t rx_bytes;\n-\tuint64_t rx_dropped;\n-};\n-\n struct pkt_rx_queue {\n \tstruct xsk_ring_cons rx;\n \tstruct xsk_umem_info *umem;\n \tstruct xsk_socket *xsk;\n \tstruct rte_mempool *mb_pool;\n \n-\tstruct rx_stats stats;\n+\tstruct rte_eth_counters stats;\n \n \tstruct xsk_ring_prod fq;\n \tstruct xsk_ring_cons cq;\n@@ -143,17 +138,11 @@ struct pkt_rx_queue {\n \tint busy_budget;\n };\n \n-struct tx_stats {\n-\tuint64_t tx_pkts;\n-\tuint64_t tx_bytes;\n-\tuint64_t tx_dropped;\n-};\n-\n struct pkt_tx_queue {\n \tstruct xsk_ring_prod tx;\n \tstruct xsk_umem_info *umem;\n \n-\tstruct tx_stats stats;\n+\tstruct rte_eth_counters stats;\n \n \tstruct pkt_rx_queue *pair;\n \tint xsk_queue_idx;\n@@ -308,7 +297,6 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct xsk_ring_prod *fq = &rxq->fq;\n \tstruct xsk_umem_info *umem = rxq->umem;\n \tuint32_t idx_rx = 0;\n-\tunsigned long rx_bytes = 0;\n \tint i;\n \tstruct rte_mbuf *fq_bufs[ETH_AF_XDP_RX_BATCH_SIZE];\n \n@@ -363,16 +351,13 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \t\trte_pktmbuf_pkt_len(bufs[i]) = len;\n \t\trte_pktmbuf_data_len(bufs[i]) = len;\n-\t\trx_bytes += len;\n+\n+\t\trte_eth_count_mbuf(&rxq->stats, bufs[i]);\n \t}\n \n \txsk_ring_cons__release(rx, nb_pkts);\n \t(void)reserve_fill_queue(umem, nb_pkts, fq_bufs, fq);\n \n-\t/* statistics */\n-\trxq->stats.rx_pkts += nb_pkts;\n-\trxq->stats.rx_bytes += rx_bytes;\n-\n \treturn nb_pkts;\n }\n #else\n@@ -384,7 +369,6 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct xsk_umem_info *umem = rxq->umem;\n \tstruct xsk_ring_prod *fq = &rxq->fq;\n \tuint32_t idx_rx = 0;\n-\tunsigned long rx_bytes = 0;\n \tint i;\n \tuint32_t free_thresh = fq->size >> 1;\n \tstruct rte_mbuf *mbufs[ETH_AF_XDP_RX_BATCH_SIZE];\n@@ -424,16 +408,13 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\trte_ring_enqueue(umem->buf_ring, (void *)addr);\n \t\trte_pktmbuf_pkt_len(mbufs[i]) = len;\n \t\trte_pktmbuf_data_len(mbufs[i]) = len;\n-\t\trx_bytes += len;\n+\t\trte_eth_count_mbuf(&rxq->stats, mbufs[i]);\n+\n \t\tbufs[i] = mbufs[i];\n \t}\n \n \txsk_ring_cons__release(rx, nb_pkts);\n \n-\t/* statistics */\n-\trxq->stats.rx_pkts += nb_pkts;\n-\trxq->stats.rx_bytes += rx_bytes;\n-\n \treturn nb_pkts;\n }\n #endif\n@@ -527,9 +508,8 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct pkt_tx_queue *txq = queue;\n \tstruct xsk_umem_info *umem = txq->umem;\n \tstruct rte_mbuf *mbuf;\n-\tunsigned long tx_bytes = 0;\n \tint i;\n-\tuint32_t idx_tx;\n+\tuint32_t idx_tx, pkt_len;\n \tuint16_t count = 0;\n \tstruct xdp_desc *desc;\n \tuint64_t addr, offset;\n@@ -541,6 +521,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \tfor (i = 0; i < nb_pkts; i++) {\n \t\tmbuf = bufs[i];\n+\t\tpkt_len = rte_pktmbuf_pkt_len(mbuf);\n \n \t\tif (mbuf->pool == umem->mb_pool) {\n \t\t\tif (!xsk_ring_prod__reserve(&txq->tx, 1, &idx_tx)) {\n@@ -589,17 +570,13 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tcount++;\n \t\t}\n \n-\t\ttx_bytes += mbuf->pkt_len;\n+\t\trte_eth_count_packet(&txq->stats, pkt_len);\n \t}\n \n out:\n \txsk_ring_prod__submit(&txq->tx, count);\n \tkick_tx(txq, cq);\n \n-\ttxq->stats.tx_pkts += count;\n-\ttxq->stats.tx_bytes += tx_bytes;\n-\ttxq->stats.tx_dropped += nb_pkts - count;\n-\n \treturn count;\n }\n #else\n@@ -610,7 +587,6 @@ af_xdp_tx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct xsk_umem_info *umem = txq->umem;\n \tstruct rte_mbuf *mbuf;\n \tvoid *addrs[ETH_AF_XDP_TX_BATCH_SIZE];\n-\tunsigned long tx_bytes = 0;\n \tint i;\n \tuint32_t idx_tx;\n \tstruct xsk_ring_cons *cq = &txq->pair->cq;\n@@ -640,7 +616,7 @@ af_xdp_tx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\tpkt = xsk_umem__get_data(umem->mz->addr,\n \t\t\t\t\t desc->addr);\n \t\trte_memcpy(pkt, rte_pktmbuf_mtod(mbuf, void *), desc->len);\n-\t\ttx_bytes += mbuf->pkt_len;\n+\t\trte_eth_count_mbuf(&txq->stats, mbuf);\n \t\trte_pktmbuf_free(mbuf);\n \t}\n \n@@ -648,9 +624,6 @@ af_xdp_tx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \tkick_tx(txq, cq);\n \n-\ttxq->stats.tx_pkts += nb_pkts;\n-\ttxq->stats.tx_bytes += tx_bytes;\n-\n \treturn nb_pkts;\n }\n \n@@ -847,39 +820,26 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n static int\n eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tstruct pmd_internals *internals = dev->data->dev_private;\n \tstruct pmd_process_private *process_private = dev->process_private;\n-\tstruct xdp_statistics xdp_stats;\n-\tstruct pkt_rx_queue *rxq;\n-\tstruct pkt_tx_queue *txq;\n-\tsocklen_t optlen;\n-\tint i, ret, fd;\n+\tunsigned int i;\n \n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\toptlen = sizeof(struct xdp_statistics);\n-\t\trxq = &internals->rx_queues[i];\n-\t\ttxq = rxq->pair;\n-\t\tstats->q_ipackets[i] = rxq->stats.rx_pkts;\n-\t\tstats->q_ibytes[i] = rxq->stats.rx_bytes;\n+\trte_eth_counters_stats_get(dev, offsetof(struct pkt_tx_queue, stats),\n+\t\t\t\t offsetof(struct pkt_rx_queue, stats), stats);\n \n-\t\tstats->q_opackets[i] = txq->stats.tx_pkts;\n-\t\tstats->q_obytes[i] = txq->stats.tx_bytes;\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct xdp_statistics xdp_stats;\n+\t\tsocklen_t optlen = sizeof(xdp_stats);\n+\t\tint fd;\n \n-\t\tstats->ipackets += stats->q_ipackets[i];\n-\t\tstats->ibytes += stats->q_ibytes[i];\n-\t\tstats->imissed += rxq->stats.rx_dropped;\n-\t\tstats->oerrors += txq->stats.tx_dropped;\n \t\tfd = process_private->rxq_xsk_fds[i];\n-\t\tret = fd >= 0 ? getsockopt(fd, SOL_XDP, XDP_STATISTICS,\n-\t\t\t\t\t &xdp_stats, &optlen) : -1;\n-\t\tif (ret != 0) {\n+\t\tif (fd < 0)\n+\t\t\tcontinue;\n+\t\tif (getsockopt(fd, SOL_XDP, XDP_STATISTICS,\n+\t\t\t &xdp_stats, &optlen) < 0) {\n \t\t\tAF_XDP_LOG(ERR, \"getsockopt() failed for XDP_STATISTICS.\\n\");\n \t\t\treturn -1;\n \t\t}\n \t\tstats->imissed += xdp_stats.rx_dropped;\n-\n-\t\tstats->opackets += stats->q_opackets[i];\n-\t\tstats->obytes += stats->q_obytes[i];\n \t}\n \n \treturn 0;\n@@ -888,17 +848,8 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n static int\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tstruct pmd_internals *internals = dev->data->dev_private;\n-\tint i;\n-\n-\tfor (i = 0; i < internals->queue_cnt; i++) {\n-\t\tmemset(&internals->rx_queues[i].stats, 0,\n-\t\t\t\t\tsizeof(struct rx_stats));\n-\t\tmemset(&internals->tx_queues[i].stats, 0,\n-\t\t\t\t\tsizeof(struct tx_stats));\n-\t}\n-\n-\treturn 0;\n+\treturn rte_eth_counters_reset(dev, offsetof(struct pkt_tx_queue, stats),\n+\t\t\t\t offsetof(struct pkt_rx_queue, stats));\n }\n \n #ifdef RTE_NET_AF_XDP_LIBBPF_XDP_ATTACH\n", "prefixes": [ "v7", "4/9" ] }