Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140175/?format=api
{ "id": 140175, "url": "http://patches.dpdk.org/api/patches/140175/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240517174044.90952-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517174044.90952-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517174044.90952-4-stephen@networkplumber.org", "date": "2024-05-17T17:35:10", "name": "[v7,3/9] net/af_packet: use generic SW stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e182ea27dc21db4e7e4c038c89634193c9455b69", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240517174044.90952-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 31946, "url": "http://patches.dpdk.org/api/series/31946/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31946", "date": "2024-05-17T17:35:07", "name": "Use weak atomic operations for SW PMD counters", "version": 7, "mbox": "http://patches.dpdk.org/series/31946/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/140175/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/140175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B31DB44052;\n\tFri, 17 May 2024 19:41:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B043140691;\n\tFri, 17 May 2024 19:40:53 +0200 (CEST)", "from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170])\n by mails.dpdk.org (Postfix) with ESMTP id 3DFD540649\n for <dev@dpdk.org>; Fri, 17 May 2024 19:40:50 +0200 (CEST)", "by mail-pl1-f170.google.com with SMTP id\n d9443c01a7336-1ee12baa01cso17609165ad.0\n for <dev@dpdk.org>; Fri, 17 May 2024 10:40:50 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0bf31032sm158830485ad.131.2024.05.17.10.40.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 May 2024 10:40:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715967649;\n x=1716572449; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SUE9fO9/yU42C4wqedNCLbGs+mpPzKdD4hF5j4IP+8c=;\n b=HdyyJMdg3adzvwMelmEAZuyboS9FoKNd3rWdbvnN71GjxltQlKZMnzw1BGXbjrbSSf\n VzBU6OO3giRhk/JCaskFq63fRD3tQR06tvX17WMmAip8g97XefUUMOqgrnNbW+RjhUbi\n JFe2xl+nbERKHlsoOhP2aP/waZbByo42CeLGi4qblkPkPorNrM1WUaUINcFejKw8fbrf\n QBztNaWEAApOT2CxgprY3AJ1q1sA1QYKd0QXBdz0m/r/C5UXmFVrl5+fb62a+XTcaHMY\n x9rR5/y3wmJnfZPFand09WH6gLxEx0XXROjlT4SGYOGv6tVd9oPGTiWykYNV/OJAYrCw\n iYvQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715967649; x=1716572449;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=SUE9fO9/yU42C4wqedNCLbGs+mpPzKdD4hF5j4IP+8c=;\n b=uHyOmgJXDAlWRpDhsbpK1SedVvgOaLbgnTb0XOWxxwxXUOC/qSlwHWuwqIMGoX4FGZ\n YW8Ho5obtszMEeMUC4iw2vv2YXiDLIdEcPEhCGMD5VdeJrZlcPeBFEFh2AscdV0/mCOc\n iOwE41U88CIkdbnUbg0fAR2XZuFAHDcJx+yWFmL+oCZocCA1Ib63PXK4b3/4C1pqByMz\n f9j4czQNG0GVCQQ2disKlfAjMmz5JUIv4GZJigHA85tf2fAuWZguXxe04BEkwNuFME94\n oPFOJxackDcu20gayzHcQoqpuGr2cxjtDMu74idy37XS1GAOcVn0NzzUnfpIp45qZxor\n E55g==", "X-Gm-Message-State": "AOJu0Yy2OzAmpHWD6K1F5Fcm8J53gpvUAE273z626+1/IxswP7aq+p9f\n q9ZzMm543aTPHj79rbNI0pD+YYDR8rqECC7y4oCXMiIuSlh5oCCJaDjmeFcxuxz9AqfP8RdC0KT\n QfcA=", "X-Google-Smtp-Source": "\n AGHT+IEXDkfzAQ7VJCJ871jp7ftWuPqfNnHQq/MQb/1f05w080jE7xI8v9yeFFuMb3KG4gEktm6KMQ==", "X-Received": "by 2002:a17:902:d4c9:b0:1f2:ec63:6018 with SMTP id\n d9443c01a7336-1f2ec6361a2mr1113105ad.51.1715967649377;\n Fri, 17 May 2024 10:40:49 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n \"John W. Linville\" <linville@tuxdriver.com>", "Subject": "[PATCH v7 3/9] net/af_packet: use generic SW stats", "Date": "Fri, 17 May 2024 10:35:10 -0700", "Message-ID": "<20240517174044.90952-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517174044.90952-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517174044.90952-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use the new generic SW stats.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 82 ++++-------------------\n 1 file changed, 14 insertions(+), 68 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 397a32db58..89b737e7dc 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -10,6 +10,7 @@\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n #include <ethdev_vdev.h>\n+#include <ethdev_swstats.h>\n #include <rte_malloc.h>\n #include <rte_kvargs.h>\n #include <bus_vdev_driver.h>\n@@ -29,6 +30,7 @@\n #include <unistd.h>\n #include <poll.h>\n \n+\n #define ETH_AF_PACKET_IFACE_ARG\t\t\"iface\"\n #define ETH_AF_PACKET_NUM_Q_ARG\t\t\"qpairs\"\n #define ETH_AF_PACKET_BLOCKSIZE_ARG\t\"blocksz\"\n@@ -51,8 +53,7 @@ struct pkt_rx_queue {\n \tuint16_t in_port;\n \tuint8_t vlan_strip;\n \n-\tvolatile unsigned long rx_pkts;\n-\tvolatile unsigned long rx_bytes;\n+\tstruct rte_eth_counters stats;\n };\n \n struct pkt_tx_queue {\n@@ -64,11 +65,10 @@ struct pkt_tx_queue {\n \tunsigned int framecount;\n \tunsigned int framenum;\n \n-\tvolatile unsigned long tx_pkts;\n-\tvolatile unsigned long err_pkts;\n-\tvolatile unsigned long tx_bytes;\n+\tstruct rte_eth_counters stats;\n };\n \n+\n struct pmd_internals {\n \tunsigned nb_queues;\n \n@@ -118,8 +118,6 @@ eth_af_packet_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct rte_mbuf *mbuf;\n \tuint8_t *pbuf;\n \tstruct pkt_rx_queue *pkt_q = queue;\n-\tuint16_t num_rx = 0;\n-\tunsigned long num_rx_bytes = 0;\n \tunsigned int framecount, framenum;\n \n \tif (unlikely(nb_pkts == 0))\n@@ -164,13 +162,11 @@ eth_af_packet_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \t\t/* account for the receive frame */\n \t\tbufs[i] = mbuf;\n-\t\tnum_rx++;\n-\t\tnum_rx_bytes += mbuf->pkt_len;\n+\t\trte_eth_count_mbuf(&pkt_q->stats, mbuf);\n \t}\n \tpkt_q->framenum = framenum;\n-\tpkt_q->rx_pkts += num_rx;\n-\tpkt_q->rx_bytes += num_rx_bytes;\n-\treturn num_rx;\n+\n+\treturn i;\n }\n \n /*\n@@ -205,8 +201,6 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tunsigned int framecount, framenum;\n \tstruct pollfd pfd;\n \tstruct pkt_tx_queue *pkt_q = queue;\n-\tuint16_t num_tx = 0;\n-\tunsigned long num_tx_bytes = 0;\n \tint i;\n \n \tif (unlikely(nb_pkts == 0))\n@@ -285,8 +279,7 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tframenum = 0;\n \t\tppd = (struct tpacket2_hdr *) pkt_q->rd[framenum].iov_base;\n \n-\t\tnum_tx++;\n-\t\tnum_tx_bytes += mbuf->pkt_len;\n+\t\trte_eth_count_mbuf(&pkt_q->stats, mbuf);\n \t\trte_pktmbuf_free(mbuf);\n \t}\n \n@@ -298,15 +291,9 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t * packets will be considered successful even though only some\n \t\t * are sent.\n \t\t */\n-\n-\t\tnum_tx = 0;\n-\t\tnum_tx_bytes = 0;\n \t}\n \n \tpkt_q->framenum = framenum;\n-\tpkt_q->tx_pkts += num_tx;\n-\tpkt_q->err_pkts += i - num_tx;\n-\tpkt_q->tx_bytes += num_tx_bytes;\n \treturn i;\n }\n \n@@ -386,58 +373,17 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n }\n \n static int\n-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)\n+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tunsigned i, imax;\n-\tunsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;\n-\tunsigned long rx_bytes_total = 0, tx_bytes_total = 0;\n-\tconst struct pmd_internals *internal = dev->data->dev_private;\n-\n-\timax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?\n-\t internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\tfor (i = 0; i < imax; i++) {\n-\t\tigb_stats->q_ipackets[i] = internal->rx_queue[i].rx_pkts;\n-\t\tigb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;\n-\t\trx_total += igb_stats->q_ipackets[i];\n-\t\trx_bytes_total += igb_stats->q_ibytes[i];\n-\t}\n-\n-\timax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?\n-\t internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\tfor (i = 0; i < imax; i++) {\n-\t\tigb_stats->q_opackets[i] = internal->tx_queue[i].tx_pkts;\n-\t\tigb_stats->q_obytes[i] = internal->tx_queue[i].tx_bytes;\n-\t\ttx_total += igb_stats->q_opackets[i];\n-\t\ttx_err_total += internal->tx_queue[i].err_pkts;\n-\t\ttx_bytes_total += igb_stats->q_obytes[i];\n-\t}\n-\n-\tigb_stats->ipackets = rx_total;\n-\tigb_stats->ibytes = rx_bytes_total;\n-\tigb_stats->opackets = tx_total;\n-\tigb_stats->oerrors = tx_err_total;\n-\tigb_stats->obytes = tx_bytes_total;\n-\treturn 0;\n+\treturn rte_eth_counters_stats_get(dev, offsetof(struct pkt_tx_queue, stats),\n+\t\t\t\t\t offsetof(struct pkt_rx_queue, stats), stats);\n }\n \n static int\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tunsigned i;\n-\tstruct pmd_internals *internal = dev->data->dev_private;\n-\n-\tfor (i = 0; i < internal->nb_queues; i++) {\n-\t\tinternal->rx_queue[i].rx_pkts = 0;\n-\t\tinternal->rx_queue[i].rx_bytes = 0;\n-\t}\n-\n-\tfor (i = 0; i < internal->nb_queues; i++) {\n-\t\tinternal->tx_queue[i].tx_pkts = 0;\n-\t\tinternal->tx_queue[i].err_pkts = 0;\n-\t\tinternal->tx_queue[i].tx_bytes = 0;\n-\t}\n-\n-\treturn 0;\n+\treturn rte_eth_counters_reset(dev, offsetof(struct pkt_tx_queue, stats),\n+\t\t\t\t offsetof(struct pkt_rx_queue, stats));\n }\n \n static int\n", "prefixes": [ "v7", "3/9" ] }