Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 139946,
    "url": "http://patches.dpdk.org/api/patches/139946/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1715019531-22796-9-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1715019531-22796-9-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1715019531-22796-9-git-send-email-roretzla@linux.microsoft.com",
    "date": "2024-05-06T18:18:40",
    "name": "[v3,08/19] gro: remove use of VLAs for Windows built code",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "159db1e9ebf034fde471182cc0f49e2452364707",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1715019531-22796-9-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 31887,
            "url": "http://patches.dpdk.org/api/series/31887/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31887",
            "date": "2024-05-06T18:18:33",
            "name": "remove use of VLAs for Windows",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/31887/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/139946/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/139946/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 02CDB43F5C;\n\tMon,  6 May 2024 20:19:30 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BCB3B40E0F;\n\tMon,  6 May 2024 20:19:03 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 715C040649\n for <dev@dpdk.org>; Mon,  6 May 2024 20:18:54 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 38DE420B2C8F; Mon,  6 May 2024 11:18:52 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 38DE420B2C8F",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1715019533;\n bh=R/d0mpnsT5jq7tJ3HU3g5YrS5+sT06Ox8KheSbh9d+0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ZD5uleppkydPNoZtPFxVc+vWBjAZePd1flqq+QdSZLKoDZBAjdAJM+qWm4mAUWB7H\n WJwzT/2RFmvXE84U/PUWsnHw0j17kUJmoREtHa3A5x/udfy9o959L48pVuqh7AODqY\n qUBkqW7+7swDE5xOUgOKPtr38Zh3izWUoFwm21/U=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>",
        "Subject": "[PATCH v3 08/19] gro: remove use of VLAs for Windows built code",
        "Date": "Mon,  6 May 2024 11:18:40 -0700",
        "Message-Id": "<1715019531-22796-9-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1715019531-22796-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1715019531-22796-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "MSVC does not support VLAs, replace VLAs with standard C arrays\nor alloca(). alloca() is available for all toolchain/platform\ncombinations officially supported by DPDK.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/gro/rte_gro.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c\nindex d824eeb..0f9e85c 100644\n--- a/lib/gro/rte_gro.c\n+++ b/lib/gro/rte_gro.c\n@@ -179,7 +179,7 @@ struct gro_ctx {\n \tstruct gro_vxlan_udp4_item vxlan_udp_items[RTE_GRO_MAX_BURST_ITEM_NUM]\n \t\t\t= {{{0}} };\n \n-\tstruct rte_mbuf *unprocess_pkts[nb_pkts];\n+\tstruct rte_mbuf **unprocess_pkts = alloca(sizeof(struct rte_mbuf *) * nb_pkts);\n \tuint32_t item_num;\n \tint32_t ret;\n \tuint16_t i, unprocess_num = 0, nb_after_gro = nb_pkts;\n@@ -360,7 +360,7 @@ struct gro_ctx {\n \t\tuint16_t nb_pkts,\n \t\tvoid *ctx)\n {\n-\tstruct rte_mbuf *unprocess_pkts[nb_pkts];\n+\tstruct rte_mbuf **unprocess_pkts = alloca(sizeof(struct rte_mbuf *) * nb_pkts);\n \tstruct gro_ctx *gro_ctx = ctx;\n \tvoid *tcp_tbl, *udp_tbl, *vxlan_tcp_tbl, *vxlan_udp_tbl, *tcp6_tbl;\n \tuint64_t current_time;\n",
    "prefixes": [
        "v3",
        "08/19"
    ]
}