Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139823/?format=api
{ "id": 139823, "url": "http://patches.dpdk.org/api/patches/139823/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240502213618.11391-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240502213618.11391-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240502213618.11391-11-stephen@networkplumber.org", "date": "2024-05-02T21:31:46", "name": "[v12,10/12] net/tap: remove extraneous newlines", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "53360c285c03a8ce770e11576383d3e03791bd9d", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240502213618.11391-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 31871, "url": "http://patches.dpdk.org/api/series/31871/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31871", "date": "2024-05-02T21:31:36", "name": "net/tap: RSS and other fixes", "version": 12, "mbox": "http://patches.dpdk.org/series/31871/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139823/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D870943F6C;\n\tThu, 2 May 2024 23:37:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 53C5D40A6C;\n\tThu, 2 May 2024 23:36:46 +0200 (CEST)", "from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n by mails.dpdk.org (Postfix) with ESMTP id B2F8340633\n for <dev@dpdk.org>; Thu, 2 May 2024 23:36:36 +0200 (CEST)", "by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-6ed01c63657so8113528b3a.2\n for <dev@dpdk.org>; Thu, 02 May 2024 14:36:36 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n f14-20020a056a001ace00b006f3eee787d5sm1804829pfv.18.2024.05.02.14.36.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 May 2024 14:36:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714685796;\n x=1715290596; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pBUTB7LGR7a993dAW8ThIQSZmRdd6JCQSUmUkmSqdo8=;\n b=PlrMuUN+Xwvq9jrpOSU+dUUElp5ck945vIPbOq3TUWTUvcku0BLJxKvLFyK+RkvZcu\n VDQhL/lKr/kHElpZyKmixTzj4Px3RSKgiijpG/rZ5mzADU1VegK+R2Avwd3Q1LyDfg62\n WliYJkWs+IsEOtqnxJrIKfBbbUdKF2guEgedXnCW+qVLpZmk/WB8rYfYRNKnlnz0emFQ\n FmHUuuRWSW8mpyuuY/iuVegHcip0N9CmMe4IcqOHCTBVNFQ7h0Uo0GJSFb4YEAx3JSLb\n rpnULyL+p43VZFQT885C52SNvhsMdUmoZj6qzHIYzbwrwV/WWofPsB1taYOTzirGrX7B\n ZvBQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714685796; x=1715290596;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=pBUTB7LGR7a993dAW8ThIQSZmRdd6JCQSUmUkmSqdo8=;\n b=O1qfcTdBnCDX60fieyrldRxLBNF8YqEhUnaQmJjVltxeyLPH3LHAjKH0xW6P/Cjj1c\n LBT946ySAHYuXJ/4cAHZgLdSt/qp3FcZex6TwH3M0Tw7TnwTj8rYmgKirVaQ6PPO3P4P\n nVLvmngRUqHlInNHhm7L6XTN2hneVEFXGuJ+sgdrsfQQd1+1fgeCYKBrSQzwOzEjCRrK\n 9VU5Wpog2OAptoM8MvRlZRuw6xVQ2isUq4zKw+UnvXqe/AyRcIELiGgtI7VhBSyb5sjN\n l5QZ1znFfIslsADEQBQgMdp5AMd/POy7b2yxOYHolc+PFMk9XJBUJN2JLfNIj4IlamOI\n JDcw==", "X-Gm-Message-State": "AOJu0YwB18FcmseM5OqQibZOkik05sseiHBT19We9XwSaAbZ/6WhxePR\n iQUUsu6AOVk0W8kYO6rmOJiVGe/6iOsVQG5P+kBbh4BVK20+6pB9VdSCk0berWMTexKCIPwE4N4\n GYZfscw==", "X-Google-Smtp-Source": "\n AGHT+IHfpSafloeZT8mvhK4VwTumnxrM6EYBpYZprvfrIpV/Hv1UqBG9HhsaklYXDWrOGN4HLEM8BQ==", "X-Received": "by 2002:a05:6a00:17a7:b0:6ea:bb66:9448 with SMTP id\n s39-20020a056a0017a700b006eabb669448mr1067598pfg.22.1714685795834;\n Thu, 02 May 2024 14:36:35 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v12 10/12] net/tap: remove extraneous newlines", "Date": "Thu, 2 May 2024 14:31:46 -0700", "Message-ID": "<20240502213618.11391-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240502213618.11391-1-stephen@networkplumber.org>", "References": "<20240130034925.44869-1-stephen@networkplumber.org>\n <20240502213618.11391-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some log messages contained extra newlines.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 3614aaf1dc..2484a82ccb 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -235,9 +235,8 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent)\n \n \tflags = fcntl(fd, F_GETFL);\n \tif (flags == -1) {\n-\t\tTAP_LOG(WARNING,\n-\t\t\t\"Unable to get %s current flags\\n\",\n-\t\t\tifr.ifr_name);\n+\t\tTAP_LOG(WARNING, \"Unable to get %s current flags: %s\",\n+\t\t\tifr.ifr_name, strerror(errno));\n \t\tgoto error;\n \t}\n \n@@ -279,7 +278,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent)\n \n \t\tif (sigaction(signo, &sa, NULL) == -1) {\n \t\t\tTAP_LOG(WARNING,\n-\t\t\t\t\"Unable to set rt-signal %d handler\\n\", signo);\n+\t\t\t\t\"Unable to set rt-signal %d handler\", signo);\n \t\t\tgoto error;\n \t\t}\n \n@@ -290,11 +289,11 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent)\n \t}\n \n \tif (signo == SIGRTMAX) {\n-\t\tTAP_LOG(WARNING, \"All rt-signals are in use\\n\");\n+\t\tTAP_LOG(WARNING, \"All rt-signals are in use\");\n \n \t\t/* Disable trigger globally in case of error */\n \t\ttap_trigger = 0;\n-\t\tTAP_LOG(NOTICE, \"No Rx trigger signal available\\n\");\n+\t\tTAP_LOG(NOTICE, \"No Rx trigger signal available\");\n \t} else {\n \t\t/* Enable signal on file descriptor */\n \t\tif (fcntl(fd, F_SETSIG, signo) < 0) {\n@@ -920,7 +919,7 @@ tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void\n \t}\n \n \tprocess_private = dev->process_private;\n-\tTAP_LOG(DEBUG, \"tap_attach q:%d\\n\", request_param->q_count);\n+\tTAP_LOG(DEBUG, \"tap_attach q:%d\", request_param->q_count);\n \n \tfor (int q = 0; q < request_param->q_count; q++)\n \t\tprocess_private->fds[q] = request->fds[q];\n@@ -1463,7 +1462,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev)\n \t\tif (ret < 0 || ret >= (int)sizeof(pool_name)) {\n \t\t\tTAP_LOG(ERR,\n \t\t\t\t\"%s: failed to create mbuf pool name for device %s,\"\n-\t\t\t\t\"device name too long or output error, ret: %d\\n\",\n+\t\t\t\t\"device name too long or output error, ret: %d\",\n \t\t\t\tpmd->name, dev->device->name, ret);\n \t\t\treturn -ENAMETOOLONG;\n \t\t}\n@@ -1473,7 +1472,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev)\n \t\t\tSOCKET_ID_ANY);\n \t\tif (!pmd->gso_ctx_mp) {\n \t\t\tTAP_LOG(ERR,\n-\t\t\t\t\"%s: failed to create mbuf pool for device %s\\n\",\n+\t\t\t\t\"%s: failed to create mbuf pool for device %s\",\n \t\t\t\tpmd->name, dev->device->name);\n \t\t\treturn -1;\n \t\t}\n", "prefixes": [ "v12", "10/12" ] }