Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139811/?format=api
{ "id": 139811, "url": "http://patches.dpdk.org/api/patches/139811/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240502204548.236729-4-hernan.vargas@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240502204548.236729-4-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240502204548.236729-4-hernan.vargas@intel.com", "date": "2024-05-02T20:45:46", "name": "[v2,3/5] baseband/acc: remove ACC100 HARQ pruning", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a2172f2a3005c8ef1eeacebe5544906021ab0617", "submitter": { "id": 2659, "url": "http://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240502204548.236729-4-hernan.vargas@intel.com/mbox/", "series": [ { "id": 31870, "url": "http://patches.dpdk.org/api/series/31870/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31870", "date": "2024-05-02T20:45:43", "name": "ACC100 improvements and clean up", "version": 2, "mbox": "http://patches.dpdk.org/series/31870/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139811/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9CAF843F6C;\n\tThu, 2 May 2024 22:49:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 46B2D402D4;\n\tThu, 2 May 2024 22:49:25 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by mails.dpdk.org (Postfix) with ESMTP id 0A5A1402B2\n for <dev@dpdk.org>; Thu, 2 May 2024 22:49:19 +0200 (CEST)", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 May 2024 13:49:19 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orviesa008.jf.intel.com with ESMTP; 02 May 2024 13:49:19 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1714682960; x=1746218960;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=yXg4go4HUlhwOYOtp0gDsJ0aFhTZEZSSeLPRs315ASQ=;\n b=jfsx14YOU5bdZ/M/lwhO2p1ZbGwmzGMR3EPjFfLlimNvDiDkwaX1CHXE\n EZFqojeeSQQPttdEDyYDgg7CWvehEakI9Jvu93oehplXNNFr8xQK2ob0Z\n zXDolOXVfNM6u1UN+9/gM5XbGOQ3QCd8s8SQVDIrS9hFIPd6tVLWSTHxK\n fzLqORZnrJXY8CjNO9EbxumndodygXSOYcnbroc88h5dCjZ8VUCKUbtMa\n 5/tdJ1QUKDWax4qPTtBoSEVwEfxGK2FkPivIj/OeAwxDnjljWbyzRBiUI\n i4C/uNPnrf41BfpzvxCBt8lE4oPjDvP4qQPqGvkXCMutK2Q8y525rfh/B A==;", "X-CSE-ConnectionGUID": [ "O+EipZmOQ4CfJDyDDYI0MA==", "cTs+NzytTVC9t1ELYbvd6g==" ], "X-CSE-MsgGUID": [ "jWD9ICGkR/GgFObw9Lo89w==", "jSDTI76OR9iaQouE44axRg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11062\"; a=\"21032753\"", "E=Sophos;i=\"6.07,247,1708416000\"; d=\"scan'208\";a=\"21032753\"", "E=Sophos;i=\"6.07,247,1708416000\"; d=\"scan'208\";a=\"27838128\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>", "Subject": "[PATCH v2 3/5] baseband/acc: remove ACC100 HARQ pruning", "Date": "Thu, 2 May 2024 13:45:46 -0700", "Message-Id": "<20240502204548.236729-4-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20240502204548.236729-1-hernan.vargas@intel.com>", "References": "<20240502204548.236729-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "HARQ pruning is not an ACC100 feature. Removing in effect dead code.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 33 +++++----------------------\n 1 file changed, 6 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex d6b0b9400c82..f37722879c20 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -1152,7 +1152,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \tuint16_t harq_out_length, harq_in_length, ncb_p, k0_p, parity_offset;\n \tuint32_t harq_index;\n \tuint32_t l;\n-\tbool harq_prun = false;\n \tuint32_t max_hc_in;\n \n \tfcw->qm = op->ldpc_dec.q_m;\n@@ -1199,13 +1198,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \tfcw->llr_pack_mode = check_bit(op->ldpc_dec.op_flags,\n \t\t\tRTE_BBDEV_LDPC_LLR_COMPRESSION);\n \tharq_index = hq_index(op->ldpc_dec.harq_combined_output.offset);\n-#ifdef ACC100_EXT_MEM\n-\t/* Limit cases when HARQ pruning is valid */\n-\tharq_prun = ((op->ldpc_dec.harq_combined_output.offset %\n-\t\t\tACC_HARQ_OFFSET) == 0) &&\n-\t\t\t(op->ldpc_dec.harq_combined_output.offset <= UINT16_MAX\n-\t\t\t* ACC_HARQ_OFFSET);\n-#endif\n \tif (fcw->hcin_en > 0) {\n \t\tharq_in_length = op->ldpc_dec.harq_combined_input.length;\n \t\tif (fcw->hcin_decomp_mode > 0)\n@@ -1221,16 +1213,9 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \t\tif (fcw->hcin_decomp_mode > 0)\n \t\t\tharq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC100_HARQ_ALIGN_COMP);\n \n-\t\tif ((harq_layout[harq_index].offset > 0) && harq_prun) {\n-\t\t\trte_bbdev_log_debug(\"HARQ IN offset unexpected for now\\n\");\n-\t\t\tfcw->hcin_size0 = harq_layout[harq_index].size0;\n-\t\t\tfcw->hcin_offset = harq_layout[harq_index].offset;\n-\t\t\tfcw->hcin_size1 = harq_in_length - harq_layout[harq_index].offset;\n-\t\t} else {\n-\t\t\tfcw->hcin_size0 = harq_in_length;\n-\t\t\tfcw->hcin_offset = 0;\n-\t\t\tfcw->hcin_size1 = 0;\n-\t\t}\n+\t\tfcw->hcin_size0 = harq_in_length;\n+\t\tfcw->hcin_offset = 0;\n+\t\tfcw->hcin_size1 = 0;\n \t} else {\n \t\tfcw->hcin_size0 = 0;\n \t\tfcw->hcin_offset = 0;\n@@ -1296,15 +1281,9 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \t\tif (fcw->hcout_comp_mode > 0)\n \t\t\tharq_out_length = RTE_ALIGN_FLOOR(harq_out_length, ACC100_HARQ_ALIGN_COMP);\n \n-\t\tif ((k0_p > fcw->hcin_size0 + ACC_HARQ_OFFSET_THRESHOLD) && harq_prun) {\n-\t\t\tfcw->hcout_size0 = (uint16_t) fcw->hcin_size0;\n-\t\t\tfcw->hcout_offset = k0_p & 0xFFC0;\n-\t\t\tfcw->hcout_size1 = harq_out_length - fcw->hcout_offset;\n-\t\t} else {\n-\t\t\tfcw->hcout_size0 = harq_out_length;\n-\t\t\tfcw->hcout_size1 = 0;\n-\t\t\tfcw->hcout_offset = 0;\n-\t\t}\n+\t\tfcw->hcout_size0 = harq_out_length;\n+\t\tfcw->hcout_size1 = 0;\n+\t\tfcw->hcout_offset = 0;\n \n \t\tif (fcw->hcout_size0 == 0) {\n \t\t\trte_bbdev_log(ERR, \" Invalid FCW : HCout %d\",\n", "prefixes": [ "v2", "3/5" ] }