Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139717/?format=api
{ "id": 139717, "url": "http://patches.dpdk.org/api/patches/139717/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240429100059.1316414-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240429100059.1316414-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240429100059.1316414-1-david.marchand@redhat.com", "date": "2024-04-29T10:00:59", "name": "bus/pci: fix build with musl 1.2.4 / Alpine 3.19", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5194837026576073efc9dcd5df6b77a05d14b736", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240429100059.1316414-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 31837, "url": "http://patches.dpdk.org/api/series/31837/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31837", "date": "2024-04-29T10:00:59", "name": "bus/pci: fix build with musl 1.2.4 / Alpine 3.19", "version": 1, "mbox": "http://patches.dpdk.org/series/31837/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139717/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C71E443F49;\n\tMon, 29 Apr 2024 12:01:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B5E76402BA;\n\tMon, 29 Apr 2024 12:01:09 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id EF4EC4025C\n for <dev@dpdk.org>; Mon, 29 Apr 2024 12:01:07 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-389-r1Np3o6eMx2YqpNGnmqEUg-1; Mon, 29 Apr 2024 06:01:03 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E160980B3DD;\n Mon, 29 Apr 2024 10:01:02 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.248])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8C9642166B31;\n Mon, 29 Apr 2024 10:01:01 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1714384867;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=0d0GK3P+Skmu6vOEkNUR/jfrZVBZl7d6Kru3agGRvZA=;\n b=UGu9OJEzr3cMlNLkE14tUCpXrpvzAjdryenKgZH9bIvj8EWIexslbp5Hwrhzk0vgWHnMx+\n PRZYpDHMI4LYNgFHXeDQKa8fUC+XcvHpFQ3kgzg48Kb6/kPcrNQRzHqMSJL0DBXDKo1JFF\n VaBn2/1I1I9t48NcTTBXJABzUfwpyXU=", "X-MC-Unique": "r1Np3o6eMx2YqpNGnmqEUg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "ahassick@iol.unh.edu, stable@dpdk.org,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Nipun Gupta <nipun.gupta@amd.com>", "Subject": "[PATCH] bus/pci: fix build with musl 1.2.4 / Alpine 3.19", "Date": "Mon, 29 Apr 2024 12:00:59 +0200", "Message-ID": "<20240429100059.1316414-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.6", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Following an upgrade of musl, pread64/pwrite64 wrappers are not provided\nanymore. Switch to POSIX pread/pwrite.\n\nBugzilla ID: 1422\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/bus/pci/linux/pci_vfio.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c\nindex 87c16e6603..05b03a9667 100644\n--- a/drivers/bus/pci/linux/pci_vfio.c\n+++ b/drivers/bus/pci/linux/pci_vfio.c\n@@ -80,7 +80,7 @@ pci_vfio_read_config(const struct rte_pci_device *dev,\n \tif ((uint64_t)len + offs > size)\n \t\treturn -1;\n \n-\treturn pread64(fd, buf, len, offset + offs);\n+\treturn pread(fd, buf, len, offset + offs);\n }\n \n int\n@@ -101,7 +101,7 @@ pci_vfio_write_config(const struct rte_pci_device *dev,\n \tif ((uint64_t)len + offs > size)\n \t\treturn -1;\n \n-\treturn pwrite64(fd, buf, len, offset + offs);\n+\treturn pwrite(fd, buf, len, offset + offs);\n }\n \n /* get PCI BAR number where MSI-X interrupts are */\n@@ -155,7 +155,7 @@ pci_vfio_enable_bus_memory(struct rte_pci_device *dev, int dev_fd)\n \t\treturn -1;\n \t}\n \n-\tret = pread64(dev_fd, &cmd, sizeof(cmd), offset + RTE_PCI_COMMAND);\n+\tret = pread(dev_fd, &cmd, sizeof(cmd), offset + RTE_PCI_COMMAND);\n \n \tif (ret != sizeof(cmd)) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot read command from PCI config space!\\n\");\n@@ -166,7 +166,7 @@ pci_vfio_enable_bus_memory(struct rte_pci_device *dev, int dev_fd)\n \t\treturn 0;\n \n \tcmd |= RTE_PCI_COMMAND_MEMORY;\n-\tret = pwrite64(dev_fd, &cmd, sizeof(cmd), offset + RTE_PCI_COMMAND);\n+\tret = pwrite(dev_fd, &cmd, sizeof(cmd), offset + RTE_PCI_COMMAND);\n \n \tif (ret != sizeof(cmd)) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot write command to PCI config space!\\n\");\n@@ -425,7 +425,7 @@ pci_vfio_is_ioport_bar(const struct rte_pci_device *dev, int vfio_dev_fd,\n \t\treturn -1;\n \t}\n \n-\tret = pread64(vfio_dev_fd, &ioport_bar, sizeof(ioport_bar),\n+\tret = pread(vfio_dev_fd, &ioport_bar, sizeof(ioport_bar),\n \t\t\t offset + RTE_PCI_BASE_ADDRESS_0 + bar_index * 4);\n \tif (ret != sizeof(ioport_bar)) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot read command (%x) from config space!\\n\",\n@@ -1276,7 +1276,7 @@ pci_vfio_ioport_read(struct rte_pci_ioport *p,\n \tif (vfio_dev_fd < 0)\n \t\treturn;\n \n-\tif (pread64(vfio_dev_fd, data,\n+\tif (pread(vfio_dev_fd, data,\n \t\t len, p->base + offset) <= 0)\n \t\tRTE_LOG(ERR, EAL,\n \t\t\t\"Can't read from PCI bar (%\" PRIu64 \") : offset (%x)\\n\",\n@@ -1293,7 +1293,7 @@ pci_vfio_ioport_write(struct rte_pci_ioport *p,\n \tif (vfio_dev_fd < 0)\n \t\treturn;\n \n-\tif (pwrite64(vfio_dev_fd, data,\n+\tif (pwrite(vfio_dev_fd, data,\n \t\t len, p->base + offset) <= 0)\n \t\tRTE_LOG(ERR, EAL,\n \t\t\t\"Can't write to PCI bar (%\" PRIu64 \") : offset (%x)\\n\",\n@@ -1324,7 +1324,7 @@ pci_vfio_mmio_read(const struct rte_pci_device *dev, int bar,\n \tif ((uint64_t)len + offs > size)\n \t\treturn -1;\n \n-\treturn pread64(fd, buf, len, offset + offs);\n+\treturn pread(fd, buf, len, offset + offs);\n }\n \n int\n@@ -1344,7 +1344,7 @@ pci_vfio_mmio_write(const struct rte_pci_device *dev, int bar,\n \tif ((uint64_t)len + offs > size)\n \t\treturn -1;\n \n-\treturn pwrite64(fd, buf, len, offset + offs);\n+\treturn pwrite(fd, buf, len, offset + offs);\n }\n \n int\n", "prefixes": [] }