Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139516/?format=api
{ "id": 139516, "url": "http://patches.dpdk.org/api/patches/139516/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240419031226.1191069-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419031226.1191069-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419031226.1191069-2-chaoyong.he@corigine.com", "date": "2024-04-19T03:12:19", "name": "[1/8] net/nfp: fix resource leak of secondary process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "70c220d175267c6dc19b406f48376491b19a9afc", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240419031226.1191069-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31786, "url": "http://patches.dpdk.org/api/series/31786/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31786", "date": "2024-04-19T03:12:18", "name": "refactor logic to support secondary process", "version": 1, "mbox": "http://patches.dpdk.org/series/31786/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139516/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DB4243EA9;\n\tFri, 19 Apr 2024 05:13:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2F239402D8;\n\tFri, 19 Apr 2024 05:12:55 +0200 (CEST)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam02on2114.outbound.protection.outlook.com [40.107.212.114])\n by mails.dpdk.org (Postfix) with ESMTP id 5EF484027D;\n Fri, 19 Apr 2024 05:12:52 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by IA2PR13MB6587.namprd13.prod.outlook.com (2603:10b6:208:4ab::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.43; Fri, 19 Apr\n 2024 03:12:50 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7472.042; Fri, 19 Apr 2024\n 03:12:50 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=BIR/TXsM7kFeZoNQfpRQ+UomcJdpQMbo3qtYNxbQXRnskpld8bbZSBXAJrEeA/gqSXi1FdLb7IsuYW07ReL6XfmRlLCvY6zZKBEdsqVqXsh+JKL98FmD1ofkT+jzB3ywQmW6lWhcNNUvSXJGT5FIJ/yxnWlqwuSGIwY46TyB4I+0yGXINN/LiejXJfz8ZQon+ieWJEBuL60erbG11IH/djJfw5hERhm5bL1QSlSZDKrkZz55YxjgUr9eHagNWXwTgXtV55MK6so0Br54qgI6+8O/ts9ion1Lw1P8BQoJn3m97GM1DaiMCIPc+zyW/2XVfpcZnYdDEmwh++SNPtrz6A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=xezgCZBF0qLHcaebuMnGFAdPaFEa6gYY0ZnSvkuua/k=;\n b=RQIWMnfk+VEPFaUi5NgCfczcDtVacU1ub677/vl2QyduqQ4RvXJEFpqR9BLITisM+ObUHQ5/iB7DjOYzAE9UURVFeANziTz12Y2H34jo/9aTub/gZLli8v57t9Vf2ksdTh3iUrGyV/YlgCViF1otuxuSBJBm0qNuwp3H8KbfIcCXgsnnKeGDwgjBpRXTO+Eb3xPADH1O9ItIYJWsu4lZVOFzoL8buxa874fd2fLn62Hb7NK73zjC8pitJuxpuTCoTnMmvhOsBwTVme+DrrzF7O5hhE1PgXjCU27zkvEkfW3SjSJfZxFmKq02qOzC45P1aRr7aSMMjrqbmao4a2BQcw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xezgCZBF0qLHcaebuMnGFAdPaFEa6gYY0ZnSvkuua/k=;\n b=Z1RBTPJ2tzuUI+OLYCatKeEld5Xyqy5FP1y9OfrMuYtWb0c16UNsUlmlf20sfA5jn3HpWs8Wei4KPgfHT0wV1zk/ye5xEJqzk0MdLKZJJzXiEymTaGfeDx75AQdyUfT0uOUNIp0y9uWcDxQkU5V2OYVK7c7bsPBKCuV05kW1yu8=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n stable@dpdk.org, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 1/8] net/nfp: fix resource leak of secondary process", "Date": "Fri, 19 Apr 2024 11:12:19 +0800", "Message-Id": "<20240419031226.1191069-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240419031226.1191069-1-chaoyong.he@corigine.com>", "References": "<20240419031226.1191069-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI2PR01CA0044.apcprd01.prod.exchangelabs.com\n (2603:1096:4:193::8) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|IA2PR13MB6587:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c98c8ff4-cb69-48b3-e1d2-08dc601e9870", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n edqMlsSxmp9yAvjdaYuIbxD0hnpPXcgV8k10X2weeWBoFke0brwGRn1D4xR3MVfw5Spt55iK2sdEY++rT0gY/Bd11xIkv6lvjmUVH+X1PcHGdu7WP/vUZ7/f0UNKZXzlgqgqZveHWtV0AtKoxR/c9rdbqFN5qgFPL5dpOTss2KMbGYZZRP+HFl+ocsS5ZDlrm5eci307q6BwKSbgI398xgFzM+zS/cahZIxYCS2OaiHK3RwgzyemmkRjHm+0cJQG4rWDq5J1FdhBTQM81niMHkyZ1pCps6SQwX9CVnjhIvsBFyeDvN2xfDuDBLJvUUBN1mwN8nzjfxrTqNf16O3bf8M+fhpqPRe3WK/MDw+uWqelY/DdFDGghQrEuJG2e6BVBKjs4oI/3m7A4IHObvidgAjcyqcm2E334zRxYHmFs7GVvcz09YHPj/0W1ds0ckZbUNb8+W8YLfGWiV72/7+6S+I6gfLLNgWFH/op3BuAXo0/suHKsTKgCqT27uYLtq8wMOJHXm3Mc6kEBmOaL/64YkRCBZNyqpyoOF9NxYXUZpq/PMef8Q2L7KQDVccb7WZlKGUgHxSsfJ+PU09KvGp5tT+gUDYwS6nSIirA7KyCp7MQSCYwz0QVzmcHc0w/2XtMTenCb9qV/sZTvXd12yrpU0i9v6Se2a2UeyeHSOTsnbVzo13zjNi+6jEgv+iK916vEDtxXHpoaRS3v3ZNTpPFD7oh8OZo3DqLap/lxgMpS031eEoU1q6YXho8A57P9WyDmdLNmhRhnaci2LSLa1UidwxFl50wB4o480w6CvVVn1b+zMScIzjYFYFBq6ICt/hr2ChJRadHpjWaMxy8Q2h03bnikjRlHhptrtN7Zd0dLnn5r1HQLNZi+QEM2HxRFg2wjWx6oYcYccYFMGkOFUga/puNA/3mgwQLu6ZNrUG4dBP1AqcO2Ws8RMZ0L1TSHiLx2o6Ksx647D7LPmb0THPaGzjvJWx5sZJFBt9cArdRSbJh1weYHNiiVw9ogjHlQgAC7h+tnTxbdkdm4WhefEhLtkXpCTY8KoE0iOYxk7xpDtZx9ibIo7x2GUtHpJjRTLwWAAwgR99t3MxtzcjJsfDtBXl+LqgF/5U9xlHGf515INIgTjr6Q7QwTxLkUsIUHoeD9+yIDnUU2WfM+9N8KjyX+iWHF5p4Ra4TxucT9fZJHACfK+sQHQDMC0INUEdbjMyG/wrjmTojbxR3gbiPIEf+3NIKwHj18uVXCVdCUMJmPEZZxfPzNyrfxQ1SNGMbFkT4CJ2YCZoWMEjZDGHssmSv5JQaBfn52ALKuKAnUbswzrs5iq4m7itie5IAWTmpUx5uiXwLsRHB05xH5W84gVD+hA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(366007)(1800799015)(52116005)(376005)(38350700005); DIR:OUT;\n SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n oc0Wwy/EBbxJy22plsWxdZ9t5lgMaxJTqwT1SdERx0wDsgrfxwzpndfVfzLpp+wXyES0bE1JFEYWQuU03uB8bAHzBP9UOvvBTkpZhYzY2CWNGWY3nClnRsOHOl22lqL9neTKrcx6dMUwbID9Am3TnN9PqX1auX3rqkeOTfy/s2hr6sF5HYfO7T2zuacq0Cq6/KYRDEijrjI7xhnoxvr2JGAEr5GUxJh++P8/GKTgV37e1YfIczyfRB/24zzlIy6ufNKlfV1rhu8YoP5CV2tpZg08XUC8esqSVgtVuKKZp2A3zkUgFPUrLm51irWxC4wLoUJhFfostx9+XQ/TOyupNlC4+7qqfzymejqEcgfy1nw9UP87v3gGlz2rUZTuJ5WzICymmsfiCIKGBXYewDHLIUgHuK8NqI8zhK3kBpsUWTWn6HovVqImTY5lqlBY74gQwxLdW1t5MTErXlag8M2Q6aaiP3oLaxV1CweLwqj4nwtLqBNTQARrRViGctoDJiuVLzoxfhra07RBttQQ96abN16BJSKrXdGkeI90UT4cJWzS4LMGsElRFUcmwWQm55juXbkwWrK6BrJdOdFvMfJuvT8dD+n+ttlFvArUAtjoUd1EGTwwI2s5N8bF2AbW3hVQ+abfcwJOookISzQQUjE7hDIf6fJoP/FB9qp1Sg9TCl5/gD4JAdIIGkr5fGVZTHVT0DlTw/cAQRo40vDJ09OBnQOfMhRQlUIgWGunzXM3H1BLwzziFpQ7X+0gaFg7ilaUMKLz1hR5jMmIPnj6SE/LPPPVWV5HxSfVjip13mkQZCJyG5A7xMHvPWk0u5agDN+PUdKeD69lPFqiMDtx8XxKMSJ2QNe9BLc7Jkb+VNbzU6Q3CyOmNFdwSxeeENk/tArrsNc3VYY1F3skxvXSFL3SrggnDzJnEVj3yw6TrOQbm+ZaW8QC973ZL4mZ4KCwqJBiJDUYbEkqB3Be7ItUHdjwZZ8aRJfpBXKyk5O6+laSXHMln2wXme7Ua73tEspRYhDeAXcQwwZdWF231BCQ65G5NINag11GiwYf/qROpollUQrpkVfGzpCqe+DojZKSoCIY9PluFkLgIFsqcWz+Np8KW3/Fi8mBufzeTYspWH4ywPEht0J2ct5ggY0pwi5XSYMQMTcMyJrJkAcEwRaivFYTRiHJoH6xnPyn8t356MWkZn4/wW/rV5Q4kT76LXHFDgx5Ob5fXp1mcGcI5eGvz9HTZ+6RQ8+Fl+s4IgVCgKZ9Xgd9odhyNcpDWP+9DL/6GEP0vRAS5Z0U0dOnSXnbiqz0OwY1PxpAiyEZFeKRy+HSMj93FsDq6goAHPW1vTqSSUMdb9RF9GiQbBKohnxrrm7PjLHOMaLXen40lCzOQkuQUx7a2buCquKm7rGjAOxA05bheNHKj1pU0FDluduBjeHy6oLQzcHgsdwsgCzpJxpkUvajm7PxWe0Ibu04kzvCkW9tWXFrksK4t5lGfjyQJiGH6qpVGlzun8Eq76OSHslwBCSGhtxL/QGJURhVbpZLB8ms3KUdH6yj5NJPcl3BVMmHvJzLUHZSTsEC+LTA4KqIH8+uMkM26FBG2pKxE7Uk68+18R1TIrCt6ndubSOffX+ipA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c98c8ff4-cb69-48b3-e1d2-08dc601e9870", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Apr 2024 03:12:50.5914 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n ytua+THRGAziRgL28m6v9ywljf6GIh3ouOXlDu+nsvNtqhUj2wzaE7LikKcXH4gZJeOJKbzpkEj6t2KuhDC+C4vd4kLZgRGtwpqawwF6J2g=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA2PR13MB6587", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix one resource leak problem in the abnormal logic of secondary process.\n\nFixes: 016141b18b3a (\"net/nfp: refactor secondary process probe\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_ethdev.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex b711e15b9f..98d8e87028 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -2123,7 +2123,7 @@ nfp_pf_secondary_init(struct rte_pci_device *pci_dev)\n \tif (sym_tbl == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Something is wrong with the firmware symbol table\");\n \t\tret = -EIO;\n-\t\tgoto sync_free;\n+\t\tgoto cpp_cleanup;\n \t}\n \n \t/* Read the app ID of the firmware loaded */\n@@ -2171,6 +2171,8 @@ nfp_pf_secondary_init(struct rte_pci_device *pci_dev)\n \n sym_tbl_cleanup:\n \tfree(sym_tbl);\n+cpp_cleanup:\n+\tnfp_cpp_free(cpp);\n sync_free:\n \tnfp_sync_free(sync);\n pf_cleanup:\n", "prefixes": [ "1/8" ] }