Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139513/?format=api
{ "id": 139513, "url": "http://patches.dpdk.org/api/patches/139513/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1713470562-17415-14-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713470562-17415-14-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713470562-17415-14-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-18T20:02:36", "name": "[v2,13/19] common/idpf: remove use of VLAs for Windows built code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2beff31f1a9c5c517bf43e35e293bf2999144f6e", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1713470562-17415-14-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31785, "url": "http://patches.dpdk.org/api/series/31785/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31785", "date": "2024-04-18T20:02:24", "name": "remove use of VLAs for Windows", "version": 2, "mbox": "http://patches.dpdk.org/series/31785/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139513/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EAE1943EA8;\n\tThu, 18 Apr 2024 22:04:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0BB2840E36;\n\tThu, 18 Apr 2024 22:03:07 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 459EA402D9\n for <dev@dpdk.org>; Thu, 18 Apr 2024 22:02:46 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id AA93620FDAA1; Thu, 18 Apr 2024 13:02:44 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com AA93620FDAA1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713470564;\n bh=wBPWBCzKoyZlhYivMRVovQACG370LiUPsUvgQFujYxU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ZMcQCd73laaUiJ2f9MVCFbMDEaCBpQJfA61Yl0LZhs2Mc5TVkciZ4DBGmgZGe+bJf\n nfkheVYLfR79UZu4UTUh+F2U6n1w5XhPcjSHf9CNtLhBtTdk5Oo884LqiQVNbKynql\n ktwWahDHljDxrBdwXBW9fnnWDmkhREqbmxQKZ2gM=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>", "Subject": "[PATCH v2 13/19] common/idpf: remove use of VLAs for Windows built\n code", "Date": "Thu, 18 Apr 2024 13:02:36 -0700", "Message-Id": "<1713470562-17415-14-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713470562-17415-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1713470562-17415-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not support VLAs, replace VLAs with standard C arrays\nor alloca(). alloca() is available for all toolchain/platform\ncombinations officially supported by DPDK.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/common/idpf/idpf_common_rxtx.c | 2 +-\n drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 ++++--\n 2 files changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c\nindex 83b131e..da24b78 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.c\n+++ b/drivers/common/idpf/idpf_common_rxtx.c\n@@ -569,7 +569,7 @@\n \tuint16_t nb_refill = rx_bufq->rx_free_thresh;\n \tuint16_t nb_desc = rx_bufq->nb_rx_desc;\n \tuint16_t next_avail = rx_bufq->rx_tail;\n-\tstruct rte_mbuf *nmb[rx_bufq->rx_free_thresh];\n+\tstruct rte_mbuf **nmb = alloca(sizeof(struct rte_mbuf *) * rx_bufq->rx_free_thresh);\n \tuint64_t dma_addr;\n \tuint16_t delta;\n \tint i;\ndiff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c b/drivers/common/idpf/idpf_common_rxtx_avx512.c\nindex f65e8d5..9131bd6 100644\n--- a/drivers/common/idpf/idpf_common_rxtx_avx512.c\n+++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c\n@@ -1002,7 +1002,8 @@\n \tuint32_t n;\n \tuint32_t i;\n \tint nb_free = 0;\n-\tstruct rte_mbuf *m, *free[txq->rs_thresh];\n+\tstruct rte_mbuf *m;\n+\tstruct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * txq->rs_thresh);\n \n \t/* check DD bits on threshold descriptor */\n \tif ((txq->tx_ring[txq->next_dd].qw1 &\n@@ -1319,7 +1320,8 @@\n \tuint32_t n;\n \tuint32_t i;\n \tint nb_free = 0;\n-\tstruct rte_mbuf *m, *free[txq->rs_thresh];\n+\tstruct rte_mbuf *m;\n+\tstruct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * txq->rs_thresh);\n \n \tn = txq->rs_thresh;\n \n", "prefixes": [ "v2", "13/19" ] }