Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139501/?format=api
{ "id": 139501, "url": "http://patches.dpdk.org/api/patches/139501/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1713470562-17415-7-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713470562-17415-7-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713470562-17415-7-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-18T20:02:29", "name": "[v2,06/19] hash/thash: remove use of VLAs for Windows built code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fce8179c41935a3a7360d6275c86bb6a1111c98d", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1713470562-17415-7-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31785, "url": "http://patches.dpdk.org/api/series/31785/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31785", "date": "2024-04-18T20:02:24", "name": "remove use of VLAs for Windows", "version": 2, "mbox": "http://patches.dpdk.org/series/31785/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139501/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139501/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 067FC43EA8;\n\tThu, 18 Apr 2024 22:03:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8CA4E40697;\n\tThu, 18 Apr 2024 22:02:53 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 958BE40041\n for <dev@dpdk.org>; Thu, 18 Apr 2024 22:02:45 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 3DFEC20FD93F; Thu, 18 Apr 2024 13:02:44 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 3DFEC20FD93F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713470564;\n bh=ZssL0zHYOwMdVK5d3ZRidx1I1VFqIuAILBn5jA4nMKc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=TSeT5m2FzVkk3Tks+RhhP8ghRcfJVwYRDFW62XHIo+9MnqHwQuiGwiu6FiawggV8G\n 6EyqzCfoA24RvdbZTepozwkR7FTVEA0SWv110EsqWt4BNgfj8wSUEzhh0KWzySWJYB\n B6WaA156ArrDhXp99Gr4qFbCVmLAAqQkAGp5XZ3c=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@huawei.com>", "Subject": "[PATCH v2 06/19] hash/thash: remove use of VLAs for Windows built\n code", "Date": "Thu, 18 Apr 2024 13:02:29 -0700", "Message-Id": "<1713470562-17415-7-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713470562-17415-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1713470562-17415-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n\n1) ./lib/hash/rte_thash.c:774:9\n : warning: ISO C90 forbids variable length array ‘tmp_tuple’ [-Wvla]\n\nFrom my understanding, tuple size here should never exceed\nsizeof(union rte_thash_tuple), so it should be safe to replace VLA with\nfixed size array.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n lib/hash/rte_thash.c | 2 +-\n lib/hash/rte_thash.h | 8 ++++++++\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c\nindex 68f653f..e28d423 100644\n--- a/lib/hash/rte_thash.c\n+++ b/lib/hash/rte_thash.c\n@@ -771,7 +771,7 @@ struct rte_thash_subtuple_helper *\n \tuint32_t desired_value,\tunsigned int attempts,\n \trte_thash_check_tuple_t fn, void *userdata)\n {\n-\tuint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];\n+\tuint32_t tmp_tuple[RTE_THASH_MAX_L4_LEN];\n \tunsigned int i, j, ret = 0;\n \tuint32_t hash, adj_bits;\n \tconst uint8_t *hash_key;\ndiff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h\nindex 30b657e..322fe3a 100644\n--- a/lib/hash/rte_thash.h\n+++ b/lib/hash/rte_thash.h\n@@ -109,6 +109,14 @@ union __rte_aligned(XMM_SIZE) rte_thash_tuple {\n };\n \n /**\n+ * maximum length in dwords of input tuple to\n+ * calculate hash of ipv(4|6) header +\n+ * transport header\n+ */\n+#define RTE_THASH_MAX_L4_LEN\t\\\n+\t((sizeof(union rte_thash_tuple)) / sizeof(uint32_t))\n+\n+/**\n * Prepare special converted key to use with rte_softrss_be()\n * @param orig\n * pointer to original RSS key\n", "prefixes": [ "v2", "06/19" ] }