Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139492/?format=api
{ "id": 139492, "url": "http://patches.dpdk.org/api/patches/139492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240418103314.40705-6-konstantin.v.ananyev@yandex.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240418103314.40705-6-konstantin.v.ananyev@yandex.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418103314.40705-6-konstantin.v.ananyev@yandex.ru", "date": "2024-04-18T10:33:13", "name": "[RFC,5/6] hash/thash: remove VLA warnings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a1b39c52e641be2b1b43579d77151dbec2cfa878", "submitter": { "id": 2660, "url": "http://patches.dpdk.org/api/people/2660/?format=api", "name": "Konstantin Ananyev", "email": "konstantin.v.ananyev@yandex.ru" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240418103314.40705-6-konstantin.v.ananyev@yandex.ru/mbox/", "series": [ { "id": 31781, "url": "http://patches.dpdk.org/api/series/31781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31781", "date": "2024-04-18T10:33:08", "name": "core libs: remove VLA warnings", "version": 1, "mbox": "http://patches.dpdk.org/series/31781/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139492/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139492/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F29843E9F;\n\tThu, 18 Apr 2024 12:34:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B8EEE40A84;\n\tThu, 18 Apr 2024 12:33:50 +0200 (CEST)", "from forward500a.mail.yandex.net (forward500a.mail.yandex.net\n [178.154.239.80])\n by mails.dpdk.org (Postfix) with ESMTP id 7A34940A7F\n for <dev@dpdk.org>; Thu, 18 Apr 2024 12:33:49 +0200 (CEST)", "from mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:7907:0:640:8f19:0])\n by forward500a.mail.yandex.net (Yandex) with ESMTPS id 491B56164B;\n Thu, 18 Apr 2024 13:33:49 +0300 (MSK)", "by mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id GXCBSvCo7Ko0-TsSwqi9x;\n Thu, 18 Apr 2024 13:33:48 +0300" ], "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n t=1713436428; bh=Bzwk20NQQV3OwSPoK0NnvgCo8FXFQX/kl8TVMRycArY=;\n h=Cc:Message-Id:References:Date:In-Reply-To:Subject:To:From;\n b=TgqcfraeD1MQ2vcXsP4sB8q2pLtgRboIZDsNbBwcSwR/sGJ1RgK9lsbyQYggvxwb0\n qy3xQiyfhXwE4IheBVt1uj7kWyndiHGXaWZX9h1PmFcY9UIfDKmzj4uqN+0CCtgQsC\n LYF5gXELOyRmDneHRwNnhG4rQG3M4GaUkyxBjkE0=", "Authentication-Results": "\n mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru", "From": "Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,\n yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n bruce.richardson@intel.com, vladimir.medvedkin@intel.com,\n honnappa.nagarahalli@arm.com, roretzla@linux.microsoft.com,\n Konstantin Ananyev <konstantin.ananyev@huawei.com>", "Subject": "[RFC 5/6] hash/thash: remove VLA warnings", "Date": "Thu, 18 Apr 2024 11:33:13 +0100", "Message-Id": "<20240418103314.40705-6-konstantin.v.ananyev@yandex.ru>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240418103314.40705-1-konstantin.v.ananyev@yandex.ru>", "References": "<20240418103314.40705-1-konstantin.v.ananyev@yandex.ru>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n\n1) ./lib/hash/rte_thash.c:774:9: warning: ISO C90 forbids variable length array ‘tmp_tuple’ [-Wvla]\n\nFrom my understanding, tuple size here should never exceed\nsizeof(union rte_thash_tuple), so it should be safe to replace VLA with\nfixed size array.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n lib/hash/rte_thash.c | 2 +-\n lib/hash/rte_thash.h | 8 ++++++++\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c\nindex 68f653fa3d..e28d423172 100644\n--- a/lib/hash/rte_thash.c\n+++ b/lib/hash/rte_thash.c\n@@ -771,7 +771,7 @@ rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,\n \tuint32_t desired_value,\tunsigned int attempts,\n \trte_thash_check_tuple_t fn, void *userdata)\n {\n-\tuint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];\n+\tuint32_t tmp_tuple[RTE_THASH_MAX_L4_LEN];\n \tunsigned int i, j, ret = 0;\n \tuint32_t hash, adj_bits;\n \tconst uint8_t *hash_key;\ndiff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h\nindex 30b657e67a..322fe3af66 100644\n--- a/lib/hash/rte_thash.h\n+++ b/lib/hash/rte_thash.h\n@@ -108,6 +108,14 @@ union rte_thash_tuple {\n \tstruct rte_ipv6_tuple\tv6;\n };\n \n+/**\n+ * maximum length in dwords of input tuple to\n+ * calculate hash of ipv(4|6) header +\n+ * transport header\n+ */\n+#define RTE_THASH_MAX_L4_LEN\t\\\n+\t((sizeof(union rte_thash_tuple)) / sizeof(uint32_t))\n+\n /**\n * Prepare special converted key to use with rte_softrss_be()\n * @param orig\n", "prefixes": [ "RFC", "5/6" ] }