Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139491/?format=api
{ "id": 139491, "url": "http://patches.dpdk.org/api/patches/139491/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240418103314.40705-5-konstantin.v.ananyev@yandex.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240418103314.40705-5-konstantin.v.ananyev@yandex.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418103314.40705-5-konstantin.v.ananyev@yandex.ru", "date": "2024-04-18T10:33:12", "name": "[RFC,4/6] hash: remove VLA warnings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b9ca80f9e0e9edd1d3a97733297c35ad55ae6767", "submitter": { "id": 2660, "url": "http://patches.dpdk.org/api/people/2660/?format=api", "name": "Konstantin Ananyev", "email": "konstantin.v.ananyev@yandex.ru" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240418103314.40705-5-konstantin.v.ananyev@yandex.ru/mbox/", "series": [ { "id": 31781, "url": "http://patches.dpdk.org/api/series/31781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31781", "date": "2024-04-18T10:33:08", "name": "core libs: remove VLA warnings", "version": 1, "mbox": "http://patches.dpdk.org/series/31781/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139491/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3767543E9F;\n\tThu, 18 Apr 2024 12:33:56 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BFC8F40A72;\n\tThu, 18 Apr 2024 12:33:47 +0200 (CEST)", "from forward500a.mail.yandex.net (forward500a.mail.yandex.net\n [178.154.239.80])\n by mails.dpdk.org (Postfix) with ESMTP id D0F1940A4B\n for <dev@dpdk.org>; Thu, 18 Apr 2024 12:33:45 +0200 (CEST)", "from mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:7907:0:640:8f19:0])\n by forward500a.mail.yandex.net (Yandex) with ESMTPS id 9FA766163F;\n Thu, 18 Apr 2024 13:33:45 +0300 (MSK)", "by mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id GXCBSvCo7Ko0-tjxQX3j8;\n Thu, 18 Apr 2024 13:33:44 +0300" ], "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n t=1713436424; bh=iYvpuGQKjhKfmIR1ELDCiEoTXNl5G8cJLjeY0lPHCo4=;\n h=Cc:Message-Id:References:Date:In-Reply-To:Subject:To:From;\n b=VSiREZw43ARFs4eNxHl23xcrOQYl6LPg9I5XrdJl8kv13ZgTq5IMvgiq9ElluWwQ+\n pdhA7ozHBFRQw8nekbv/Y7RR31WIxKxWNW16cZ8Kb0CXztni3CQYOwn3SIomIMUpPf\n 53EJenckbc7Ah/w3BlIUDmXEY8aSfEeQiQIbYq0Q=", "Authentication-Results": "\n mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru", "From": "Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,\n yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n bruce.richardson@intel.com, vladimir.medvedkin@intel.com,\n honnappa.nagarahalli@arm.com, roretzla@linux.microsoft.com,\n Konstantin Ananyev <konstantin.ananyev@huawei.com>", "Subject": "[RFC 4/6] hash: remove VLA warnings", "Date": "Thu, 18 Apr 2024 11:33:12 +0100", "Message-Id": "<20240418103314.40705-5-konstantin.v.ananyev@yandex.ru>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240418103314.40705-1-konstantin.v.ananyev@yandex.ru>", "References": "<20240418103314.40705-1-konstantin.v.ananyev@yandex.ru>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n\n1) ./lib/hash/rte_cuckoo_hash.c:2362:9: warning: ISO C90 forbids variable length array ‘positions’ [-Wvla]\n2) ../lib/hash/rte_cuckoo_hash.c:2478:9: warning: ISO C90 forbids variable length array ‘positions’ [-Wvla]\n\nBoth rte_hash_lookup_bulk_data() and\nrte_hash_lookup_with_hash_bulk_data() expect\n@num_keys <= RTE_HASH_LOOKUP_BULK_MAX.\nSo, for both cases it should be safe to replace VLA with fixed size\narray.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n lib/hash/rte_cuckoo_hash.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex 9cf94645f6..82b74bda18 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -2359,7 +2359,7 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,\n \t\t\t(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||\n \t\t\t(hit_mask == NULL)), -EINVAL);\n \n-\tint32_t positions[num_keys];\n+\tint32_t positions[RTE_HASH_LOOKUP_BULK_MAX];\n \n \t__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);\n \n@@ -2475,7 +2475,7 @@ rte_hash_lookup_with_hash_bulk_data(const struct rte_hash *h,\n \t\t\t(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||\n \t\t\t(hit_mask == NULL)), -EINVAL);\n \n-\tint32_t positions[num_keys];\n+\tint32_t positions[RTE_HASH_LOOKUP_BULK_MAX];\n \n \t__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,\n \t\t\tpositions, hit_mask, data);\n", "prefixes": [ "RFC", "4/6" ] }