Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139489/?format=api
{ "id": 139489, "url": "http://patches.dpdk.org/api/patches/139489/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240418103314.40705-3-konstantin.v.ananyev@yandex.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240418103314.40705-3-konstantin.v.ananyev@yandex.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418103314.40705-3-konstantin.v.ananyev@yandex.ru", "date": "2024-04-18T10:33:10", "name": "[RFC,2/6] eal/common: remove VLA warnings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bc95f85bf9fa14cb9dc51bf7e9da3d7a27a9056f", "submitter": { "id": 2660, "url": "http://patches.dpdk.org/api/people/2660/?format=api", "name": "Konstantin Ananyev", "email": "konstantin.v.ananyev@yandex.ru" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240418103314.40705-3-konstantin.v.ananyev@yandex.ru/mbox/", "series": [ { "id": 31781, "url": "http://patches.dpdk.org/api/series/31781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31781", "date": "2024-04-18T10:33:08", "name": "core libs: remove VLA warnings", "version": 1, "mbox": "http://patches.dpdk.org/series/31781/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139489/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139489/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA7E843E9F;\n\tThu, 18 Apr 2024 12:33:42 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE420406A2;\n\tThu, 18 Apr 2024 12:33:39 +0200 (CEST)", "from forward500a.mail.yandex.net (forward500a.mail.yandex.net\n [178.154.239.80])\n by mails.dpdk.org (Postfix) with ESMTP id B1A8940042\n for <dev@dpdk.org>; Thu, 18 Apr 2024 12:33:38 +0200 (CEST)", "from mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:7907:0:640:8f19:0])\n by forward500a.mail.yandex.net (Yandex) with ESMTPS id 0979561609;\n Thu, 18 Apr 2024 13:33:38 +0300 (MSK)", "by mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id GXCBSvCo7Ko0-fIfLNEJq;\n Thu, 18 Apr 2024 13:33:37 +0300" ], "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n t=1713436417; bh=8c3tm3/PJUM/SQrWnlTP1KUw5xveOMtjgo3R7mfldAo=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=Unx45vFdtLVx6qICjhYi5lwYSryGJPHBW/EYI5bxd8nGK37XEe0e5mDHEXbk2YbKp\n GDD2O7EMQtqUolZY9tVfkJzPrrldrkNtJLLRKj680CMu16GTk0byqNs4TnzMdmjpWJ\n DCTooPRKArsPtLXIy96AsAhZ94wS6uez28SDwq5A=", "Authentication-Results": "\n mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru", "From": "Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,\n yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n bruce.richardson@intel.com, vladimir.medvedkin@intel.com,\n honnappa.nagarahalli@arm.com, roretzla@linux.microsoft.com,\n Konstantin Ananyev <konstantin.ananyev@huawei.com>", "Subject": "[RFC 2/6] eal/common: remove VLA warnings", "Date": "Thu, 18 Apr 2024 11:33:10 +0100", "Message-Id": "<20240418103314.40705-3-konstantin.v.ananyev@yandex.ru>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240418103314.40705-1-konstantin.v.ananyev@yandex.ru>", "References": "<20240418103314.40705-1-konstantin.v.ananyev@yandex.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n\n1) ../lib/eal/common/eal_common_proc.c:695:15: warning: variable length array used [-Wvla]\n char control[CMSG_SPACE(fd_size)];\n ^~~~~~~~~~~~~~~~~~~\n\nAs msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced\nit with fixed size array.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n lib/eal/common/eal_common_proc.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c\nindex d24093937c..f21ce60a08 100644\n--- a/lib/eal/common/eal_common_proc.c\n+++ b/lib/eal/common/eal_common_proc.c\n@@ -692,7 +692,8 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type)\n \tstruct sockaddr_un dst;\n \tstruct mp_msg_internal m;\n \tint fd_size = msg->num_fds * sizeof(int);\n-\tchar control[CMSG_SPACE(fd_size)];\n+\tint32_t control_sz = CMSG_SPACE(fd_size);\n+\tchar control[CMSG_SPACE(sizeof(msg->fds))];\n \n \tm.type = type;\n \tmemcpy(&m.msg, msg, sizeof(*msg));\n@@ -712,7 +713,7 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type)\n \tmsgh.msg_iov = &iov;\n \tmsgh.msg_iovlen = 1;\n \tmsgh.msg_control = control;\n-\tmsgh.msg_controllen = sizeof(control);\n+\tmsgh.msg_controllen = control_sz;\n \n \tcmsg = CMSG_FIRSTHDR(&msgh);\n \tcmsg->cmsg_len = CMSG_LEN(fd_size);\n", "prefixes": [ "RFC", "2/6" ] }