Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139486/?format=api
{ "id": 139486, "url": "http://patches.dpdk.org/api/patches/139486/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240418082023.1767998-7-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240418082023.1767998-7-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418082023.1767998-7-david.marchand@redhat.com", "date": "2024-04-18T08:20:20", "name": "[v3,6/7] net/iavf: remove outer UDP checksum offload for X710 VF", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fb411b9ff6ed98f4b4f62921136c9dc4486085ab", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240418082023.1767998-7-david.marchand@redhat.com/mbox/", "series": [ { "id": 31780, "url": "http://patches.dpdk.org/api/series/31780/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31780", "date": "2024-04-18T08:20:14", "name": "Fix outer UDP checksum for Intel nics", "version": 3, "mbox": "http://patches.dpdk.org/series/31780/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139486/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139486/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF06243E9E;\n\tThu, 18 Apr 2024 10:21:20 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E833C40EDF;\n\tThu, 18 Apr 2024 10:21:00 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 67F8540ECF\n for <dev@dpdk.org>; Thu, 18 Apr 2024 10:20:59 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-4vBOwanVPMSp-mS8z602JA-1; Thu,\n 18 Apr 2024 04:20:53 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27A671C4C394;\n Thu, 18 Apr 2024 08:20:53 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.69])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 92A741C060D0;\n Thu, 18 Apr 2024 08:20:51 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1713428459;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=T0j+RXnvnrBijTzpEfl40NF9XnoNTHANM9UtjQ7I2nc=;\n b=LBl8VBmToXIt8Q0Mk6QtUKzX91pIqi0787/v1av4LX2AiOnQ2iwRbZ5acUYmQlD/g+97eJ\n xwaNegzOZEvPToTKFZ4uEfK3pNd5GzHp7R6QjFQJItVubPgWFNGU5qmsqZfR7zOpv5cagA\n s+fL2/g9moWXWri+qzmwNj3dRiMKKvo=", "X-MC-Unique": "4vBOwanVPMSp-mS8z602JA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, stable@dpdk.org,\n Jingjing Wu <jingjing.wu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,\n Peng Zhang <peng.zhang@corigine.com>,\n Zhichao Zeng <zhichaox.zeng@intel.com>", "Subject": "[PATCH v3 6/7] net/iavf: remove outer UDP checksum offload for X710\n VF", "Date": "Thu, 18 Apr 2024 10:20:20 +0200", "Message-ID": "<20240418082023.1767998-7-david.marchand@redhat.com>", "In-Reply-To": "<20240418082023.1767998-1-david.marchand@redhat.com>", "References": "<20240405125039.897933-1-david.marchand@redhat.com>\n <20240418082023.1767998-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "According to the X710 datasheet, X710 devices do not support outer\nchecksum offload.\n\n\"\"\"\n8.4.4.2 Transmit L3 and L4 Integrity Offload\n\nTunneling UDP headers and GRE header are not offloaded while the\nX710/XXV710/XL710 leaves their checksum field as is.\nIf a checksum is required, software should provide it as well as the inner\nchecksum value(s) that are required for the outer checksum.\n\"\"\"\n\nFix Tx offload capabilities depending on the VF type.\n\nBugzilla ID: 1406\nFixes: f7c8c36fdeb7 (\"net/iavf: enable inner and outer Tx checksum offload\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/nics/features/iavf.ini | 2 +-\n drivers/net/iavf/iavf_ethdev.c | 5 ++++-\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini\nindex c59115ae15..ce9860e963 100644\n--- a/doc/guides/nics/features/iavf.ini\n+++ b/doc/guides/nics/features/iavf.ini\n@@ -33,7 +33,7 @@ L3 checksum offload = Y\n L4 checksum offload = Y\n Timestamp offload = Y\n Inner L3 checksum = Y\n-Inner L4 checksum = Y\n+Inner L4 checksum = P\n Packet type parsing = Y\n Rx descriptor status = Y\n Tx descriptor status = Y\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 245b3cd854..bbf915097e 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1174,7 +1174,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tRTE_ETH_TX_OFFLOAD_TCP_CKSUM |\n \t\tRTE_ETH_TX_OFFLOAD_SCTP_CKSUM |\n \t\tRTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |\n-\t\tRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |\n \t\tRTE_ETH_TX_OFFLOAD_TCP_TSO |\n \t\tRTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |\n \t\tRTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |\n@@ -1183,6 +1182,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tRTE_ETH_TX_OFFLOAD_MULTI_SEGS |\n \t\tRTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;\n \n+\t/* X710 does not support outer udp checksum */\n+\tif (adapter->hw.mac.type != IAVF_MAC_XL710)\n+\t\tdev_info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;\n+\n \tif (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_CRC)\n \t\tdev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC;\n \n", "prefixes": [ "v3", "6/7" ] }