Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139485/?format=api
{ "id": 139485, "url": "http://patches.dpdk.org/api/patches/139485/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240418082023.1767998-6-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240418082023.1767998-6-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418082023.1767998-6-david.marchand@redhat.com", "date": "2024-04-18T08:20:19", "name": "[v3,5/7] net/i40e: fix outer UDP checksum offload for X710", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e426fb4170963e41cce21379ae02033404a9f229", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240418082023.1767998-6-david.marchand@redhat.com/mbox/", "series": [ { "id": 31780, "url": "http://patches.dpdk.org/api/series/31780/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31780", "date": "2024-04-18T08:20:14", "name": "Fix outer UDP checksum for Intel nics", "version": 3, "mbox": "http://patches.dpdk.org/series/31780/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139485/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139485/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 185C243E9E;\n\tThu, 18 Apr 2024 10:21:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2086240ED2;\n\tThu, 18 Apr 2024 10:20:55 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 9F37140ECF\n for <dev@dpdk.org>; Thu, 18 Apr 2024 10:20:53 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-m0NgL3DIPja7W0gUM487qw-1; Thu,\n 18 Apr 2024 04:20:49 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 797E83C1015E;\n Thu, 18 Apr 2024 08:20:49 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.69])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 65E4D35430;\n Thu, 18 Apr 2024 08:20:47 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1713428453;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AbY1bjB/FNwTyGqJGT/MAqOZTsm6Hg/hwgrAb+x1vcM=;\n b=BTL7Da/q0W9makn7SyBe4Ypyz1pXNpDNu9LT2UKNf777vA+KPjvyFuz4yePI5HNU7NJhFd\n vtyFi5AARG3v+3+K8/81vbC5ZxFgCTuavovvsQg7LAho7nAUQishHTvLdaSCyd3HVlYcKW\n i6wbAYMW6WxM6fvTQBceZK/5zaoQoCI=", "X-MC-Unique": "m0NgL3DIPja7W0gUM487qw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, stable@dpdk.org,\n Jun Wang <junwang01@cestc.cn>, Yuying Zhang <Yuying.Zhang@intel.com>,\n Jie Wang <jie1x.wang@intel.com>, Beilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH v3 5/7] net/i40e: fix outer UDP checksum offload for X710", "Date": "Thu, 18 Apr 2024 10:20:19 +0200", "Message-ID": "<20240418082023.1767998-6-david.marchand@redhat.com>", "In-Reply-To": "<20240418082023.1767998-1-david.marchand@redhat.com>", "References": "<20240405125039.897933-1-david.marchand@redhat.com>\n <20240418082023.1767998-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "According to the X710 datasheet (and confirmed on the field..), X710\ndevices do not support outer checksum offload.\n\n\"\"\"\n8.4.4.2 Transmit L3 and L4 Integrity Offload\n\nTunneling UDP headers and GRE header are not offloaded while the\nX710/XXV710/XL710 leaves their checksum field as is.\nIf a checksum is required, software should provide it as well as the inner\nchecksum value(s) that are required for the outer checksum.\n\"\"\"\n\nFix Tx offload capabilities according to the hardware.\n\nX722 may support such offload by setting I40E_TXD_CTX_QW0_L4T_CS_MASK.\n\nBugzilla ID: 1406\nFixes: 8cc79a1636cd (\"net/i40e: fix forward outer IPv6 VXLAN\")\nCc: stable@dpdk.org\n\nReported-by: Jun Wang <junwang01@cestc.cn>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nNote: I do not have X722 nic. Please Intel devs, check for both X710 and\nX722 series.\n\nChanges since v1:\n- fix inverted check,\n\n---\n .mailmap | 1 +\n drivers/net/i40e/i40e_ethdev.c | 6 +++++-\n drivers/net/i40e/i40e_rxtx.c | 9 +++++++++\n 3 files changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 3843868716..091766eca7 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -719,6 +719,7 @@ Junjie Wan <wanjunjie@bytedance.com>\n Jun Qiu <jun.qiu@jaguarmicro.com>\n Jun W Zhou <junx.w.zhou@intel.com>\n Junxiao Shi <git@mail1.yoursunny.com>\n+Jun Wang <junwang01@cestc.cn>\n Jun Yang <jun.yang@nxp.com>\n Junyu Jiang <junyux.jiang@intel.com>\n Juraj Linkeš <juraj.linkes@pantheon.tech>\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 380ce1a720..6535c7c178 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -3862,8 +3862,12 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tRTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |\n \t\tRTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |\n \t\tRTE_ETH_TX_OFFLOAD_MULTI_SEGS |\n-\t\tRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |\n \t\tdev_info->tx_queue_offload_capa;\n+\tif (hw->mac.type == I40E_MAC_X722) {\n+\t\tdev_info->tx_offload_capa |=\n+\t\t\tRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;\n+\t}\n+\n \tdev_info->dev_capa =\n \t\tRTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |\n \t\tRTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;\ndiff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 5d25ab4d3a..b4f7599cfc 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -295,6 +295,15 @@ i40e_parse_tunneling_params(uint64_t ol_flags,\n \t */\n \t*cd_tunneling |= (tx_offload.l2_len >> 1) <<\n \t\tI40E_TXD_CTX_QW0_NATLEN_SHIFT;\n+\n+\t/**\n+\t * Calculate the tunneling UDP checksum (only supported with X722).\n+\t * Shall be set only if L4TUNT = 01b and EIPT is not zero\n+\t */\n+\tif ((*cd_tunneling & I40E_TXD_CTX_QW0_EXT_IP_MASK) &&\n+\t\t\t(*cd_tunneling & I40E_TXD_CTX_UDP_TUNNELING) &&\n+\t\t\t(ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM))\n+\t\t*cd_tunneling |= I40E_TXD_CTX_QW0_L4T_CS_MASK;\n }\n \n static inline void\n", "prefixes": [ "v3", "5/7" ] }