Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139475/?format=api
{ "id": 139475, "url": "http://patches.dpdk.org/api/patches/139475/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1713397319-26135-15-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713397319-26135-15-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713397319-26135-15-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-17T23:41:57", "name": "[14/16] common/mlx5: remove use of VLAs for Windows built code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4c397246bdc36b69a6f9268d6eea7266b9525a23", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1713397319-26135-15-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31775, "url": "http://patches.dpdk.org/api/series/31775/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31775", "date": "2024-04-17T23:41:45", "name": "remove use of VLAs for Windows built code", "version": 1, "mbox": "http://patches.dpdk.org/series/31775/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139475/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6BAFF43E97;\n\tThu, 18 Apr 2024 01:43:37 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 987D440DDC;\n\tThu, 18 Apr 2024 01:42:27 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 2F7F0402E2\n for <dev@dpdk.org>; Thu, 18 Apr 2024 01:42:04 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id ADE0F20FD8A5; Wed, 17 Apr 2024 16:42:02 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com ADE0F20FD8A5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713397322;\n bh=k3CYQT0gKPaUKQb+synqrou+8ObN5NXsie4r2fIPSgo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=fUWhRNeXwGlaZtB1VGxi1W4c7ymleDmxCEPNPAV7sAo7651NWHrgW9U4DhJHmerHt\n 0U5kx9zhhgdp7zSsYo2xp7iXnHbh/RpjyyEdTgbmD2UT/g/azMxzDwWYN1lZjf8KbO\n BGdksrozWVFxGVTn30fGd+OUNMhjEM8mVBk6RPR8=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>", "Subject": "[PATCH 14/16] common/mlx5: remove use of VLAs for Windows built code", "Date": "Wed, 17 Apr 2024 16:41:57 -0700", "Message-Id": "<1713397319-26135-15-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not support VLAs, replace VLAs with standard C arrays\nor alloca(). alloca() is available for all toolchain/platform\ncombinations officially supported by DPDK.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/common/mlx5/mlx5_common.h | 4 ++--\n drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++----\n 2 files changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex 9c80277..76eba1c 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -112,10 +112,10 @@\n /* Allocate a buffer on the stack and fill it with a printf format string. */\n #define MKSTR(name, ...) \\\n \tint mkstr_size_##name = snprintf(NULL, 0, \"\" __VA_ARGS__); \\\n-\tchar name[mkstr_size_##name + 1]; \\\n+\tchar *name = alloca(mkstr_size_##name + 1); \\\n \t\\\n \tmemset(name, 0, mkstr_size_##name + 1); \\\n-\tsnprintf(name, sizeof(name), \"\" __VA_ARGS__)\n+\tsnprintf(name, mkstr_size_##name + 1, \"\" __VA_ARGS__)\n \n enum {\n \tPCI_VENDOR_ID_MELLANOX = 0x15b3,\ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 9b7abab..bac272f 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -284,10 +284,9 @@ struct mlx5_devx_obj *\n \t\t\t\t void *cmd_comp,\n \t\t\t\t uint64_t async_id)\n {\n-\tint out_len = MLX5_ST_SZ_BYTES(query_flow_counter_out) +\n-\t\t\tMLX5_ST_SZ_BYTES(traffic_counter);\n-\tuint32_t out[out_len];\n+\tuint32_t out[MLX5_ST_SZ_BYTES(query_flow_counter_out) + MLX5_ST_SZ_BYTES(traffic_counter)];\n \tuint32_t in[MLX5_ST_SZ_DW(query_flow_counter_in)] = {0};\n+\tconst int out_len = RTE_DIM(out);\n \tvoid *stats;\n \tint rc;\n \n@@ -346,7 +345,7 @@ struct mlx5_devx_obj *\n \tint klm_num = attr->klm_num;\n \tint in_size_dw = MLX5_ST_SZ_DW(create_mkey_in) +\n \t\t (klm_num ? RTE_ALIGN(klm_num, 4) : 0) * MLX5_ST_SZ_DW(klm);\n-\tuint32_t in[in_size_dw];\n+\tuint32_t *in = alloca(sizeof(uint32_t) * in_size_dw);\n \tuint32_t out[MLX5_ST_SZ_DW(create_mkey_out)] = {0};\n \tvoid *mkc;\n \tstruct mlx5_devx_obj *mkey = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*mkey),\n", "prefixes": [ "14/16" ] }