Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139464/?format=api
{ "id": 139464, "url": "http://patches.dpdk.org/api/patches/139464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-17T23:41:46", "name": "[03/16] ethdev: remove use of VLAs for Windows built code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cc8945da38dacfd16283ca7ef08381b9cef1f686", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31775, "url": "http://patches.dpdk.org/api/series/31775/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31775", "date": "2024-04-17T23:41:45", "name": "remove use of VLAs for Windows built code", "version": 1, "mbox": "http://patches.dpdk.org/series/31775/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139464/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B06DF43E97;\n\tThu, 18 Apr 2024 01:42:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DB18340685;\n\tThu, 18 Apr 2024 01:42:10 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 23D96402D4\n for <dev@dpdk.org>; Thu, 18 Apr 2024 01:42:03 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 095B920FD4CE; Wed, 17 Apr 2024 16:42:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 095B920FD4CE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713397322;\n bh=1UgesD7xdvLHA9+rwinkWvJvo0cgvqofqVp5wXh3rSo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=K6GtwC5rXa7OZbEE5/iEkVMfQHYUvBoJCIYOnu1ea833hrQjyY2Asg8/kbXZ3pooM\n z6CZZHdZghkRE0jquWlS3vi37sZubkJWAPp1WQMzxQgHeZauRGIvqo96FgbJwH4Imu\n LPE+vF0IEL8My5eMRqjY90q5ONfpeZm9ztI2cscA=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>", "Subject": "[PATCH 03/16] ethdev: remove use of VLAs for Windows built code", "Date": "Wed, 17 Apr 2024 16:41:46 -0700", "Message-Id": "<1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not support VLAs, replace VLAs with standard C arrays\nor alloca(). alloca() is available for all toolchain/platform\ncombinations officially supported by DPDK.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/ethdev/rte_ethdev.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex f1c658f..cd2ed74 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -3241,7 +3241,8 @@ enum {\n \t}\n \n \t/* Get id-name lookup table */\n-\tstruct rte_eth_xstat_name xstats_names[cnt_xstats];\n+\tstruct rte_eth_xstat_name *xstats_names =\n+\t alloca(sizeof(struct rte_eth_xstat_name) * cnt_xstats);\n \n \tif (cnt_xstats != rte_eth_xstats_get_names_by_id(\n \t\t\tport_id, xstats_names, cnt_xstats, NULL)) {\n@@ -3342,7 +3343,7 @@ enum {\n \t\treturn -EINVAL;\n \n \tif (ids && dev->dev_ops->xstats_get_names_by_id != NULL && size > 0) {\n-\t\tuint64_t ids_copy[size];\n+\t\tuint64_t *ids_copy = alloca(sizeof(uint64_t) * size);\n \n \t\tfor (i = 0; i < size; i++) {\n \t\t\tif (ids[i] < basic_count) {\n@@ -3535,7 +3536,7 @@ enum {\n \tif (ret < 0)\n \t\treturn ret;\n \texpected_entries = (uint16_t)ret;\n-\tstruct rte_eth_xstat xstats[expected_entries];\n+\tstruct rte_eth_xstat *xstats = alloca(sizeof(struct rte_eth_xstat) * expected_entries);\n \tbasic_count = eth_dev_get_xstats_basic_count(dev);\n \n \t/* Return max number of stats if no ids given */\n@@ -3551,7 +3552,7 @@ enum {\n \n \tif (ids && dev->dev_ops->xstats_get_by_id != NULL && size) {\n \t\tunsigned int basic_count = eth_dev_get_xstats_basic_count(dev);\n-\t\tuint64_t ids_copy[size];\n+\t\tuint64_t *ids_copy = alloca(sizeof(uint64_t) * size);\n \n \t\tfor (i = 0; i < size; i++) {\n \t\t\tif (ids[i] < basic_count) {\n", "prefixes": [ "03/16" ] }