Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139457/?format=api
{ "id": 139457, "url": "http://patches.dpdk.org/api/patches/139457/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240417170908.76701-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240417170908.76701-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240417170908.76701-3-stephen@networkplumber.org", "date": "2024-04-17T17:07:24", "name": "[v3,2/5] latencystats: handle fractional cycles per ns", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "564d775a44ba9e491cd56da1adcb521a53ea8233", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240417170908.76701-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31774, "url": "http://patches.dpdk.org/api/series/31774/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31774", "date": "2024-04-17T17:07:22", "name": "latencystats: cleanups", "version": 3, "mbox": "http://patches.dpdk.org/series/31774/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139457/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE6C543E94;\n\tWed, 17 Apr 2024 19:09:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 996B2427E0;\n\tWed, 17 Apr 2024 19:09:16 +0200 (CEST)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id 0754140DDA\n for <dev@dpdk.org>; Wed, 17 Apr 2024 19:09:13 +0200 (CEST)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1e51398cc4eso54155155ad.2\n for <dev@dpdk.org>; Wed, 17 Apr 2024 10:09:12 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n l5-20020a170903120500b001e4458831afsm11832442plh.227.2024.04.17.10.09.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 Apr 2024 10:09:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713373752;\n x=1713978552; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xYrob5Igy97bVmNali5cqA6qBua8Lq4/b+oiBXDUq0Y=;\n b=Wz6eDsikRSevaWdBLk/cmYfQCUadl1RiuympMEtFgharKXDNxAEOeMfvz7FRVYrhCS\n fMOVAX6iUfkA34BOA/PnHqdmba5+W00RHDRtgUt9+s3SVfkAOvv4u5ZMOoSi6lmyhrNY\n HnHiGrt4PbbUmSJrq2p6cJRysduLSCOrUsOCUF70i/pNdk0GOnkom8A+Cqo3Ms5dVwqg\n sb/NuTsLxKjM6s+RZpdXCIeXKfo1YPYwZEDYhhTfHU4/Z/6KfEnQdS9YWI0Q/N3WyRha\n ZSwPJndQ1s/sOu0VTkfwiTYi1xl1qStip823FcL7lCbThxRMSfxoiunRlt/Fesc/Ya1w\n xqpg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713373752; x=1713978552;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=xYrob5Igy97bVmNali5cqA6qBua8Lq4/b+oiBXDUq0Y=;\n b=rcMVSi3tSHsJDBELkhFCyP1Gn4z+vkHPK5kZ+FcHOW5wh5/TqTc9w1PMFFI+nKu2Mr\n a05tBuaS6HvmZr9jd5ShW/ssuyCeGLxLHFNAo65unjn3cGoGuRhXsNb7rOlVsH3l5JOp\n 2Cj6jmk3T3iHIAR0hm6WPwWPxsilVaCep43PTAdIguYeqM8IX0XA6JYiRIj1Oi0VW8hI\n h2rAHEzSB0NK9OdsXVUhRVAwNMGrNw1wMyIRWzrKh7bZAuSySX5fL8U6d/ySwDPmhgUJ\n E7NlQXncpUEIcbnctLr1RK3Zw6jv82Qx1fUGKmCV4zMYQuhQuVjbKypUtnXDvHQKiADz\n ZvPg==", "X-Gm-Message-State": "AOJu0Yy2hkBH4g/ujwobjxfP0vkUubWu9C2Aob2UsjLk5GgDdS3HX8bR\n FqO6qwKDwaXnQUQscEjjEHncOEyphXFfNtErOLjm73QGZJAXb5PZVVRNMA2UlwPQz7/v5hJ4XJJ\n g", "X-Google-Smtp-Source": "\n AGHT+IE0RtU9OFX2rxjrZ7ebkMLw9SdSOKhmowmXa8RqjGR+8z53vWNsyjeGPl9nK3Mmk+VTkLGaAw==", "X-Received": "by 2002:a17:902:cecb:b0:1e4:51ab:fffb with SMTP id\n d11-20020a170902cecb00b001e451abfffbmr101069plg.25.1713373752194;\n Wed, 17 Apr 2024 10:09:12 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v3 2/5] latencystats: handle fractional cycles per ns", "Date": "Wed, 17 Apr 2024 10:07:24 -0700", "Message-ID": "<20240417170908.76701-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240417170908.76701-1-stephen@networkplumber.org>", "References": "<0240408195036.182545-1-stephen@networkplumber.org>\n <20240417170908.76701-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The timer_hz is not always an integral number of nanoseconds.\nFor examples, cycles per nanoseconds on my test system is 2.8.\nFix by using floating point where needed.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 9b345bfb33..fe8c3c563a 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -19,10 +19,10 @@\n #define NS_PER_SEC 1E9\n \n /** Clock cycles per nano second */\n-static uint64_t\n+static float\n latencystat_cycles_per_ns(void)\n {\n-\treturn rte_get_timer_hz() / NS_PER_SEC;\n+\treturn (double)rte_get_timer_hz() / NS_PER_SEC;\n }\n \n RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);\n@@ -89,8 +89,7 @@ rte_latencystats_update(void)\n \tfor (i = 0; i < NUM_LATENCY_STATS; i++) {\n \t\tstats_ptr = RTE_PTR_ADD(glob_stats,\n \t\t\t\tlat_stats_strings[i].offset);\n-\t\tvalues[i] = (uint64_t)floor((*stats_ptr)/\n-\t\t\t\tlatencystat_cycles_per_ns());\n+\t\tvalues[i] = floor(*stats_ptr / latencystat_cycles_per_ns());\n \t}\n \n \tret = rte_metrics_update_values(RTE_METRICS_GLOBAL,\n@@ -112,8 +111,7 @@ rte_latencystats_fill_values(struct rte_metric_value *values)\n \t\tstats_ptr = RTE_PTR_ADD(glob_stats,\n \t\t\t\tlat_stats_strings[i].offset);\n \t\tvalues[i].key = i;\n-\t\tvalues[i].value = (uint64_t)floor((*stats_ptr)/\n-\t\t\t\t\t\tlatencystat_cycles_per_ns());\n+\t\tvalues[i].value = floor(*stats_ptr / latencystat_cycles_per_ns());\n \t}\n }\n \n@@ -237,7 +235,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \n \tglob_stats = mz->addr;\n \trte_spinlock_init(&glob_stats->lock);\n-\tsamp_intvl = app_samp_intvl * latencystat_cycles_per_ns();\n+\tsamp_intvl = floor(app_samp_intvl * latencystat_cycles_per_ns());\n \n \t/** Register latency stats with stats library */\n \tfor (i = 0; i < NUM_LATENCY_STATS; i++)\n", "prefixes": [ "v3", "2/5" ] }