Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139415/?format=api
{ "id": 139415, "url": "http://patches.dpdk.org/api/patches/139415/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240416095556.173787-1-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240416095556.173787-1-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240416095556.173787-1-sivaprasad.tummala@amd.com", "date": "2024-04-16T09:55:56", "name": "[v2] app/testpmd: fix lcore ID restriction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7a450e507c03e7d97e9e82766e75324b2cd85c9e", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240416095556.173787-1-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 31753, "url": "http://patches.dpdk.org/api/series/31753/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31753", "date": "2024-04-16T09:55:56", "name": "[v2] app/testpmd: fix lcore ID restriction", "version": 2, "mbox": "http://patches.dpdk.org/series/31753/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139415/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139415/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 755A443E6F;\n\tTue, 16 Apr 2024 11:56:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 40441402AE;\n\tTue, 16 Apr 2024 11:56:25 +0200 (CEST)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam04on2066.outbound.protection.outlook.com [40.107.102.66])\n by mails.dpdk.org (Postfix) with ESMTP id 2526F4029E;\n Tue, 16 Apr 2024 11:56:24 +0200 (CEST)", "from DM6PR07CA0072.namprd07.prod.outlook.com (2603:10b6:5:74::49) by\n DS0PR12MB6584.namprd12.prod.outlook.com (2603:10b6:8:d0::6) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7452.50; Tue, 16 Apr 2024 09:56:22 +0000", "from CY4PEPF0000E9DB.namprd05.prod.outlook.com\n (2603:10b6:5:74:cafe::eb) by DM6PR07CA0072.outlook.office365.com\n (2603:10b6:5:74::49) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.34 via Frontend\n Transport; Tue, 16 Apr 2024 09:56:22 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.74) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Tue, 16 Apr 2024 09:56:21 +0000", "from jfw9ny3-os.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr\n 2024 04:56:17 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=H9A3IvMjwOzbb6/Xt2ZD61udEuwJX/G18k3CfuQd3MCIdiY4gB4TDp+HzmCh71PYoy3tGPznRtRelOU/vNN25YuN69Kh9SrrwmoCU4fEso2DLQDOV4249b/DgCMkzADjjYSehK8RQT92z8wcuT6HT+L8jAuPkk5nhIpE7yqHY17Y6b5497BW/vtvOEd+5PFPycgxezB0V+7gNYoI2TRN5Ulr+IEyjMkjBWczoF0eSimb/nqzhY8rQSVOUO+CmFl5vQarnLoRQKIc/UmC3M2M2YMX/ziwlTGih63PlTuKtrIZaDi6vM/aMpO/Gqxo1lEWNCrWt/zb698D7sDYVBJrgw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=cT6ACL8iZ1amWeMoBn8KWfjml2ktiDt5OXrGB2yzUUk=;\n b=iel7rukPAqVPeTQRfrBZfdIBrqrayl4VBINdh58ygkrGzEezQ8f+EgIW3qT53rCDbiVz1Y3xHZlEskfgMzZ8dhJxwEKgHirTdcGM5CYtuPQZm38/o2ltTzoIvqtTWdGrqRr2q/wR1RiUF8gmp5Ij/x+OY4tSbos1E1aU+z+HhAjTfRE2D9ICQomYXSI10hvTIN7g1wAjkAUyeNv5S61piteeNO1KdDgkiFmM9A0fpiE8U1Iqtdg9955x3DxvJcnJ1CHOSbjB26eL2aM+ZsWAjn3KEWLme78o0/Z/zSg5IJApLt2dAWOpMb77Y3QFFoLgs47cQLb3u6AqITOKpWThRw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=cT6ACL8iZ1amWeMoBn8KWfjml2ktiDt5OXrGB2yzUUk=;\n b=l6KeBns95sJKkFDd/uoDit+M7CNpVPxlum63cNpTbQGjxhNCjTuu5R9twifq4NyfJKV5kDlQrAyxLK1lASXDPQUKLUViOJShjQ8TVHfZlDUy5fVfHYTfkCfJ14gP+X2EbB6g3RlGIUJLK06qzk4kzTUNLlvWW2dOYi9jkNqGezE=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.marchand@redhat.com>, <aman.deep.singh@intel.com>,\n <yuying.zhang@intel.com>, <ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH v2] app/testpmd: fix lcore ID restriction", "Date": "Tue, 16 Apr 2024 09:55:56 +0000", "Message-ID": "<20240416095556.173787-1-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240415194631.124343-1-sivaprasad.tummala@amd.com>", "References": "<20240415194631.124343-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000E9DB:EE_|DS0PR12MB6584:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e2f060f1-53fb-4304-18dc-08dc5dfb7879", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DfWh0+F7aX+p/nkH4PMUPdTYwdbZy1xilkugBtYaFSGdgHPnW4GVK8c6gjRilZHC12lGGGJd2hYaZHhGKWDtSFAAFju3ao7a0t2cdTmgW/7/6pobdUHEXd45/q6GpXlA4CAYWRdUhdexkb5YQpmPa4UmXOaNbdRtOKbxF5BYHuf2QaCcgqDyKrm6FthP357JQBonToP4VbkfohsUwxC6e9fNH+xOu1BmktwepOBt+b6Bsd1Tf2jZ1VmDuYU4D1Vh4FdT3S/o6DxxSJisUGLFPq24PML/CfWIgaIzqrNUTA6txHf6o94KXVCSOf7RBI6/OhnvIfIiLvEPmCHNfLOkJ6hDX4yIrtQndgFqLHOYzCaGmEqZ9u951Gs/v+zS04LX7wldy1XZYiShol3HUq3976OjaEZqBbDcTUy0pLxSiBzY1y53T81P4XGTRqDsPfAm03k0j8oJ038LncK/bpwETkarK4qdkGdpG36LLllklRKma9kv+CXpDan1JphNyQjTcrcZ+QFvZ/pzuUT14O5rruzagSXJwuezgbL3wtC3UM3tR0s2fN+Ui6dr3gZ5M1eZX+uLPQje18dTCEzi2xifhtaoHQgEcwa702Rx/Olok8Q9Xa3b33wMe5kcwFRwmljGKNByXIXuyrwuTu/UYm70xaSvDQ/ZoP61xqeopqBg3yorNGyMJZChnzwFx4s/A/eHfEvoPI4oRhxp+Jg29KSq789YRkUBWLKorf6C8csDc5KW2eqTaQL4F5ptDFARuf8E", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Apr 2024 09:56:21.8050 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e2f060f1-53fb-4304-18dc-08dc5dfb7879", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000E9DB.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS0PR12MB6584", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "With modern CPUs, it is possible to have higher\nCPU count thus we can have higher RTE_MAX_LCORES.\nIn testpmd application, the current config forwarding\ncores option \"--nb-cores\" is hard limited to 255.\n\nThe patch fixes this constraint and also adjusts the lcore\ndata structure to 32-bit to align with rte lcore APIs.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\n---\nv2:\n* Fixed type mistmatch in comparison \n* Fixed incorrect format specifier\n---\n app/test-pmd/config.c | 6 +++---\n app/test-pmd/parameters.c | 4 ++--\n app/test-pmd/testpmd.h | 2 +-\n 3 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex ba1007ace6..6b28c22c96 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -4785,9 +4785,9 @@ fwd_stream_on_other_lcores(uint16_t domain_id, lcoreid_t src_lc,\n \t\t\t\tcontinue;\n \t\t\tprintf(\"Shared Rx queue group %u queue %hu can't be scheduled on different cores:\\n\",\n \t\t\t share_group, share_rxq);\n-\t\t\tprintf(\" lcore %hhu Port %hu queue %hu\\n\",\n+\t\t\tprintf(\" lcore %u Port %hu queue %hu\\n\",\n \t\t\t src_lc, src_port, src_rxq);\n-\t\t\tprintf(\" lcore %hhu Port %hu queue %hu\\n\",\n+\t\t\tprintf(\" lcore %u Port %hu queue %hu\\n\",\n \t\t\t lc_id, fs->rx_port, fs->rx_queue);\n \t\t\tprintf(\"Please use --nb-cores=%hu to limit number of forwarding cores\\n\",\n \t\t\t nb_rxq);\n@@ -5159,7 +5159,7 @@ icmp_echo_config_setup(void)\n \tlcoreid_t lc_id;\n \tuint16_t sm_id;\n \n-\tif ((nb_txq * nb_fwd_ports) < nb_fwd_lcores)\n+\tif ((lcoreid_t)(nb_txq * nb_fwd_ports) < nb_fwd_lcores)\n \t\tcur_fwd_config.nb_fwd_lcores = (lcoreid_t)\n \t\t\t(nb_txq * nb_fwd_ports);\n \telse\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex c13f7564bf..22364e09ab 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -1071,8 +1071,8 @@ launch_args_parse(int argc, char** argv)\n \t\t\tbreak;\n \t\tcase TESTPMD_OPT_NB_CORES_NUM:\n \t\t\tn = atoi(optarg);\n-\t\t\tif (n > 0 && n <= nb_lcores)\n-\t\t\t\tnb_fwd_lcores = (uint8_t) n;\n+\t\t\tif (n > 0 && (lcoreid_t)n <= nb_lcores)\n+\t\t\t\tnb_fwd_lcores = (lcoreid_t) n;\n \t\t\telse\n \t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\"nb-cores should be > 0 and <= %d\\n\",\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 0afae7d771..9facd7f281 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -84,7 +84,7 @@ extern volatile uint8_t f_quit;\n /* Maximum number of pools supported per Rx queue */\n #define MAX_MEMPOOL 8\n \n-typedef uint8_t lcoreid_t;\n+typedef uint32_t lcoreid_t;\n typedef uint16_t portid_t;\n typedef uint16_t queueid_t;\n typedef uint16_t streamid_t;\n", "prefixes": [ "v2" ] }