Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139378/?format=api
{ "id": 139378, "url": "http://patches.dpdk.org/api/patches/139378/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1713211485-9021-84-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713211485-9021-84-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713211485-9021-84-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-15T20:04:45", "name": "[v2,83/83] bus/dpaa: move alignment attribute on types", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d751570ecabcbcb19571726e38de63bca3d87fdd", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1713211485-9021-84-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31746, "url": "http://patches.dpdk.org/api/series/31746/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31746", "date": "2024-04-15T20:03:22", "name": "move alignment attribute on types", "version": 2, "mbox": "http://patches.dpdk.org/series/31746/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139378/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139378/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CF99843E7E;\n\tMon, 15 Apr 2024 22:14:11 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DE03342E7B;\n\tMon, 15 Apr 2024 22:06:49 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id F110740E01\n for <dev@dpdk.org>; Mon, 15 Apr 2024 22:05:09 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id BD31020FDC4B; Mon, 15 Apr 2024 13:04:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com BD31020FDC4B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713211492;\n bh=QonUznfy2EjzBQG2b4NgAkqmSY7CRaUj59n8TbnGgUM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=MnxSrbg2PJdN8Cx2jbaI/ZD0Z5w7pKvj07nFurSpxdb/t1msR0fM8PiOtejkfVDMR\n eGQhFL9TroGglzCe+Jqgy0/tAoY4aG6dlOL/0JZjKKqzGYoHdGajfEk5xAkyFxpb9a\n JkLzKX5cnSVozuvoTUGwGvVhTChr3cLlqwZVRjKw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Abdullah Sevincer <abdullah.sevincer@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Akhil Goyal <gakhil@marvell.com>,\n Alok Prasad <palok@marvell.com>, Amit Bernstein <amitbern@amazon.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ankur Dwivedi <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Ashish Gupta <ashish.gupta@marvell.com>,\n Ashwin Sekhar T K <asekhar@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>,\n Chaoyong He <chaoyong.he@corigine.com>, Chas Williams <chas3@att.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Conor Walsh <conor.walsh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Ed Czeck <ed.czeck@atomicrules.com>, Evgeny Schemeilin <evgenys@amazon.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Gagandeep Singh <g.singh@nxp.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jakub Grajciar <jgrajcia@cisco.com>,\n Jerin Jacob <jerinj@marvell.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jie Hai <haijie1@huawei.com>,\n Jingjing Wu <jingjing.wu@intel.com>, John Daley <johndale@cisco.com>,\n John Miller <john.miller@atomicrules.com>, Joyce Kong <joyce.kong@arm.com>,\n Kai Ji <kai.ji@intel.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Lee Daly <lee.daly@intel.com>, Liang Ma <liangma@liangbit.com>,\n Liron Himi <lironh@marvell.com>, Long Li <longli@microsoft.com>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Matt Peters <matt.peters@windriver.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Michael Shamis <michaelsh@marvell.com>,\n Nagadheeraj Rottela <rnagadheeraj@marvell.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Peter Mccarthy <peter.mccarthy@intel.com>,\n Radu Nicolau <radu.nicolau@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Rakesh Kudurumalla <rkudurumalla@marvell.com>,\n Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Ron Beider <rbeider@amazon.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Sachin Saxena <sachin.saxena@nxp.com>,\n Selwin Sebastian <selwin.sebastian@amd.com>,\n Shai Brandes <shaibran@amazon.com>,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Shijith Thotton <sthotton@marvell.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Steven Webster <steven.webster@windriver.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,\n Sunila Sahu <ssahu@marvell.com>, Tejasree Kondoj <ktejasree@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vikas Gupta <vikas.gupta@broadcom.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Wajeeh Atrash <atrwajee@amazon.com>,\n Wisam Jaddo <wisamm@nvidia.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>,\n Zhangfei Gao <zhangfei.gao@linaro.org>, Zhirun Yan <yanzhirun_163@163.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 83/83] bus/dpaa: move alignment attribute on types", "Date": "Mon, 15 Apr 2024 13:04:45 -0700", "Message-Id": "<1713211485-9021-84-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713211485-9021-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com>\n <1713211485-9021-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Move location of __rte_aligned(a) to new conventional location. The new\nplacement between {struct,union} and the tag allows the desired\nalignment to be imparted on the type regardless of the toolchain being\nused for both C and C++. Additionally, it avoids confusion by Doxygen\nwhen generating documentation.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n drivers/bus/dpaa/base/qbman/qman.c | 3 +--\n drivers/bus/dpaa/include/fsl_bman.h | 4 ++--\n drivers/bus/dpaa/include/fsl_qman.h | 20 ++++++++++----------\n 3 files changed, 13 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c\nindex 83db0a5..6d2fbdc 100644\n--- a/drivers/bus/dpaa/base/qbman/qman.c\n+++ b/drivers/bus/dpaa/base/qbman/qman.c\n@@ -95,8 +95,7 @@ struct qman_portal {\n \t * to 2 ** 10 to ensure DQRR index calculations based shadow copy\n \t * address (6 bits for address shift + 4 bits for the DQRR size).\n \t */\n-\tstruct qm_dqrr_entry shadow_dqrr[QM_DQRR_SIZE]\n-\t\t __rte_aligned(1024);\n+\talignas(1024) struct qm_dqrr_entry shadow_dqrr[QM_DQRR_SIZE];\n #endif\n };\n \ndiff --git a/drivers/bus/dpaa/include/fsl_bman.h b/drivers/bus/dpaa/include/fsl_bman.h\nindex 6719a4e..34d7eb3 100644\n--- a/drivers/bus/dpaa/include/fsl_bman.h\n+++ b/drivers/bus/dpaa/include/fsl_bman.h\n@@ -41,7 +41,7 @@ static inline void bman_depletion_fill(struct bman_depletion *c)\n * pool id specific to this buffer is needed (BM_RCR_VERB_CMD_BPID_MULTI,\n * BM_MCC_VERB_ACQUIRE), the 'bpid' field is used.\n */\n-struct bm_buffer {\n+struct __rte_aligned(8) bm_buffer {\n \tunion {\n \t\tstruct {\n #if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__\n@@ -67,7 +67,7 @@ struct bm_buffer {\n \t\t};\n \t\tu64 opaque;\n \t};\n-} __rte_aligned(8);\n+};\n static inline u64 bm_buffer_get64(const struct bm_buffer *buf)\n {\n \treturn buf->addr;\ndiff --git a/drivers/bus/dpaa/include/fsl_qman.h b/drivers/bus/dpaa/include/fsl_qman.h\nindex 5953309..acdfb45 100644\n--- a/drivers/bus/dpaa/include/fsl_qman.h\n+++ b/drivers/bus/dpaa/include/fsl_qman.h\n@@ -124,7 +124,7 @@ enum qm_fd_format {\n #define QM_FD_COMPOUND\tQM_FD_FORMAT_COMPOUND\n \n /* \"Frame Descriptor (FD)\" */\n-struct qm_fd {\n+struct __rte_aligned(8) qm_fd {\n \tunion {\n \t\tstruct {\n #if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__\n@@ -200,7 +200,7 @@ struct qm_fd {\n \t\tu32 cmd;\n \t\tu32 status;\n \t};\n-} __rte_aligned(8);\n+};\n #define QM_FD_DD_NULL\t\t0x00\n #define QM_FD_PID_MASK\t\t0x3f\n static inline u64 qm_fd_addr_get64(const struct qm_fd *fd)\n@@ -330,9 +330,9 @@ struct __rte_aligned(8) qm_dqrr_entry {\n \n /* \"ERN Message Response\" */\n /* \"FQ State Change Notification\" */\n-struct qm_mr_entry {\n+struct __rte_aligned(8) qm_mr_entry {\n \tunion {\n-\t\tstruct {\n+\t\talignas(8) struct {\n \t\t\tu8 verb;\n \t\t\tu8 dca;\n \t\t\tu16 seqnum;\n@@ -341,8 +341,8 @@ struct qm_mr_entry {\n \t\t\tu32 fqid;\t/* 24-bit */\n \t\t\tu32 tag;\n \t\t\tstruct qm_fd fd; /* this has alignment 8 */\n-\t\t} __packed __rte_aligned(8) ern;\n-\t\tstruct {\n+\t\t} __packed ern;\n+\t\talignas(8) struct {\n \t\t\tu8 verb;\n #if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__\n \t\t\tu8 colour:2;\t/* See QM_MR_DCERN_COLOUR_* */\n@@ -359,18 +359,18 @@ struct qm_mr_entry {\n \t\t\tu32 fqid;\t/* 24-bit */\n \t\t\tu32 tag;\n \t\t\tstruct qm_fd fd; /* this has alignment 8 */\n-\t\t} __packed __rte_aligned(8) dcern;\n-\t\tstruct {\n+\t\t} __packed dcern;\n+\t\talignas(8) struct {\n \t\t\tu8 verb;\n \t\t\tu8 fqs;\t\t/* Frame Queue Status */\n \t\t\tu8 __reserved1[6];\n \t\t\tu32 fqid;\t/* 24-bit */\n \t\t\tu32 contextB;\n \t\t\tu8 __reserved2[16];\n-\t\t} __packed __rte_aligned(8) fq;\t/* FQRN/FQRNI/FQRL/FQPN */\n+\t\t} __packed fq;\t/* FQRN/FQRNI/FQRL/FQPN */\n \t};\n \tu8 __reserved2[32];\n-} __packed __rte_aligned(8);\n+} __packed;\n #define QM_MR_VERB_VBIT\t\t\t0x80\n /*\n * ERNs originating from direct-connect portals (\"dcern\") use 0x20 as a verb\n", "prefixes": [ "v2", "83/83" ] }