Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139281/?format=api
{ "id": 139281, "url": "http://patches.dpdk.org/api/patches/139281/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240415123548.705412-1-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240415123548.705412-1-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240415123548.705412-1-ciara.power@intel.com", "date": "2024-04-15T12:35:48", "name": "crypto: fix crypto callbacks macro", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "1e486edeffdd797a29f566e83e0c854f97bfe805", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240415123548.705412-1-ciara.power@intel.com/mbox/", "series": [ { "id": 31740, "url": "http://patches.dpdk.org/api/series/31740/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31740", "date": "2024-04-15T12:35:48", "name": "crypto: fix crypto callbacks macro", "version": 1, "mbox": "http://patches.dpdk.org/series/31740/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139281/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3190B43E7A;\n\tMon, 15 Apr 2024 14:36:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7123E4029E;\n\tMon, 15 Apr 2024 14:36:02 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.10])\n by mails.dpdk.org (Postfix) with ESMTP id 6D88A400EF;\n Mon, 15 Apr 2024 14:36:00 +0200 (CEST)", "from orviesa005.jf.intel.com ([10.64.159.145])\n by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2024 05:35:59 -0700", "from silpixa00401797.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.113])\n by orviesa005.jf.intel.com with ESMTP; 15 Apr 2024 05:35:58 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713184561; x=1744720561;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=3MCDL5RpCeIEu9SztzJIAUPyvDSghVkVcXXUzESow6s=;\n b=Ku7lNnp3YzkMYelUEjAkupG/kmT3lunYF5v614EIMi2kgAEegrwvh+++\n gs23CELtkNw40mpX8+zgqlDn1jI08CdKVe6nNcrIsAX/lJJxcQmxsNjwN\n hHDvWZwSwhqLp/HTW8TJZry5deutvyefWPv1t9RMZi4CiLrZx/yTb4WIU\n eztf4GdWfzhknJLPqTxerHXpE2U5BlXqpcUFGgigrIZX701OCob8rtttg\n nD1fWg9Qa9YxDvr/t/QlELwe0O/2N5H8RqUWE17XWZaXjCP9NDxyDeWY8\n OoIHXYaJzrMx9cFfDqTADOtxgWRY2VWdPvyIxWvOrEyhT9Al+3fq1MGPT w==;", "X-CSE-ConnectionGUID": [ "f7EKEpIuRt60QGC6MOWXwg==", "bn5VF0K7SvqyOgNyPy/Jvg==" ], "X-CSE-MsgGUID": [ "xdJyKkdfR96EIuLTB6/LPw==", "8Zs+suXTR7CI5NzUysCKSg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11044\"; a=\"19964131\"", "E=Sophos;i=\"6.07,203,1708416000\"; d=\"scan'208\";a=\"19964131\"", "E=Sophos;i=\"6.07,203,1708416000\"; d=\"scan'208\";a=\"26695397\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>, abhinandan.gujjar@intel.com,\n stable@dpdk.org, Akhil Goyal <gakhil@marvell.com>,\n Fan Zhang <fanzhang.oss@gmail.com>", "Subject": "[PATCH] crypto: fix crypto callbacks macro", "Date": "Mon, 15 Apr 2024 12:35:48 +0000", "Message-Id": "<20240415123548.705412-1-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The crypto callbacks macro is being used with ifdef instead of if,\nso when the config file value is changed to 0 to disable, the code is\nstill being compiled in.\n\nFixes: 1c3ffb95595e (\"cryptodev: add enqueue and dequeue callbacks\")\nCc: abhinandan.gujjar@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n lib/cryptodev/rte_cryptodev.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h\nindex 00ba6a234a..357d4bcf9c 100644\n--- a/lib/cryptodev/rte_cryptodev.h\n+++ b/lib/cryptodev/rte_cryptodev.h\n@@ -1909,7 +1909,7 @@ rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,\n \n \tnb_ops = fp_ops->dequeue_burst(qp, ops, nb_ops);\n \n-#ifdef RTE_CRYPTO_CALLBACKS\n+#if RTE_CRYPTO_CALLBACKS\n \tif (unlikely(fp_ops->qp.deq_cb != NULL)) {\n \t\tstruct rte_cryptodev_cb_rcu *list;\n \t\tstruct rte_cryptodev_cb *cb;\n@@ -1976,7 +1976,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,\n \n \tfp_ops = &rte_crypto_fp_ops[dev_id];\n \tqp = fp_ops->qp.data[qp_id];\n-#ifdef RTE_CRYPTO_CALLBACKS\n+#if RTE_CRYPTO_CALLBACKS\n \tif (unlikely(fp_ops->qp.enq_cb != NULL)) {\n \t\tstruct rte_cryptodev_cb_rcu *list;\n \t\tstruct rte_cryptodev_cb *cb;\n", "prefixes": [] }