Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139280/comments/169661/?format=api
{ "id": 169661, "web_url": "http://patches.dpdk.org/comment/169661/", "msgid": "<CA+sj1i9s4XdnP-NQbDAfLjhbyDTc6Bkfj3JrrvNqsobxNmT4Qg@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CA+sj1i9s4XdnP-NQbDAfLjhbyDTc6Bkfj3JrrvNqsobxNmT4Qg@mail.gmail.com", "date": "2024-04-25T14:03:04", "subject": "Re: [PATCH v4] lib/hash: add defer queue reclaim API", "submitter": { "id": 3080, "url": "http://patches.dpdk.org/api/people/3080/?format=api", "name": "Abdullah Ömer Yamaç", "email": "aomeryamac@gmail.com" }, "content": "Thanks for the comments. This is due to the tab size, and I will fix them.\n\nOn Wed, Apr 24, 2024 at 12:24 AM Stephen Hemminger <\nstephen@networkplumber.org> wrote:\n\n> On Mon, 15 Apr 2024 11:26:02 +0000\n> Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:\n>\n> > + ret = rte_rcu_qsbr_dq_reclaim(h->dq,\n> h->hash_rcu_cfg->max_reclaim_size,\n> > + freed,\n> pending, available);\n>\n> Indention here is odd. I would expect \"freed,\" to line up right under\n> h->dq.\n> Since rte_rcu_qsbrs_dq_reclaim logs error on invalid parameters, this\n> function should as well.\n>\n> Total indent fixes:\n>\n> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\n> index 4a44aadd9a..e1ea810024 100644\n> --- a/lib/hash/rte_cuckoo_hash.c\n> +++ b/lib/hash/rte_cuckoo_hash.c\n> @@ -1590,21 +1590,20 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct\n> rte_hash_rcu_config *cfg)\n>\n> int\n> rte_hash_rcu_qsbr_dq_reclaim(struct rte_hash *h, unsigned int *freed,\n> - unsigned int *pending, unsigned\n> int *available)\n> + unsigned int *pending, unsigned int\n> *available)\n> {\n> int ret;\n>\n> if (h == NULL || h->hash_rcu_cfg == NULL) {\n> + HASH_LOG(ERR, \"Invalid input parameter\");\n> rte_errno = EINVAL;\n> return 1;\n> }\n>\n> ret = rte_rcu_qsbr_dq_reclaim(h->dq,\n> h->hash_rcu_cfg->max_reclaim_size,\n> - freed,\n> pending, available);\n> + freed, pending, available);\n> if (ret != 0) {\n> - HASH_LOG(ERR,\n> - \"%s: could not reclaim the defer queue in\n> hash table\",\n> - __func__);\n> + HASH_LOG(ERR, \"%s: could not reclaim the defer queue in\n> hash table\", __func__);\n> return 1;\n> }\n>\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66FCF43F05;\n\tThu, 25 Apr 2024 16:03:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 52BF7435F4;\n\tThu, 25 Apr 2024 16:03:17 +0200 (CEST)", "from mail-oa1-f50.google.com (mail-oa1-f50.google.com\n [209.85.160.50]) by mails.dpdk.org (Postfix) with ESMTP id D8E6340284\n for <dev@dpdk.org>; Thu, 25 Apr 2024 16:03:15 +0200 (CEST)", "by mail-oa1-f50.google.com with SMTP id\n 586e51a60fabf-2330f85c2ebso674044fac.1\n for <dev@dpdk.org>; Thu, 25 Apr 2024 07:03:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1714053795; x=1714658595; darn=dpdk.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=kV9cChnFCsPiLMFpWMQezFwfbVBRgD+OAvDi4W9LrE8=;\n b=XCUyO/qqFvi7jqJYb7UwuQUe+LInoj6n8aAq3iN1KCDt/e+/RVPDMju/vvi3S8HlDj\n phCamoOEYBzRcUJ/pAo6PwFQwxpicNx/qnyonnLlbFLv3xdiq4EjZCfxp8uxhdzc0J+/\n Z1pr+h0ei5AYTFDKkshBwrqzG0OPNeaQ79sWmGOTg3V1R5c6dJ+524lVLsZiaJDH6JCe\n bTQ/jfepcU5Cm4CXR/WfXc5m2yYfOMRhM2pZdoiMq3nrZcl8wtKgZ31dVoypoXI/riGE\n 8mJlyPdvGDpuEaLRZqE/WOy7wI7inHOrbN6YIfu5xAaPDcPXjQYYXqtLjqZin5Hz9BVe\n itgg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714053795; x=1714658595;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=kV9cChnFCsPiLMFpWMQezFwfbVBRgD+OAvDi4W9LrE8=;\n b=bo5jBCc863rT0TCxs3c0OL8g99n98i3tnF3R3ALp6Tf/D/HpZtZutKRrm8zIbkzQer\n Xq2YCLPIAOACuy6rVoJrh2TY1vy2c0ep88Uv/ndvVCFe3v6aEYyGwjJHHfapOSgRvy8N\n nSOVn2Rzziyb/GXuqLXa9l7zaYZ++uudcODP5hvtmKIcwpFDS4FGHPEyF8omLSaEsusi\n 0ljJqsIm1TXqf2wMm2ClXl0UI9oTVUJH37wt8IXI4BuMSvOotsO6LYYQG9WUac/ySBw/\n Izp7Oxa5v1dvQpQ3cuBcScHnZ2UKRI5hNK43kNCQTmK8gOzOGdl4p0BXktPyppMYGMdD\n U7UQ==", "X-Gm-Message-State": "AOJu0YwwscY3J9dSuYqiKuFAQ7Tgu0tRa4XHRv3O/9KooaQAfZ7to3F5\n sLvVr06Gx+wQQZVCV8EKXrGrBzoeiarUuhWMJpcLNM/Ib8wIEZvWBSTcf+1UCup+BT27+GF91yR\n v/qKw1WcFvaPIJ6zZEONCby1+dolxjQ==", "X-Google-Smtp-Source": "\n AGHT+IEhoXnk7i10AGWWIUpxIo29zoj7lkpfA7dE1oM3DIzUNGyYe5bNeOoihOFvRQRdjiFV3bh/WVr+I2qLTq24zWc=", "X-Received": "by 2002:a05:6870:a691:b0:229:ce58:477a with SMTP id\n i17-20020a056870a69100b00229ce58477amr6510142oam.19.1714053795089; Thu, 25\n Apr 2024 07:03:15 -0700 (PDT)", "MIME-Version": "1.0", "References": "\n <CA+sj1i9vXMtxeDnM9bzgnVyNTa-CCRyEvPP6hcbfLbuegxLRzg@mail.gmail.com>\n <20240415112602.690972-1-aomeryamac@gmail.com>\n <20240423142432.0fcedf20@hermes.local>", "In-Reply-To": "<20240423142432.0fcedf20@hermes.local>", "From": "=?utf-8?b?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= <aomeryamac@gmail.com>", "Date": "Thu, 25 Apr 2024 17:03:04 +0300", "Message-ID": "\n <CA+sj1i9s4XdnP-NQbDAfLjhbyDTc6Bkfj3JrrvNqsobxNmT4Qg@mail.gmail.com>", "Subject": "Re: [PATCH v4] lib/hash: add defer queue reclaim API", "To": "Stephen Hemminger <stephen@networkplumber.org>", "Cc": "dev@dpdk.org", "Content-Type": "multipart/alternative; boundary=\"0000000000009523870616ec3fbf\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }