Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139201/?format=api
{ "id": 139201, "url": "http://patches.dpdk.org/api/patches/139201/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240409034237.433270-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240409034237.433270-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240409034237.433270-3-stephen@networkplumber.org", "date": "2024-04-09T03:40:31", "name": "[v8,2/8] net/tap: remove unused fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0cc4bbcc8a2f01af5abe1738fa093291b7f3d4c3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240409034237.433270-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31709, "url": "http://patches.dpdk.org/api/series/31709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31709", "date": "2024-04-09T03:40:29", "name": "net/tap: cleanups and fix BPF support", "version": 8, "mbox": "http://patches.dpdk.org/series/31709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139201/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8FAFF43DD9;\n\tTue, 9 Apr 2024 05:42:57 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DC44C40684;\n\tTue, 9 Apr 2024 05:42:45 +0200 (CEST)", "from mail-oo1-f41.google.com (mail-oo1-f41.google.com\n [209.85.161.41]) by mails.dpdk.org (Postfix) with ESMTP id 5B14F402B9\n for <dev@dpdk.org>; Tue, 9 Apr 2024 05:42:41 +0200 (CEST)", "by mail-oo1-f41.google.com with SMTP id\n 006d021491bc7-5aa2bd6f651so1492708eaf.0\n for <dev@dpdk.org>; Mon, 08 Apr 2024 20:42:41 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n gm24-20020a17090b101800b0029de90f4d44sm9238197pjb.9.2024.04.08.20.42.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 08 Apr 2024 20:42:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712634160;\n x=1713238960; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;\n b=0G2JLpP6vc4ogUZzEszs3j8rzPrXxxkBAfI6ySUm+m/zo8ktNABg2B99uDFuFi6WQA\n D0M9CJ2b3upP1OMX/TRkWAzr/ajeDvf3XmON64kZl6Xq9tQ0C/l5M0Bk3o6ynKg3cGX4\n ViTJ68h7wJHVHaJZnpHOiwXVfGVE82e0IQEudOndKgDARw6XP+t0im023TxkSkYKMySD\n FC0cBL8lU74JyknT9BEIC3Qwb01XXhzPQTCP83HdU2jQAnQqhl63hgqIrRGMSUS1NGYM\n HGvlU/jm46uFGbJCMfYWgF8mNH40TBVnF5mEi5yYD2rYdDiT816FFxOoAmpGaa2/Gkyb\n JFGA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712634160; x=1713238960;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;\n b=iQ2L3j9rMYt514RcFCJr0+JVlhRQH/Qzy42Eb7IekEv7X66J1Tp65ctvGUJ8sSfZ9s\n W2sBHbRnaDNfnlcKnntF9GvLUqUKpW7bb3p/35LbG91+21oQFx9Yi30Md/wvNpoMyfnK\n JTZe6LTFi+CpGDrkrWKRKps4uKJxUzV0cGX9ym8D+rvTW0TKakhqn+yKydA6F4/QIif6\n B6vxuoemDbhpn+7i1giEBs/37erDv+ucKDaEEDlm0Pf9rwrwjvoZ4bNahv+p9iRE4cHU\n cIbHzmAJBM9fERl2eNk73KfKcLOkvrXf0gDcHlrK3qy2hIFyqSbLirAi6M690BZVStaY\n e/wg==", "X-Gm-Message-State": "AOJu0Yxw8iPvqs1iPlO3PWRPrVCTSNvPZPm29HymQL7vIs5I8vNlQzWN\n NAUlcDWmXGa/CEGgPAW5EKL2vi6rvTXZeRbgtFu2eKI92jcF7ZIs+4ID5gstr33kRpFr6WtG4rU\n dZ9M=", "X-Google-Smtp-Source": "\n AGHT+IH+9mJtB5Le1pGkRESrZR2E6Rp96UeQOzl/xhykF1KK5Fa7nlC1oc0VyBw1q/L3q5mEbBEztQ==", "X-Received": "by 2002:a05:6358:7c16:b0:183:90a2:f4ce with SMTP id\n p22-20020a0563587c1600b0018390a2f4cemr10661261rwf.0.1712634160647;\n Mon, 08 Apr 2024 20:42:40 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v8 2/8] net/tap: remove unused fields", "Date": "Mon, 8 Apr 2024 20:40:31 -0700", "Message-ID": "<20240409034237.433270-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240409034237.433270-1-stephen@networkplumber.org>", "References": "<20240130034925.44869-1-stephen@networkplumber.org>\n <20240409034237.433270-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The driver doesn't support these other hash types, and there\nis no reason to implement these in future. The rss_flows list\nwas set but never used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.h | 4 +---\n drivers/net/tap/tap_flow.c | 1 -\n drivers/net/tap/tap_rss.h | 6 ------\n 3 files changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h\nindex dc8201020b..1bcf92ce80 100644\n--- a/drivers/net/tap/rte_eth_tap.h\n+++ b/drivers/net/tap/rte_eth_tap.h\n@@ -77,14 +77,12 @@ struct pmd_internals {\n \tint ioctl_sock; /* socket for ioctl calls */\n \tint nlsk_fd; /* Netlink socket fd */\n \tint flow_isolate; /* 1 if flow isolation is enabled */\n-\tint flower_support; /* 1 if kernel supports, else 0 */\n-\tint flower_vlan_support; /* 1 if kernel supports, else 0 */\n \tint rss_enabled; /* 1 if RSS is enabled, else 0 */\n \tint persist;\t\t\t /* 1 if keep link up, else 0 */\n \t/* implicit rules set when RSS is enabled */\n \tint map_fd; /* BPF RSS map fd */\n \tint bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */\n-\tLIST_HEAD(tap_rss_flows, rte_flow) rss_flows;\n+\n \tLIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */\n \t/* implicit rte_flow rules set when a remote device is active */\n \tLIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows;\ndiff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c\nindex a78fd50cd4..8fccd599f0 100644\n--- a/drivers/net/tap/tap_flow.c\n+++ b/drivers/net/tap/tap_flow.c\n@@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd,\n \t\t\t\terrno, strerror(errno));\n \t\t\treturn err;\n \t\t}\n-\t\tLIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next);\n \t}\n \n \tpmd->rss_enabled = 1;\ndiff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h\nindex dff46a012f..8766ffc244 100644\n--- a/drivers/net/tap/tap_rss.h\n+++ b/drivers/net/tap/tap_rss.h\n@@ -21,12 +21,6 @@ enum hash_field {\n \tHASH_FIELD_IPV4_L3_L4,\t/* IPv4 src/dst addr + L4 src/dst ports */\n \tHASH_FIELD_IPV6_L3,\t/* IPv6 src/dst addr */\n \tHASH_FIELD_IPV6_L3_L4,\t/* IPv6 src/dst addr + L4 src/dst ports */\n-\tHASH_FIELD_L2_SRC,\t/* Ethernet src addr */\n-\tHASH_FIELD_L2_DST,\t/* Ethernet dst addr */\n-\tHASH_FIELD_L3_SRC,\t/* L3 src addr */\n-\tHASH_FIELD_L3_DST,\t/* L3 dst addr */\n-\tHASH_FIELD_L4_SRC,\t/* TCP/UDP src ports */\n-\tHASH_FIELD_L4_DST,\t/* TCP/UDP dst ports */\n };\n \n struct rss_key {\n", "prefixes": [ "v8", "2/8" ] }