Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139183/?format=api
{ "id": 139183, "url": "http://patches.dpdk.org/api/patches/139183/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240408151617.2095307-1-shiyangx.he@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240408151617.2095307-1-shiyangx.he@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240408151617.2095307-1-shiyangx.he@intel.com", "date": "2024-04-08T15:16:17", "name": "net/ice: fix EIPT check is always true", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a27dbaf63843813f8dabbc8ee5f18d0b2414e116", "submitter": { "id": 2927, "url": "http://patches.dpdk.org/api/people/2927/?format=api", "name": "Shiyang He", "email": "shiyangx.he@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240408151617.2095307-1-shiyangx.he@intel.com/mbox/", "series": [ { "id": 31701, "url": "http://patches.dpdk.org/api/series/31701/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31701", "date": "2024-04-08T15:16:17", "name": "net/ice: fix EIPT check is always true", "version": 1, "mbox": "http://patches.dpdk.org/series/31701/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139183/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139183/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D894143DA6;\n\tMon, 8 Apr 2024 09:55:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9F0C240289;\n\tMon, 8 Apr 2024 09:55:26 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.19])\n by mails.dpdk.org (Postfix) with ESMTP id 735B640041;\n Mon, 8 Apr 2024 09:55:24 +0200 (CEST)", "from fmviesa010.fm.intel.com ([10.60.135.150])\n by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2024 00:55:24 -0700", "from unknown (HELO dpdk..) ([10.239.252.115])\n by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2024 00:55:22 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1712562925; x=1744098925;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=qlNKdD3rlTJqXpACSp4g3veudHB0lfWVYFzwMBAEP2A=;\n b=GUGwdtFAg9k+tiKP8JXWMYJFm+OhB3MjAekKy2kvzsspYCMFLzqPFeeX\n hO3SU6k3Zx/m7/BI3ejRhUH6EKaMkTewDmhSBvmPFXhGSEYwZhUzQcPF2\n YtHhVl+R00CaE5btZwofjC0e3Bu00t/3SSUqdMCuWdCSyRf/PIozISQR3\n LT3iufd01g+03l3W8r6zN+bQZhOKfYDGYXl0wplqHb60az1bEc1ieUNZt\n lm3CS363Ugag3UpR3DEWRw6/8Ae1SYBkD2Gk+Fo285ZCp5/m5XrwOqgc+\n asv5BhFbF/T0X2TSMQrqLpRkDbkZ0qJDNF996JCVkYcvz5jpSoZdTz2Uw A==;", "X-CSE-ConnectionGUID": [ "AytfgYyYT5arJM+ZWDS/xw==", "DlNTGPRbTHmROGzJMukgWw==" ], "X-CSE-MsgGUID": [ "hCtqbJx/TGaJcdBMptHRqA==", "bgXiiqbjQk+RxmgDjnUK+A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11037\"; a=\"7692681\"", "E=Sophos;i=\"6.07,186,1708416000\";\n d=\"scan'208\";a=\"7692681\"", "E=Sophos;i=\"6.07,186,1708416000\"; d=\"scan'208\";a=\"19762990\"" ], "X-ExtLoop1": "1", "From": "Shiyang He <shiyangx.he@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Shiyang He <shiyangx.he@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Murphy Yang <murphyx.yang@intel.com>", "Subject": "[PATCH] net/ice: fix EIPT check is always true", "Date": "Mon, 8 Apr 2024 15:16:17 +0000", "Message-Id": "<20240408151617.2095307-1-shiyangx.he@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When enabling hardware outer UDP TX offload checksum, the EIPT judgment\nis always true because ICE_TX_CTX_EIPT_NONE = 0x0.\n\nThis patch fixes it by checking the non-zero EIPT flag.\n\nFixes: 2ed011776334 (\"net/ice: fix outer UDP Tx checksum offload\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shiyang He <shiyangx.he@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex 13aabe97a5..3e2264de7d 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -2751,7 +2751,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,\n \t * Calculate the tunneling UDP checksum.\n \t * Shall be set only if L4TUNT = 01b and EIPT is not zero\n \t */\n-\tif (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&\n+\tif ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE &&\n \t\t(*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING) &&\n \t\t(ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM))\n \t\t*cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;\n", "prefixes": [] }