Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139180/?format=api
{ "id": 139180, "url": "http://patches.dpdk.org/api/patches/139180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240407114554.1789-2-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240407114554.1789-2-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240407114554.1789-2-shaibran@amazon.com", "date": "2024-04-07T11:45:54", "name": "[1/1] net/ena/base: fix metrics excessive memory consumption", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "513b25a8879a22e5d5c5c65bd5ee25fe48d44e5e", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240407114554.1789-2-shaibran@amazon.com/mbox/", "series": [ { "id": 31698, "url": "http://patches.dpdk.org/api/series/31698/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31698", "date": "2024-04-07T11:45:53", "name": "net/ena/base: bug fix for 23.11 stable only", "version": 1, "mbox": "http://patches.dpdk.org/series/31698/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139180/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C96543E21;\n\tSun, 7 Apr 2024 13:46:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1218440647;\n\tSun, 7 Apr 2024 13:46:09 +0200 (CEST)", "from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com\n [72.21.196.25])\n by mails.dpdk.org (Postfix) with ESMTP id 1D174402E0;\n Sun, 7 Apr 2024 13:46:06 +0200 (CEST)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-2101.iad2.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2024 11:46:04 +0000", "from EX19MTAEUC002.ant.amazon.com [10.0.17.79:13065]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.20.190:2525]\n with esmtp (Farcaster)\n id d288f403-a6ec-4442-8f08-7d294bf74375; Sun, 7 Apr 2024 11:46:01 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUC002.ant.amazon.com (10.252.51.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Sun, 7 Apr 2024 11:46:01 +0000", "from EX19MTAUEC001.ant.amazon.com (10.252.135.222) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Sun, 7 Apr 2024 11:46:01 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.12) by\n mail-relay.amazon.com (10.252.135.200) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Sun, 7 Apr 2024 11:45:59 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1712490367; x=1744026367;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=Xr8WbupP/zd70vJ3kwbdxVVSwUsJ9ukayozEoO36Q2Q=;\n b=Mx8oL72sCobjFmstRqFjeowkjk49gHJ2Gczh7ehWfwILTutm/QLq35uO\n vo/dvjqZgdhCS0v7dLeAut87yl781I6zcfoFzTpzFkPnVAUIWQeBQXkhw\n HxsCwEV3wwRSM6HA6X5eDnpx9OMKO4W47uMkU5ydzdlug3zY99Y5Af8p0 U=;", "X-IronPort-AV": "E=Sophos;i=\"6.07,185,1708387200\"; d=\"scan'208\";a=\"393121239\"", "X-Farcaster-Flow-ID": "d288f403-a6ec-4442-8f08-7d294bf74375", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>, <bluca@debian.org>,\n <christian.ehrhardt@canonical.com>, <xuemingl@nvidia.com>,\n <ktraynor@redhat.com>", "CC": "<stable@dpdk.org>, <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH 1/1] net/ena/base: fix metrics excessive memory consumption", "Date": "Sun, 7 Apr 2024 14:45:54 +0300", "Message-ID": "<20240407114554.1789-2-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240407114554.1789-1-shaibran@amazon.com>", "References": "<20240407114554.1789-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\n[ upstream commit c8a1898f82f8c04cbe1d3e2d0eec0705386c23f7 ]\n\nThe driver accidentally allocates a huge memory\nbuffer for the customer metrics because it uses\nan uninitialized variable for the buffer length.\nThis can lead to excessive memory footprint for\nthe driver which can even fail to initialize in\ncase of insufficient memory.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\nFixes: f73f53f7dc7a (\"net/ena: upgrade HAL\")\nBugzilla ID: 1400\nCc: stable@dpdk.org\n---\n drivers/net/ena/base/ena_com.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex 6953a1fa33..8ae7dcf48e 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -3134,16 +3134,18 @@ int ena_com_allocate_debug_area(struct ena_com_dev *ena_dev,\n int ena_com_allocate_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n {\n \tstruct ena_customer_metrics *customer_metrics = &ena_dev->customer_metrics;\n+\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\tcustomer_metrics->buffer_virt_addr = NULL;\n \n \tENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,\n \t\t\t customer_metrics->buffer_len,\n \t\t\t customer_metrics->buffer_virt_addr,\n \t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t customer_metrics->buffer_dma_handle);\n-\tif (unlikely(customer_metrics->buffer_virt_addr == NULL))\n+\tif (unlikely(customer_metrics->buffer_virt_addr == NULL)) {\n+\t\tcustomer_metrics->buffer_len = 0;\n \t\treturn ENA_COM_NO_MEM;\n-\n-\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "1/1" ] }