Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139170/?format=api
{ "id": 139170, "url": "http://patches.dpdk.org/api/patches/139170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405211745.699697-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405211745.699697-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405211745.699697-4-stephen@networkplumber.org", "date": "2024-04-05T21:14:55", "name": "[v6,3/8] net/tap: remove unused fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0cc4bbcc8a2f01af5abe1738fa093291b7f3d4c3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405211745.699697-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 31694, "url": "http://patches.dpdk.org/api/series/31694/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31694", "date": "2024-04-05T21:14:52", "name": "net/tap: cleanup and fix BPF flow support", "version": 6, "mbox": "http://patches.dpdk.org/series/31694/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139170/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C0A543E0E;\n\tFri, 5 Apr 2024 23:18:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4622F4069D;\n\tFri, 5 Apr 2024 23:18:02 +0200 (CEST)", "from mail-pg1-f178.google.com (mail-pg1-f178.google.com\n [209.85.215.178])\n by mails.dpdk.org (Postfix) with ESMTP id F3FDB4028A\n for <dev@dpdk.org>; Fri, 5 Apr 2024 23:17:59 +0200 (CEST)", "by mail-pg1-f178.google.com with SMTP id\n 41be03b00d2f7-5ce6b5e3c4eso1683443a12.2\n for <dev@dpdk.org>; Fri, 05 Apr 2024 14:17:59 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n r32-20020a17090a43a300b002a2f1e6f50bsm2137521pjg.1.2024.04.05.14.17.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 05 Apr 2024 14:17:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712351879;\n x=1712956679; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;\n b=PPSIXYZkPOaqu46Se4KMrh1dT2giGx7i2BABLE3a00G54476Z32D0AGe36KZUe5Fha\n Mayix+J1hdY5KZQ8iEtSxnGWWRh44vMygTTQOEWK0ysVx+3N87NyStrLXXrb0sbzn0Hr\n JUXCaXCCTuPzty5zFKpukDzmgh0GsqXGDOYDdH5XAuV10TjHNsyuVZXZhElxSEKCtotV\n jCkQxLdKHmo7/UfGVBDkP2MKE0k8XP1ijHmeJHTgGa6fw6oEUV4R4rL4d2oteDYwFuZg\n iqX0nUt47Wr+iPt68dZx1toWrcEMZkrgipYcMTvvEwdiFrr8pA20Yo7oGy2LiLRIXviQ\n GVuQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712351879; x=1712956679;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;\n b=oWFWmHLxLDvuBA+jVH7FX98QHcPTEk6vqqVLjJvHIwg8L1jxm20gq9wi8bUEEPze8V\n zsmr4Lvqrs/O9K6Nc7lvjscFhx4qAXSAWbkMOQHiHc5LNrdToZeRwoUPyCNricyzGO4D\n R5mip/mbDlPagCF9r8A1WbBfNgOWhJgnMJXsoAMOFCr9umJTrpHMLcDB3k5KUYskGAz2\n qrE4yqfhif++F4KbnCMvFwtGGcJZrER2cDgvjL8gXqF2w95avCX3chVKPPrz8ULIi8ai\n 7c6It7ofIuN6e7adTKWnEOapredlSNT04RSuRHBa4tY8yA/IbacKdskmeI5DLRbB9cLO\n xWbA==", "X-Gm-Message-State": "AOJu0YyJjvEmNHtZb//FtDAA/JniLVJ1KQ7tDnS80WdzpH+Z+QQLtkeB\n WuLmfq96jUgphL9q++e83SMdDy2GyIh4AG3WOXP0XWWY6QfDdTceGmE3+Z/gQYR5aF7u/Px8OYi\n AaeAr0Q==", "X-Google-Smtp-Source": "\n AGHT+IHAQnU6CANJQMUhXTaCveQbht5mZrV6D75LHrt0zl8AGMX7+5bnyasJVebYwNzQT5IOd2zD/w==", "X-Received": "by 2002:a17:90a:bf04:b0:2a2:21a0:b151 with SMTP id\n c4-20020a17090abf0400b002a221a0b151mr2570858pjs.20.1712351879158;\n Fri, 05 Apr 2024 14:17:59 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v6 3/8] net/tap: remove unused fields", "Date": "Fri, 5 Apr 2024 14:14:55 -0700", "Message-ID": "<20240405211745.699697-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240405211745.699697-1-stephen@networkplumber.org>", "References": "<20240130034925.44869-1-stephen@networkplumber.org>\n <20240405211745.699697-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The driver doesn't support these other hash types, and there\nis no reason to implement these in future. The rss_flows list\nwas set but never used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.h | 4 +---\n drivers/net/tap/tap_flow.c | 1 -\n drivers/net/tap/tap_rss.h | 6 ------\n 3 files changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h\nindex dc8201020b..1bcf92ce80 100644\n--- a/drivers/net/tap/rte_eth_tap.h\n+++ b/drivers/net/tap/rte_eth_tap.h\n@@ -77,14 +77,12 @@ struct pmd_internals {\n \tint ioctl_sock; /* socket for ioctl calls */\n \tint nlsk_fd; /* Netlink socket fd */\n \tint flow_isolate; /* 1 if flow isolation is enabled */\n-\tint flower_support; /* 1 if kernel supports, else 0 */\n-\tint flower_vlan_support; /* 1 if kernel supports, else 0 */\n \tint rss_enabled; /* 1 if RSS is enabled, else 0 */\n \tint persist;\t\t\t /* 1 if keep link up, else 0 */\n \t/* implicit rules set when RSS is enabled */\n \tint map_fd; /* BPF RSS map fd */\n \tint bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */\n-\tLIST_HEAD(tap_rss_flows, rte_flow) rss_flows;\n+\n \tLIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */\n \t/* implicit rte_flow rules set when a remote device is active */\n \tLIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows;\ndiff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c\nindex a78fd50cd4..8fccd599f0 100644\n--- a/drivers/net/tap/tap_flow.c\n+++ b/drivers/net/tap/tap_flow.c\n@@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd,\n \t\t\t\terrno, strerror(errno));\n \t\t\treturn err;\n \t\t}\n-\t\tLIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next);\n \t}\n \n \tpmd->rss_enabled = 1;\ndiff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h\nindex dff46a012f..8766ffc244 100644\n--- a/drivers/net/tap/tap_rss.h\n+++ b/drivers/net/tap/tap_rss.h\n@@ -21,12 +21,6 @@ enum hash_field {\n \tHASH_FIELD_IPV4_L3_L4,\t/* IPv4 src/dst addr + L4 src/dst ports */\n \tHASH_FIELD_IPV6_L3,\t/* IPv6 src/dst addr */\n \tHASH_FIELD_IPV6_L3_L4,\t/* IPv6 src/dst addr + L4 src/dst ports */\n-\tHASH_FIELD_L2_SRC,\t/* Ethernet src addr */\n-\tHASH_FIELD_L2_DST,\t/* Ethernet dst addr */\n-\tHASH_FIELD_L3_SRC,\t/* L3 src addr */\n-\tHASH_FIELD_L3_DST,\t/* L3 dst addr */\n-\tHASH_FIELD_L4_SRC,\t/* TCP/UDP src ports */\n-\tHASH_FIELD_L4_DST,\t/* TCP/UDP dst ports */\n };\n \n struct rss_key {\n", "prefixes": [ "v6", "3/8" ] }