Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139149/?format=api
{ "id": 139149, "url": "http://patches.dpdk.org/api/patches/139149/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405165518.367503-17-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405165518.367503-17-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405165518.367503-17-stephen@networkplumber.org", "date": "2024-04-05T16:53:27", "name": "[v4,16/30] raw: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "10b690338db70eef5fa974b923ded5aad914b1c4", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405165518.367503-17-stephen@networkplumber.org/mbox/", "series": [ { "id": 31690, "url": "http://patches.dpdk.org/api/series/31690/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31690", "date": "2024-04-05T16:53:11", "name": "replace use of rte_memcpy with fixed sizes", "version": 4, "mbox": "http://patches.dpdk.org/series/31690/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139149/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139149/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED8AC43E0C;\n\tFri, 5 Apr 2024 18:57:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 51914406B7;\n\tFri, 5 Apr 2024 18:55:59 +0200 (CEST)", "from mail-pf1-f181.google.com (mail-pf1-f181.google.com\n [209.85.210.181])\n by mails.dpdk.org (Postfix) with ESMTP id 2F9C040E5E\n for <dev@dpdk.org>; Fri, 5 Apr 2024 18:55:58 +0200 (CEST)", "by mail-pf1-f181.google.com with SMTP id\n d2e1a72fcca58-6ecee1f325bso1894073b3a.2\n for <dev@dpdk.org>; Fri, 05 Apr 2024 09:55:58 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n c2-20020aa781c2000000b006e6c0f8ce1bsm1728555pfn.47.2024.04.05.09.55.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 05 Apr 2024 09:55:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712336157;\n x=1712940957; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Grk2cJIzxC80uwuX8qnelePHUG7TGKeD7z+sdRwYR2M=;\n b=Uo+RxTVGaS4bpS8oMx9aiFPXKTgCr5SUG5ae1iap9eecsLLU9JwWYPvGFkywqiD53t\n ZWsrStGuVIzoskd34B47gqEvdZ1IGUOlMrKq2LNzMp3MNdgqbTrbrt8TMiF+iKK2dT9F\n v/nNRNlMH56iL6lhmYfKXC6C0aRv93MD9+ez2KBICJAIBQFB479Ah/92QUgLGaY/RVgF\n pvpobs+/L48kUIgpBYIyvkm13H13v5+SdgRoQicj0SenJElFS91T35P2c8l2s/+i4rtX\n xiQIa35sLJbMYJM7PmjA47RKeaMLuciIaGiWBFjaIEN0P7iM44NZN+vZcwRBWH+bo+Zu\n o1dA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712336157; x=1712940957;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Grk2cJIzxC80uwuX8qnelePHUG7TGKeD7z+sdRwYR2M=;\n b=oRJwrARKsZfQDkxWxbaWZEERJyv589rFw26E0SQoV2hzZStiLqvQHK3+hztWJllxVt\n Bv+SUfaXPAxPtU3yhfqplw+pZVi1ySCI0yQ4TRUHumsfu0YESioMgKRB1PQbBI3zI1wJ\n Qu4XsHnofMeL5DZjOoF/AobCq/exJJ3p0QsjlTn6XWH1+ziHXAtHYVwvtx5SCRs5Ht1R\n Aojo13nur84CQ6w/Yj/WAviDlOVn+rcZwSnSGv+FfHECMnEiomCXZAoN5vA3NZ/mls0Y\n vqgm62ZyhOhJSQcOBy2Dbk/vapEHNoOD58KQ8vV9//edp9+/kEfhHgnRiIqj9ZGUSJa2\n grjw==", "X-Gm-Message-State": "AOJu0YxU75/LkFGihsnfF1H2XKd37yu39O7m0mtKx0rJrXiMfmp5H3BB\n 6fMzPNj6ZjGrb2261xLq7EfijWptTFzGmfyBaGiQlbNIkxLzwORYisr3SSSlmLxyyMd3J+IXVcm\n n1JQCVg==", "X-Google-Smtp-Source": "\n AGHT+IEjEIosbX9ZuRCjj8mygRsWxwfwKZYqAcCr7HdOVUDdfd+4TshSMVhNI27sEC0bXt7RoY0myg==", "X-Received": "by 2002:a05:6a00:14d3:b0:6ea:afd1:9023 with SMTP id\n w19-20020a056a0014d300b006eaafd19023mr2395117pfu.0.1712336157352;\n Fri, 05 Apr 2024 09:55:57 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Rosen Xu <rosen.xu@intel.com>, Sachin Saxena <sachin.saxena@nxp.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Subject": "[PATCH v4 16/30] raw: replace use of fixed size rte_memcpy", "Date": "Fri, 5 Apr 2024 09:53:27 -0700", "Message-ID": "<20240405165518.367503-17-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240405165518.367503-1-stephen@networkplumber.org>", "References": "<20240403163432.437275-1-stephen@networkplumber.org>\n <20240405165518.367503-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/raw/ifpga/afu_pmd_he_hssi.c | 3 +--\n drivers/raw/ifpga/afu_pmd_he_lpbk.c | 3 +--\n drivers/raw/ifpga/afu_pmd_he_mem.c | 3 +--\n drivers/raw/ifpga/afu_pmd_n3000.c | 8 ++++----\n drivers/raw/ifpga/ifpga_rawdev.c | 11 +++++------\n drivers/raw/skeleton/skeleton_rawdev.c | 8 +++-----\n drivers/raw/skeleton/skeleton_rawdev_test.c | 1 -\n 7 files changed, 15 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga/afu_pmd_he_hssi.c b/drivers/raw/ifpga/afu_pmd_he_hssi.c\nindex 859f28dcc1..c2aaed9203 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_hssi.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_hssi.c\n@@ -15,7 +15,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -314,7 +313,7 @@ static int he_hssi_config(struct afu_rawdev *dev, void *config,\n \tif (cfg->port >= NUM_HE_HSSI_PORTS)\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));\n+\tmemcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_he_lpbk.c b/drivers/raw/ifpga/afu_pmd_he_lpbk.c\nindex c7c5cda48c..ffb7075c84 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_lpbk.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_lpbk.c\n@@ -15,7 +15,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -363,7 +362,7 @@ static int he_lpbk_config(struct afu_rawdev *dev, void *config,\n \tif ((cfg->end < cfg->begin) || (cfg->end > MAX_CACHE_LINES))\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));\n+\tmemcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_he_mem.c b/drivers/raw/ifpga/afu_pmd_he_mem.c\nindex a1db533eeb..b799e40d2d 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_mem.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_mem.c\n@@ -14,7 +14,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -126,7 +125,7 @@ static int he_mem_tg_config(struct afu_rawdev *dev, void *config,\n \tif (config_size != sizeof(struct rte_pmd_afu_he_mem_tg_cfg))\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));\n+\tmemcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c\nindex 67b3941265..9236c0b153 100644\n--- a/drivers/raw/ifpga/afu_pmd_n3000.c\n+++ b/drivers/raw/ifpga/afu_pmd_n3000.c\n@@ -1867,8 +1867,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,\n \t\tif ((cfg->nlb_cfg.end < cfg->nlb_cfg.begin) ||\n \t\t\t(cfg->nlb_cfg.end > MAX_CACHE_LINES))\n \t\t\treturn -EINVAL;\n-\t\trte_memcpy(&priv->nlb_cfg, &cfg->nlb_cfg,\n-\t\t\tsizeof(struct rte_pmd_afu_nlb_cfg));\n+\t\tmemcpy(&priv->nlb_cfg, &cfg->nlb_cfg,\n+\t\t sizeof(struct rte_pmd_afu_nlb_cfg));\n \t} else if (cfg->type == RTE_PMD_AFU_N3000_DMA) {\n \t\tif (cfg->dma_cfg.index >= NUM_N3000_DMA)\n \t\t\treturn -EINVAL;\n@@ -1887,8 +1887,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,\n \t\t\t\t\tcfg->dma_cfg.length);\n \t\t\t}\n \t\t}\n-\t\trte_memcpy(&priv->dma_cfg, &cfg->dma_cfg,\n-\t\t\tsizeof(struct rte_pmd_afu_dma_cfg));\n+\t\tmemcpy(&priv->dma_cfg, &cfg->dma_cfg,\n+\t\t sizeof(struct rte_pmd_afu_dma_cfg));\n \t} else {\n \t\tIFPGA_RAWDEV_PMD_ERR(\"Invalid type of N3000 AFU\");\n \t\treturn -EINVAL;\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex f89bd3f9e2..d5d47e14dd 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -14,7 +14,6 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n #include <rte_devargs.h>\n-#include <rte_memcpy.h>\n #include <rte_pci.h>\n #include <bus_pci_driver.h>\n #include <rte_kvargs.h>\n@@ -258,7 +257,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev)\n \tif (point < 12)\n \t\treturn -1;\n \tpoint -= 12;\n-\trte_memcpy(ifpga_dev->parent_bdf, &link[point], 12);\n+\tmemcpy(ifpga_dev->parent_bdf, &link[point], 12);\n \n \tpoint = strlen(link1);\n \tif (point < 26)\n@@ -948,10 +947,10 @@ ifpga_rawdev_pr(struct rte_rawdev *dev,\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\trte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,\n-\t\t\tsizeof(u64));\n-\t\trte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,\n-\t\t\tsizeof(u64));\n+\t\tmemcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,\n+\t\t sizeof(u64));\n+\t\tmemcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,\n+\t\t sizeof(u64));\n \n \t\tIFPGA_RAWDEV_PMD_INFO(\"%s: uuid_l=0x%lx, uuid_h=0x%lx\\n\",\n \t\t\t__func__,\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex 6e99d35536..256f45cb5d 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -20,7 +20,6 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n #include <rte_memory.h>\n-#include <rte_memcpy.h>\n #include <rte_lcore.h>\n #include <bus_vdev_driver.h>\n \n@@ -245,8 +244,8 @@ static int skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,\n \tskelq = &skeldev->queues[queue_id];\n \n \tif (queue_id < SKELETON_MAX_QUEUES)\n-\t\trte_memcpy(queue_conf, skelq,\n-\t\t\tsizeof(struct skeleton_rawdev_queue));\n+\t\tmemcpy(queue_conf, skelq,\n+\t\t sizeof(struct skeleton_rawdev_queue));\n \n \treturn 0;\n }\n@@ -281,8 +280,7 @@ static int skeleton_rawdev_queue_setup(struct rte_rawdev *dev,\n \n \tif (skeldev->num_queues > queue_id &&\n \t q->depth < SKELETON_QUEUE_MAX_DEPTH) {\n-\t\trte_memcpy(q, queue_conf,\n-\t\t\t sizeof(struct skeleton_rawdev_queue));\n+\t\tmemcpy(q, queue_conf, sizeof(struct skeleton_rawdev_queue));\n \t\tclear_queue_bufs(queue_id);\n \t} else {\n \t\tSKELETON_PMD_ERR(\"Invalid queue configuration\");\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c\nindex b7a7f623aa..dc32c4e29b 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev_test.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev_test.c\n@@ -7,7 +7,6 @@\n #include <rte_common.h>\n #include <rte_mbuf.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <dev_driver.h>\n #include <rte_rawdev.h>\n #include <bus_vdev_driver.h>\n", "prefixes": [ "v4", "16/30" ] }