Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139135/?format=api
{ "id": 139135, "url": "http://patches.dpdk.org/api/patches/139135/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405165518.367503-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405165518.367503-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405165518.367503-2-stephen@networkplumber.org", "date": "2024-04-05T16:53:12", "name": "[v4,01/30] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d5b5871cc9876169012d13ccf9743f19a4d89cf", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405165518.367503-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31690, "url": "http://patches.dpdk.org/api/series/31690/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31690", "date": "2024-04-05T16:53:11", "name": "replace use of rte_memcpy with fixed sizes", "version": 4, "mbox": "http://patches.dpdk.org/series/31690/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139135/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 628F543E0C;\n\tFri, 5 Apr 2024 18:55:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 146384067D;\n\tFri, 5 Apr 2024 18:55:40 +0200 (CEST)", "from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n by mails.dpdk.org (Postfix) with ESMTP id DF8CF402CE\n for <dev@dpdk.org>; Fri, 5 Apr 2024 18:55:37 +0200 (CEST)", "by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-6ecc9f0bdaaso1865060b3a.1\n for <dev@dpdk.org>; Fri, 05 Apr 2024 09:55:37 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n c2-20020aa781c2000000b006e6c0f8ce1bsm1728555pfn.47.2024.04.05.09.55.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 05 Apr 2024 09:55:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712336137;\n x=1712940937; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lN/P2ynaspZBYC0V2kpB/XNQsVjxxcNkYZCwr4zPgSA=;\n b=bYHZ6PbFv63WOrHff5dEGBR+SdLCgpuaEkI6IdeLw7hO9dImhQtllIjQBlc/wU1rT1\n NQgqyqVU41LM2ZAV9A1tzC3AfmEMCUrSuNOKbc4lWibm5vRgX3+TewByfhuEcstEBJHp\n hQl2wBg/Zk06BcMDUWMA3sTWDLw7L8p0k0PDtQOTWdsb8ahZr2XllSNC9e8rqZIJ4NcR\n LKXZOXYQZIKrHKRtqlUT9DmjG+SLunNF2xZxNsac3wuFI4wlKBdwTXoFGZvwospdOJyC\n HHrsmadBkjUNah6dm4ahMC6b9gg06XQEha0frpui7Px3OHWmLGpQg/TvM6iJ+vR1HTih\n fSYw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712336137; x=1712940937;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=lN/P2ynaspZBYC0V2kpB/XNQsVjxxcNkYZCwr4zPgSA=;\n b=SRC5q+CSLeE/W34FqlfkBZGph/GTKALV/zqjiT+JSbN/DZwLFijCH1fnjDToLYEQ3n\n SjHWs+VmbUkarrciFNdQauCdRmULdP1PC4ORSqJzDnIsEZNHwgH1Cxui8vB0DuwD/W+p\n Lc9mabDANBhG0+9AZXt7E2RIPaPjXA1zOU22ML1VwWDYti9MQaPgEeUffetwzUhxveB5\n fdd5b2yIhGHxBkvxnpM/Yt0Ea/4/Nhe0hGwuPEoY7lqTBobhe1Q9dRvKmNAMzS1/kk4B\n lnY/YouuAqKZMkeMZrjheOikzLm8RaV+tkKKh/89l3dQrjfh4MAddR0nAu9+Q43KyJNJ\n ow+g==", "X-Gm-Message-State": "AOJu0Yw/E5pbnDYV82tsBu2CDIt4VrbNGQ6RKy0356bpslBwidEKSpf1\n fMwqFVrLOfDMN6QLyAoaAiEsHJwhaVzPn4peDikqp7NsXxtZdeKiW9vGfuqLdA+zN9bTMh3MYUN\n 4hc8=", "X-Google-Smtp-Source": "\n AGHT+IECQdGy/zAkSuA5I8+2M4mKHMl9qBUsp44b0AncpQpi8MlpENGy5cvNF7+9L5+yHVPvpywnRg==", "X-Received": "by 2002:a05:6a00:1acb:b0:6ec:fcfc:de6a with SMTP id\n f11-20020a056a001acb00b006ecfcfcde6amr2203670pfv.32.1712336136867;\n Fri, 05 Apr 2024 09:55:36 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v4 01/30] cocci/rte_memcpy: add script to eliminate fixed size\n rte_memcpy", "Date": "Fri, 5 Apr 2024 09:53:12 -0700", "Message-ID": "<20240405165518.367503-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240405165518.367503-1-stephen@networkplumber.org>", "References": "<20240403163432.437275-1-stephen@networkplumber.org>\n <20240405165518.367503-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rte_memcpy should not be used for the simple case of copying\na fix size structure because it is slower and will hide problems\nfrom code analysis tools. Coverity, fortify and other analyzers\nspecial case memcpy().\n\nGcc (and Clang) are smart enough to inline copies which\nwill be faster.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n devtools/cocci/rte_memcpy.cocci | 11 +++++++++++\n 1 file changed, 11 insertions(+)\n create mode 100644 devtools/cocci/rte_memcpy.cocci", "diff": "diff --git a/devtools/cocci/rte_memcpy.cocci b/devtools/cocci/rte_memcpy.cocci\nnew file mode 100644\nindex 0000000000..fa1038fc06\n--- /dev/null\n+++ b/devtools/cocci/rte_memcpy.cocci\n@@ -0,0 +1,11 @@\n+//\n+// rte_memcpy should not be used for simple fixed size structure\n+// because compiler's are smart enough to inline these.\n+//\n+@@\n+expression src, dst; constant size;\n+@@\n+(\n+- rte_memcpy(dst, src, size)\n++ memcpy(dst, src, size)\n+)\n", "prefixes": [ "v4", "01/30" ] }