Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139127/?format=api
{ "id": 139127, "url": "http://patches.dpdk.org/api/patches/139127/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405144604.906695-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405144604.906695-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405144604.906695-2-david.marchand@redhat.com", "date": "2024-04-05T14:45:55", "name": "[v2,1/8] net/ice: fix check for outer UDP checksum offload", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "aeab3e26f12355901bc6eb942c6a1df1c4e03434", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405144604.906695-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 31689, "url": "http://patches.dpdk.org/api/series/31689/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31689", "date": "2024-04-05T14:45:54", "name": "Fix outer UDP checksum for Intel nics", "version": 2, "mbox": "http://patches.dpdk.org/series/31689/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139127/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139127/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CF96C43E06;\n\tFri, 5 Apr 2024 16:46:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A7FAA40633;\n\tFri, 5 Apr 2024 16:46:24 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id D13A24029C\n for <dev@dpdk.org>; Fri, 5 Apr 2024 16:46:22 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-237-B0wIKmh0OTSp67vb7GW5lQ-1; Fri, 05 Apr 2024 10:46:19 -0400", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91C47101A521;\n Fri, 5 Apr 2024 14:46:18 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.49])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 4C8B9492BCB;\n Fri, 5 Apr 2024 14:46:17 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1712328382;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RtC5jXApKY6IYlWOW2A5EQJPQ9UakXkhFCPFE23EBI4=;\n b=JjN0mLqknko0AHRE6MF4U83V4ShgycM/+PXOOTQ0XyF4ry4NVzlbCB6ZqQmLU9cAT3Ymcp\n uHqp4GCG9pFqY18STNBfPobkYfKeu2n1Or9kPLbPp9fABSXjjUsvSE4fxnkSpif+KCMPIv\n n8m4Qk/jMGhM/+ptkcAz7bY6tnLVZrM=", "X-MC-Unique": "B0wIKmh0OTSp67vb7GW5lQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com,\n Qi Zhang <qi.z.zhang@intel.com>,\n Murphy Yang <murphyx.yang@intel.com>", "Subject": "[PATCH v2 1/8] net/ice: fix check for outer UDP checksum offload", "Date": "Fri, 5 Apr 2024 16:45:55 +0200", "Message-ID": "<20240405144604.906695-2-david.marchand@redhat.com>", "In-Reply-To": "<20240405144604.906695-1-david.marchand@redhat.com>", "References": "<20240405125039.897933-1-david.marchand@redhat.com>\n <20240405144604.906695-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "ICE_TX_CTX_EIPT_NONE == 0.\nThere is a good chance that !(anything & 0) is true :-).\n\nWhile removing this noop check is doable, let's check that the\ndescriptor does contain a outer ip type.\n\nFixes: 2ed011776334 (\"net/ice: fix outer UDP Tx checksum offload\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nChanges since v1:\n- fix inverted check,\n\n---\n drivers/net/ice/ice_rxtx.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex 13aabe97a5..40471306b4 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -2751,9 +2751,9 @@ ice_parse_tunneling_params(uint64_t ol_flags,\n \t * Calculate the tunneling UDP checksum.\n \t * Shall be set only if L4TUNT = 01b and EIPT is not zero\n \t */\n-\tif (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&\n-\t\t(*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING) &&\n-\t\t(ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM))\n+\tif ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) &&\n+\t\t\t(*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING) &&\n+\t\t\t(ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM))\n \t\t*cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;\n }\n \n", "prefixes": [ "v2", "1/8" ] }