Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139119/?format=api
{ "id": 139119, "url": "http://patches.dpdk.org/api/patches/139119/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405125039.897933-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405125039.897933-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405125039.897933-3-david.marchand@redhat.com", "date": "2024-04-05T12:49:41", "name": "[2/8] net/ice: enhance debug when HW fails to transmit", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9752ad05c5a7be6dcbe62c467ba49d8db8f63bc9", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405125039.897933-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 31687, "url": "http://patches.dpdk.org/api/series/31687/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31687", "date": "2024-04-05T12:49:39", "name": "Fix outer UDP checksum for Intel nics", "version": 1, "mbox": "http://patches.dpdk.org/series/31687/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139119/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139119/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 554CD43E01;\n\tFri, 5 Apr 2024 14:51:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0EBAC4064C;\n\tFri, 5 Apr 2024 14:51:22 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 51B524067D\n for <dev@dpdk.org>; Fri, 5 Apr 2024 14:51:20 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-ZCyyVVxNPVOX7KEs2gdbnA-1; Fri,\n 05 Apr 2024 08:51:18 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 343DF3C0CD27;\n Fri, 5 Apr 2024 12:51:18 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.49])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 756841C060A4;\n Fri, 5 Apr 2024 12:51:17 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1712321479;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Ygup4MIWR3cOAla0vzg8zMHbr/SPgXKVLvmN29pqqW0=;\n b=C3Q2R54aNPhTj3CUmKVcEgRIsaDJKc+4wRuLrF7rgZgzkUfrvabKGslAIoTM6x5W02mGmB\n uwyM7MaKkXJa2gZ59Nm2KFx5Le2GpaAfVudmJCeS88ku57ripnT8jtbfVtrZE9LsQ03hAk\n wXc4N539NjDHRXAvUzNdBx1mBNZ7UdA=", "X-MC-Unique": "ZCyyVVxNPVOX7KEs2gdbnA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tferruh.yigit@amd.com", "Subject": "[PATCH 2/8] net/ice: enhance debug when HW fails to transmit", "Date": "Fri, 5 Apr 2024 14:49:41 +0200", "Message-ID": "<20240405125039.897933-3-david.marchand@redhat.com>", "In-Reply-To": "<20240405125039.897933-1-david.marchand@redhat.com>", "References": "<20240405125039.897933-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "At the moment, if the driver sets an incorrect Tx descriptor, the HW\nwill raise a MDD event reported as:\nice_interrupt_handler(): OICR: MDD event\n\nAdd some debug info for this case and the VF index in all logs.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/ice/ice_ethdev.c | 29 +++++++++++++++++++++++++----\n 1 file changed, 25 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 87385d2649..fd494e6b3b 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -1389,6 +1389,7 @@ ice_interrupt_handler(void *param)\n \tuint32_t oicr;\n \tuint32_t reg;\n \tuint8_t pf_num;\n+\tuint16_t vf_num;\n \tuint8_t event;\n \tuint16_t queue;\n \tint ret;\n@@ -1432,28 +1433,48 @@ ice_interrupt_handler(void *param)\n \t\tif (reg & GL_MDET_TX_PQM_VALID_M) {\n \t\t\tpf_num = (reg & GL_MDET_TX_PQM_PF_NUM_M) >>\n \t\t\t\t GL_MDET_TX_PQM_PF_NUM_S;\n+\t\t\tvf_num = (reg & GL_MDET_TX_PQM_VF_NUM_M) >>\n+\t\t\t\t GL_MDET_TX_PQM_VF_NUM_S;\n \t\t\tevent = (reg & GL_MDET_TX_PQM_MAL_TYPE_M) >>\n \t\t\t\tGL_MDET_TX_PQM_MAL_TYPE_S;\n \t\t\tqueue = (reg & GL_MDET_TX_PQM_QNUM_M) >>\n \t\t\t\tGL_MDET_TX_PQM_QNUM_S;\n \n \t\t\tPMD_DRV_LOG(WARNING, \"Malicious Driver Detection event \"\n-\t\t\t\t \"%d by PQM on TX queue %d PF# %d\",\n-\t\t\t\t event, queue, pf_num);\n+\t\t\t\t \"%d by PQM on TX queue %d PF# %d VF# %d\",\n+\t\t\t\t event, queue, pf_num, vf_num);\n \t\t}\n \n \t\treg = ICE_READ_REG(hw, GL_MDET_TX_TCLAN);\n \t\tif (reg & GL_MDET_TX_TCLAN_VALID_M) {\n \t\t\tpf_num = (reg & GL_MDET_TX_TCLAN_PF_NUM_M) >>\n \t\t\t\t GL_MDET_TX_TCLAN_PF_NUM_S;\n+\t\t\tvf_num = (reg & GL_MDET_TX_TCLAN_VF_NUM_M) >>\n+\t\t\t\t GL_MDET_TX_TCLAN_VF_NUM_S;\n \t\t\tevent = (reg & GL_MDET_TX_TCLAN_MAL_TYPE_M) >>\n \t\t\t\tGL_MDET_TX_TCLAN_MAL_TYPE_S;\n \t\t\tqueue = (reg & GL_MDET_TX_TCLAN_QNUM_M) >>\n \t\t\t\tGL_MDET_TX_TCLAN_QNUM_S;\n \n \t\t\tPMD_DRV_LOG(WARNING, \"Malicious Driver Detection event \"\n-\t\t\t\t \"%d by TCLAN on TX queue %d PF# %d\",\n-\t\t\t\t event, queue, pf_num);\n+\t\t\t\t \"%d by TCLAN on TX queue %d PF# %d VF# %d\",\n+\t\t\t\t event, queue, pf_num, vf_num);\n+\t\t}\n+\n+\t\treg = ICE_READ_REG(hw, GL_MDET_TX_TDPU);\n+\t\tif (reg & GL_MDET_TX_TDPU_VALID_M) {\n+\t\t\tpf_num = (reg & GL_MDET_TX_TDPU_PF_NUM_M) >>\n+\t\t\t\t GL_MDET_TX_TDPU_PF_NUM_S;\n+\t\t\tvf_num = (reg & GL_MDET_TX_TDPU_VF_NUM_M) >>\n+\t\t\t\t GL_MDET_TX_TDPU_VF_NUM_S;\n+\t\t\tevent = (reg & GL_MDET_TX_TDPU_MAL_TYPE_M) >>\n+\t\t\t\tGL_MDET_TX_TDPU_MAL_TYPE_S;\n+\t\t\tqueue = (reg & GL_MDET_TX_TDPU_QNUM_M) >>\n+\t\t\t\tGL_MDET_TX_TDPU_QNUM_S;\n+\n+\t\t\tPMD_DRV_LOG(WARNING, \"Malicious Driver Detection event \"\n+\t\t\t\t \"%d by TDPU on TX queue %d PF# %d VF# %d\",\n+\t\t\t\t event, queue, pf_num, vf_num);\n \t\t}\n \t}\n done:\n", "prefixes": [ "2/8" ] }