Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139113/?format=api
{ "id": 139113, "url": "http://patches.dpdk.org/api/patches/139113/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240404210447.1915517-3-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240404210447.1915517-3-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240404210447.1915517-3-nicolas.chautru@intel.com", "date": "2024-04-04T21:04:46", "name": "[v1,2/3] baseband/acc: refactor queue status update", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "544000ad2cf7d64e7ea15b6d0f6b467795247c98", "submitter": { "id": 1314, "url": "http://patches.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240404210447.1915517-3-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 31682, "url": "http://patches.dpdk.org/api/series/31682/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31682", "date": "2024-04-04T21:04:45", "name": "Additional queue stats", "version": 1, "mbox": "http://patches.dpdk.org/series/31682/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139113/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139113/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EB24143E02;\n\tThu, 4 Apr 2024 23:04:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 118FF40DDE;\n\tThu, 4 Apr 2024 23:03:56 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.14])\n by mails.dpdk.org (Postfix) with ESMTP id 24C4E402BC\n for <dev@dpdk.org>; Thu, 4 Apr 2024 23:03:51 +0200 (CEST)", "from fmviesa010.fm.intel.com ([10.60.135.150])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Apr 2024 14:03:46 -0700", "from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..)\n ([10.233.181.123])\n by fmviesa010.fm.intel.com with ESMTP; 04 Apr 2024 14:03:45 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1712264632; x=1743800632;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Z5ARtU3u0aKVK6jmv39xwZ+qeOfunsXsu+Gsuj/5r8Y=;\n b=aIavJukNynNAuZJq5XylackLOE4Fv1hVSBJsmU0TVelaUBWtYgXjucXc\n XemsYjNHDfuMnnBOk1ylgGu8tiK/GOEgN3M0ta8pFxAxpJ/MVdu+NlB0w\n ljR+sKp1tI++Qby6agrOjxCbY0oRJTW31Rh9VkalEpMyDtpP3AatT+Re0\n OaLSUymZIbKVcxvld/GGwictYFxRltzKg/rZ/F9vanR6gDCB3hhqu7T+W\n sjUDupZIxdhoRGx1MIfZm6CPfac3Vh3KvsKtstmPLqJ7FcWvYBmowpmgL\n Jvkopl2qKyAq/dM03+5t8uEP2M6NY/XvrwX/HJ4lzw/DWaKqscASqqU+8 Q==;", "X-CSE-ConnectionGUID": [ "U1Z9rPrDQzW1jcXKaj2dzQ==", "1ySXW1oxTJWE+Mc+ey0csw==" ], "X-CSE-MsgGUID": [ "GzoISbKzRumVbLxejqYALA==", "qqUrW9HVT5e9WFFIfcLmvg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11034\"; a=\"11393386\"", "E=Sophos;i=\"6.07,180,1708416000\"; d=\"scan'208\";a=\"11393386\"", "E=Sophos;i=\"6.07,180,1708416000\"; d=\"scan'208\";a=\"18864460\"" ], "X-ExtLoop1": "1", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com", "Cc": "hemant.agrawal@nxp.com, david.marchand@redhat.com,\n hernan.vargas@intel.com,\n Nicolas Chautru <nicolas.chautru@intel.com>", "Subject": "[PATCH v1 2/3] baseband/acc: refactor queue status update", "Date": "Thu, 4 Apr 2024 14:04:46 -0700", "Message-Id": "<20240404210447.1915517-3-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240404210447.1915517-1-nicolas.chautru@intel.com>", "References": "<20240404210447.1915517-1-nicolas.chautru@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Introducing common function for queue stats update\nwithin the acc PMDs.\n\nSigned-off-by: Nicolas Chautru <nicolas.chautru@intel.com>\n---\n drivers/baseband/acc/acc_common.h | 18 ++++++++\n drivers/baseband/acc/rte_acc100_pmd.c | 45 ++++++--------------\n drivers/baseband/acc/rte_vrb_pmd.c | 61 +++++++++------------------\n 3 files changed, 50 insertions(+), 74 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h\nindex fddeb0737b..c364638372 100644\n--- a/drivers/baseband/acc/acc_common.h\n+++ b/drivers/baseband/acc/acc_common.h\n@@ -1554,6 +1554,24 @@ acc_aq_avail(struct rte_bbdev_queue_data *q_data, uint16_t num_ops)\n \treturn aq_avail;\n }\n \n+/* Update queue stats during enqueue. */\n+static inline void\n+acc_update_qstat_enqueue(struct rte_bbdev_queue_data *q_data,\n+\t\tuint16_t enq_count, uint16_t enq_err_count)\n+{\n+\tq_data->queue_stats.enqueued_count += enq_count;\n+\tq_data->queue_stats.enqueue_err_count += enq_err_count;\n+\tq_data->queue_stats.enqueue_depth_avail = acc_aq_avail(q_data, 0);\n+}\n+\n+/* Update queue stats during dequeue. */\n+static inline void\n+acc_update_qstat_dequeue(struct rte_bbdev_queue_data *q_data, uint16_t deq_count)\n+{\n+\tq_data->queue_stats.dequeued_count += deq_count;\n+\tq_data->queue_stats.enqueue_depth_avail = acc_aq_avail(q_data, 0);\n+}\n+\n /* Calculates number of CBs in processed encoder TB based on 'r' and input\n * length.\n */\ndiff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex 4f666e514b..c27574b911 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -892,6 +892,7 @@ acc100_queue_stop(struct rte_bbdev *dev, uint16_t queue_id)\n \tdev->data->queues[queue_id].queue_stats.dequeue_err_count = 0;\n \tdev->data->queues[queue_id].queue_stats.enqueue_warn_count = 0;\n \tdev->data->queues[queue_id].queue_stats.dequeue_warn_count = 0;\n+\tdev->data->queues[queue_id].queue_stats.enqueue_depth_avail = 0;\n \n \treturn 0;\n }\n@@ -3308,9 +3309,7 @@ acc100_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -3357,9 +3356,7 @@ acc100_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, desc_idx, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -3396,9 +3393,7 @@ acc100_enqueue_enc_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -3434,9 +3429,7 @@ acc100_enqueue_ldpc_enc_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_descs, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -3500,9 +3493,7 @@ acc100_enqueue_dec_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -3538,9 +3529,7 @@ acc100_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -3583,9 +3572,7 @@ acc100_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -3620,9 +3607,7 @@ acc100_enqueue_dec_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -4012,8 +3997,7 @@ acc100_dequeue_enc(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_descs;\n \n-\t/* Update enqueue stats */\n-\tq_data->queue_stats.dequeued_count += dequeued_ops;\n+\tacc_update_qstat_dequeue(q_data, dequeued_ops);\n \n \treturn dequeued_ops;\n }\n@@ -4055,8 +4039,7 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_descs;\n \n-\t/* Update enqueue stats */\n-\tq_data->queue_stats.dequeued_count += dequeued_ops;\n+\tacc_update_qstat_dequeue(q_data, dequeued_ops);\n \n \treturn dequeued_ops;\n }\n@@ -4101,8 +4084,7 @@ acc100_dequeue_dec(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_cbs;\n \n-\t/* Update enqueue stats */\n-\tq_data->queue_stats.dequeued_count += i;\n+\tacc_update_qstat_dequeue(q_data, i);\n \n \treturn i;\n }\n@@ -4148,8 +4130,7 @@ acc100_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_cbs;\n \n-\t/* Update enqueue stats */\n-\tq_data->queue_stats.dequeued_count += i;\n+\tacc_update_qstat_dequeue(q_data, i);\n \n \treturn i;\n }\ndiff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c\nindex 88b1104fab..4c1e036199 100644\n--- a/drivers/baseband/acc/rte_vrb_pmd.c\n+++ b/drivers/baseband/acc/rte_vrb_pmd.c\n@@ -1109,6 +1109,7 @@ vrb_queue_stop(struct rte_bbdev *dev, uint16_t queue_id)\n \tdev->data->queues[queue_id].queue_stats.dequeue_err_count = 0;\n \tdev->data->queues[queue_id].queue_stats.enqueue_warn_count = 0;\n \tdev->data->queues[queue_id].queue_stats.dequeue_warn_count = 0;\n+\tdev->data->queues[queue_id].queue_stats.enqueue_depth_avail = 0;\n \treturn 0;\n }\n \n@@ -2738,9 +2739,7 @@ vrb_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -2778,9 +2777,7 @@ vrb_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, desc_idx, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -2817,9 +2814,7 @@ vrb_enqueue_enc_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -2864,9 +2859,7 @@ vrb_enqueue_ldpc_enc_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_descs, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -2926,9 +2919,7 @@ vrb_enqueue_dec_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -2961,9 +2952,7 @@ vrb_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -3004,9 +2993,7 @@ vrb_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -3041,9 +3028,7 @@ vrb_enqueue_dec_tb(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \n \treturn i;\n }\n@@ -3443,8 +3428,7 @@ vrb_dequeue_enc(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_descs;\n \n-\t/* Update enqueue stats. */\n-\tq_data->queue_stats.dequeued_count += dequeued_ops;\n+\tacc_update_qstat_dequeue(q_data, dequeued_ops);\n \n \treturn dequeued_ops;\n }\n@@ -3486,8 +3470,7 @@ vrb_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_descs;\n \n-\t/* Update enqueue stats. */\n-\tq_data->queue_stats.dequeued_count += dequeued_ops;\n+\tacc_update_qstat_dequeue(q_data, dequeued_ops);\n \n \treturn dequeued_ops;\n }\n@@ -3525,8 +3508,7 @@ vrb_dequeue_dec(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_cbs;\n \n-\t/* Update enqueue stats */\n-\tq_data->queue_stats.dequeued_count += i;\n+\tacc_update_qstat_dequeue(q_data, i);\n \n \treturn i;\n }\n@@ -3565,8 +3547,7 @@ vrb_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,\n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_cbs;\n \n-\t/* Update enqueue stats. */\n-\tq_data->queue_stats.dequeued_count += i;\n+\tacc_update_qstat_dequeue(q_data, i);\n \n \treturn i;\n }\n@@ -3772,9 +3753,7 @@ vrb_enqueue_fft(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, i, &q_data->queue_stats);\n \n-\t/* Update stats */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -3840,8 +3819,7 @@ vrb_dequeue_fft(struct rte_bbdev_queue_data *q_data,\n \n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_cbs;\n-\t/* Update enqueue stats. */\n-\tq_data->queue_stats.dequeued_count += i;\n+\tacc_update_qstat_dequeue(q_data, i);\n \treturn i;\n }\n \n@@ -4095,9 +4073,7 @@ vrb2_enqueue_mldts(struct rte_bbdev_queue_data *q_data,\n \n \tacc_dma_enqueue(q, enqueued_descs, &q_data->queue_stats);\n \n-\t/* Update stats. */\n-\tq_data->queue_stats.enqueued_count += i;\n-\tq_data->queue_stats.enqueue_err_count += num - i;\n+\tacc_update_qstat_enqueue(q_data, i, num - i);\n \treturn i;\n }\n \n@@ -4192,8 +4168,9 @@ vrb2_dequeue_mldts(struct rte_bbdev_queue_data *q_data,\n \n \tq->aq_dequeued += aq_dequeued;\n \tq->sw_ring_tail += dequeued_cbs;\n-\t/* Update enqueue stats. */\n-\tq_data->queue_stats.dequeued_count += i;\n+\n+\tacc_update_qstat_dequeue(q_data, i);\n+\n \treturn i;\n }\n \n", "prefixes": [ "v1", "2/3" ] }