Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139106/?format=api
{ "id": 139106, "url": "http://patches.dpdk.org/api/patches/139106/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1712250913-1977-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1712250913-1977-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1712250913-1977-5-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-04T17:15:13", "name": "[4/4] dispatcher: use alloca instead of vla multi dimensional", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "111d261ca9c04f0eee74095dad40d6c0848d2613", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1712250913-1977-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31680, "url": "http://patches.dpdk.org/api/series/31680/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31680", "date": "2024-04-04T17:15:09", "name": "RFC samples converting VLA to alloca", "version": 1, "mbox": "http://patches.dpdk.org/series/31680/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139106/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/139106/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D4E543DFB;\n\tThu, 4 Apr 2024 19:15:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0558640A72;\n\tThu, 4 Apr 2024 19:15:22 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 1B0EC4067B\n for <dev@dpdk.org>; Thu, 4 Apr 2024 19:15:15 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 710A020E97C5; Thu, 4 Apr 2024 10:15:14 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 710A020E97C5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1712250914;\n bh=kOhp+ERR46H7sVuxwGoUUntAFlG8XLhNqoQ4gU+CwUc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ZEcO3RJJG5XAYXP0cSRsVDkjnO6wAJpzoYWl2rxKkXVODggHw/2O+5GHo5wWonQ58\n oBVnE41zSfcHQlaInb5R5/1kQ/+3Fq1Ved9BRyMrCMjEw7e1qH/7tGAIRkgggNa6cP\n 83iwen4DcmokIqYHyqsxQTDy3MrRYldp2WZDe/UQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Thomas Monjalon <thomas@monjalon.net>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 4/4] dispatcher: use alloca instead of vla multi dimensional", "Date": "Thu, 4 Apr 2024 10:15:13 -0700", "Message-Id": "<1712250913-1977-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1712250913-1977-1-git-send-email-roretzla@linux.microsoft.com>", "References": "\n <20231107193220.GA15232@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>\n <1712250913-1977-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RFC sample illustrating conversion of multi-dimensional VLA to use\nalloca().\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/dispatcher/rte_dispatcher.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/dispatcher/rte_dispatcher.c b/lib/dispatcher/rte_dispatcher.c\nindex 7934917..f154c26 100644\n--- a/lib/dispatcher/rte_dispatcher.c\n+++ b/lib/dispatcher/rte_dispatcher.c\n@@ -119,7 +119,7 @@ struct rte_dispatcher {\n \tstruct rte_event *events, uint16_t num_events)\n {\n \tint i;\n-\tstruct rte_event bursts[EVD_MAX_HANDLERS][num_events];\n+\tstruct rte_event *bursts = alloca(sizeof(struct rte_event) * EVD_MAX_HANDLERS * num_events);\n \tuint16_t burst_lens[EVD_MAX_HANDLERS] = { 0 };\n \tuint16_t drop_count = 0;\n \tuint16_t dispatch_count;\n@@ -136,7 +136,7 @@ struct rte_dispatcher {\n \t\t\tcontinue;\n \t\t}\n \n-\t\tbursts[handler_idx][burst_lens[handler_idx]] = *event;\n+\t\tbursts[handler_idx * num_events + burst_lens[handler_idx]] = *event;\n \t\tburst_lens[handler_idx]++;\n \t}\n \n@@ -152,7 +152,7 @@ struct rte_dispatcher {\n \t\t\tcontinue;\n \n \t\thandler->process_fun(dispatcher->event_dev_id, port->port_id,\n-\t\t\t\t bursts[i], len, handler->process_data);\n+\t\t\t\t &bursts[i * num_events], len, handler->process_data);\n \n \t\tdispatched += len;\n \n", "prefixes": [ "4/4" ] }