Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139057/?format=api
{ "id": 139057, "url": "http://patches.dpdk.org/api/patches/139057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240402215502.278838-24-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240402215502.278838-24-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240402215502.278838-24-stephen@networkplumber.org", "date": "2024-04-02T21:50:39", "name": "[v3,23/30] ml/cnxk: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bd65f4962b298307fc0130185bf957ba784124a0", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240402215502.278838-24-stephen@networkplumber.org/mbox/", "series": [ { "id": 31659, "url": "http://patches.dpdk.org/api/series/31659/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31659", "date": "2024-04-02T21:50:16", "name": "replace rte_memcpy of fixed size with memcpy", "version": 3, "mbox": "http://patches.dpdk.org/series/31659/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139057/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139057/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F278243DC8;\n\tTue, 2 Apr 2024 23:58:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8274440EE4;\n\tTue, 2 Apr 2024 23:56:17 +0200 (CEST)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id 721C440DCA\n for <dev@dpdk.org>; Tue, 2 Apr 2024 23:56:02 +0200 (CEST)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1e034607879so45947735ad.0\n for <dev@dpdk.org>; Tue, 02 Apr 2024 14:56:02 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n x15-20020a170902820f00b001dddf29b6e8sm11609381pln.299.2024.04.02.14.56.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 02 Apr 2024 14:56:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712094961;\n x=1712699761; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=JT1+LxSV8JgSBxCPehFAlyvD29BqgR4SjbJ3MvTdQkU=;\n b=dwrAkmKNZnlJlsj3mRZn19OsMwmO17v+RPgZxLhZ0Zfvymv1M/IzTQw/ZvvqP0Psix\n ar4otf1Zs9pMPHebOXr38SNP8NKsBmq2D0sw/nXL0pAyrvOx4uR88Vk6YjE66QIJBlST\n 6t6/Yu4gxckhtSBVLuSWsEGKqKviLZa7CqJfKcPeb6y2dXreOZhAz93pqOyDjxT4XyPr\n 4e6eniupV24cffr6qyYMKyv1gUCOM/rChgKdHw8Ga3BYd2t0iQOl0uvH0aP1UGM0kz21\n cY2cYEYwOqTlvd9u8zU5F0SoApmrUD7qiG7WWRQjUIvl4Oxm7aShtoftrPwnfnE7i6QX\n Nkiw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712094961; x=1712699761;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=JT1+LxSV8JgSBxCPehFAlyvD29BqgR4SjbJ3MvTdQkU=;\n b=wk7Z9MjEzZez4b4ngMl49JhssBacaoR95cqe555lNFr/tdU2cMDunjT+CM5u4lcEgS\n GY9ECbS78F5mscvBWkbVjMGKMaShXFlgYQoorqUnDuYYG3vTkv6oAzsUopYahA1GKPAg\n xDq8DxzqRQKyQaObad3Bu4M2WLyFvNobsjnxSt799elEjRnIAt1/tC5ev0qwBHBdgnqZ\n aCg83kOHDWV5179SWessWr3WFejQNk5Qd/2o+/yckoo3291vlTYq36rR1PnMn1ptmLZG\n gHMtCB8+SG1Mu2U1Fca/c7YMrABDho3mu1lnC+2KNr0N/7CvG6YuqLZBC5psaESRth5t\n F8uQ==", "X-Gm-Message-State": "AOJu0Yw+rZBBa4RSjBDpADadg1GnsX+fhuZmA8l63IS1pntBbKDc+dKy\n Jd5wiTNeqAMQkdlAB/YQdPcWTHGALsuhyu+rqyRBtGDzUi4aFG1tUSKWXEAv+mx2cHGa+A3deT6\n eTPU=", "X-Google-Smtp-Source": "\n AGHT+IEaL/qsqWXqfRCU1zC8l0ZYzIHe2KeB4jcDy+DgkXjzcrcNRvnp5CzoBDLKM7/x0x4cmCv6Hw==", "X-Received": "by 2002:a17:902:c94a:b0:1e0:e11:c626 with SMTP id\n i10-20020a170902c94a00b001e00e11c626mr16149166pla.47.1712094961613;\n Tue, 02 Apr 2024 14:56:01 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>", "Subject": "[PATCH v3 23/30] ml/cnxk: replace use of fixed size rte_memcpy", "Date": "Tue, 2 Apr 2024 14:50:39 -0700", "Message-ID": "<20240402215502.278838-24-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240402215502.278838-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240402215502.278838-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/ml/cnxk/cn10k_ml_model.c | 8 +++++---\n drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++++++----\n drivers/ml/cnxk/cnxk_ml_ops.c | 2 +-\n drivers/ml/cnxk/mvtvm_ml_model.c | 8 +++++---\n drivers/ml/cnxk/mvtvm_ml_ops.c | 8 +++++---\n 5 files changed, 23 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_model.c b/drivers/ml/cnxk/cn10k_ml_model.c\nindex 0325cd54f1..4e39a584fa 100644\n--- a/drivers/ml/cnxk/cn10k_ml_model.c\n+++ b/drivers/ml/cnxk/cn10k_ml_model.c\n@@ -560,7 +560,7 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo\n \n \t/* Set model info */\n \tmemset(info, 0, sizeof(struct rte_ml_model_info));\n-\trte_memcpy(info->name, metadata->model.name, MRVL_ML_MODEL_NAME_LEN);\n+\tmemcpy(info->name, metadata->model.name, MRVL_ML_MODEL_NAME_LEN);\n \tsnprintf(info->version, RTE_ML_STR_MAX, \"%u.%u.%u.%u\", metadata->model.version[0],\n \t\t metadata->model.version[1], metadata->model.version[2],\n \t\t metadata->model.version[3]);\n@@ -579,7 +579,8 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo\n \n \t/* Set input info */\n \tfor (i = 0; i < info->nb_inputs; i++) {\n-\t\trte_memcpy(input[i].name, io_info->input[i].name, MRVL_ML_INPUT_NAME_LEN);\n+\t\tmemcpy(input[i].name, io_info->input[i].name,\n+\t\t MRVL_ML_INPUT_NAME_LEN);\n \t\tinput[i].nb_dims = io_info->input[i].nb_dims;\n \t\tinput[i].shape = &io_info->input[i].shape[0];\n \t\tinput[i].type = io_info->input[i].qtype;\n@@ -590,7 +591,8 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo\n \n \t/* Set output info */\n \tfor (i = 0; i < info->nb_outputs; i++) {\n-\t\trte_memcpy(output[i].name, io_info->output[i].name, MRVL_ML_INPUT_NAME_LEN);\n+\t\tmemcpy(output[i].name, io_info->output[i].name,\n+\t\t MRVL_ML_INPUT_NAME_LEN);\n \t\toutput[i].nb_dims = io_info->output[i].nb_dims;\n \t\toutput[i].shape = &io_info->output[i].shape[0];\n \t\toutput[i].type = io_info->output[i].qtype;\ndiff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c\nindex 834e55e88e..e53ada7b1c 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.c\n@@ -668,11 +668,13 @@ cn10k_ml_layer_load(void *device, uint16_t model_id, const char *layer_name, uin\n \t}\n \n \t/* Copy metadata to internal buffer */\n-\trte_memcpy(&layer->glow.metadata, buffer, sizeof(struct cn10k_ml_model_metadata));\n+\tmemcpy(&layer->glow.metadata, buffer,\n+\t sizeof(struct cn10k_ml_model_metadata));\n \tcn10k_ml_model_metadata_update(&layer->glow.metadata);\n \n \t/* Set layer name */\n-\trte_memcpy(layer->name, layer->glow.metadata.model.name, MRVL_ML_MODEL_NAME_LEN);\n+\tmemcpy(layer->name, layer->glow.metadata.model.name,\n+\t MRVL_ML_MODEL_NAME_LEN);\n \n \t/* Enable support for batch_size of 256 */\n \tif (layer->glow.metadata.model.batch_size == 0)\n@@ -748,11 +750,12 @@ cn10k_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params *\n \tmodel->subtype = ML_CNXK_MODEL_SUBTYPE_GLOW_MRVL;\n \n \t/* Copy metadata to internal buffer */\n-\trte_memcpy(&model->glow.metadata, params->addr, sizeof(struct cn10k_ml_model_metadata));\n+\tmemcpy(&model->glow.metadata, params->addr,\n+\t sizeof(struct cn10k_ml_model_metadata));\n \tcn10k_ml_model_metadata_update(&model->glow.metadata);\n \n \t/* Set model name */\n-\trte_memcpy(model->name, (char *)model->glow.metadata.model.name, 64);\n+\tmemcpy(model->name, (char *)model->glow.metadata.model.name, 64);\n \n \t/* Enable support for batch_size of 256 */\n \tif (model->glow.metadata.model.batch_size == 0)\ndiff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.c\nindex 971362b242..f9d0f50e1f 100644\n--- a/drivers/ml/cnxk/cnxk_ml_ops.c\n+++ b/drivers/ml/cnxk/cnxk_ml_ops.c\n@@ -1400,7 +1400,7 @@ cnxk_ml_model_info_get(struct rte_ml_dev *dev, uint16_t model_id,\n \t}\n \n \tinfo = (struct rte_ml_model_info *)model->info;\n-\trte_memcpy(model_info, info, sizeof(struct rte_ml_model_info));\n+\tmemcpy(model_info, info, sizeof(struct rte_ml_model_info));\n \tmodel_info->input_info = info->input_info;\n \tmodel_info->output_info = info->output_info;\n \ndiff --git a/drivers/ml/cnxk/mvtvm_ml_model.c b/drivers/ml/cnxk/mvtvm_ml_model.c\nindex e3234ae442..99b4774a2e 100644\n--- a/drivers/ml/cnxk/mvtvm_ml_model.c\n+++ b/drivers/ml/cnxk/mvtvm_ml_model.c\n@@ -310,7 +310,7 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo\n \t\tgoto tvm_mrvl_model;\n \n \tmetadata = &model->mvtvm.metadata;\n-\trte_memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN);\n+\tmemcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN);\n \tsnprintf(info->version, RTE_ML_STR_MAX, \"%u.%u.%u.%u\", metadata->model.version[0],\n \t\t metadata->model.version[1], metadata->model.version[2],\n \t\t metadata->model.version[3]);\n@@ -327,7 +327,8 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo\n \n \t/* Set input info */\n \tfor (i = 0; i < info->nb_inputs; i++) {\n-\t\trte_memcpy(input[i].name, metadata->input[i].name, MRVL_ML_INPUT_NAME_LEN);\n+\t\tmemcpy(input[i].name, metadata->input[i].name,\n+\t\t MRVL_ML_INPUT_NAME_LEN);\n \t\tinput[i].nb_dims = metadata->input[i].ndim;\n \t\tinput[i].shape = &model->mvtvm.info.input[i].shape[0];\n \t\tinput[i].type = model->mvtvm.info.input[i].qtype;\n@@ -338,7 +339,8 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo\n \n \t/* Set output info */\n \tfor (i = 0; i < info->nb_outputs; i++) {\n-\t\trte_memcpy(output[i].name, metadata->output[i].name, MRVL_ML_OUTPUT_NAME_LEN);\n+\t\tmemcpy(output[i].name, metadata->output[i].name,\n+\t\t MRVL_ML_OUTPUT_NAME_LEN);\n \t\toutput[i].nb_dims = metadata->output[i].ndim;\n \t\toutput[i].shape = &model->mvtvm.info.output[i].shape[0];\n \t\toutput[i].type = model->mvtvm.info.output[i].qtype;\ndiff --git a/drivers/ml/cnxk/mvtvm_ml_ops.c b/drivers/ml/cnxk/mvtvm_ml_ops.c\nindex e825c3fb23..fca7e0c3c0 100644\n--- a/drivers/ml/cnxk/mvtvm_ml_ops.c\n+++ b/drivers/ml/cnxk/mvtvm_ml_ops.c\n@@ -194,7 +194,7 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params *\n \t/* Copy mod.so */\n \tmodel->mvtvm.object.so.addr = mz->addr;\n \tmodel->mvtvm.object.so.size = object[0].size;\n-\trte_memcpy(model->mvtvm.object.so.name, object[0].name, TVMDP_NAME_STRLEN);\n+\tmemcpy(model->mvtvm.object.so.name, object[0].name, TVMDP_NAME_STRLEN);\n \trte_memcpy(model->mvtvm.object.so.addr, object[0].buffer, object[0].size);\n \trte_free(object[0].buffer);\n \n@@ -203,7 +203,8 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params *\n \t\tRTE_PTR_ADD(model->mvtvm.object.so.addr,\n \t\t\t RTE_ALIGN_CEIL(model->mvtvm.object.so.size, RTE_CACHE_LINE_MIN_SIZE));\n \tmodel->mvtvm.object.json.size = object[1].size;\n-\trte_memcpy(model->mvtvm.object.json.name, object[1].name, TVMDP_NAME_STRLEN);\n+\tmemcpy(model->mvtvm.object.json.name, object[1].name,\n+\t TVMDP_NAME_STRLEN);\n \trte_memcpy(model->mvtvm.object.json.addr, object[1].buffer, object[1].size);\n \trte_free(object[1].buffer);\n \n@@ -212,7 +213,8 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params *\n \t\tRTE_PTR_ADD(model->mvtvm.object.json.addr,\n \t\t\t RTE_ALIGN_CEIL(model->mvtvm.object.json.size, RTE_CACHE_LINE_MIN_SIZE));\n \tmodel->mvtvm.object.params.size = object[2].size;\n-\trte_memcpy(model->mvtvm.object.params.name, object[2].name, TVMDP_NAME_STRLEN);\n+\tmemcpy(model->mvtvm.object.params.name, object[2].name,\n+\t TVMDP_NAME_STRLEN);\n \trte_memcpy(model->mvtvm.object.params.addr, object[2].buffer, object[2].size);\n \trte_free(object[2].buffer);\n \n", "prefixes": [ "v3", "23/30" ] }