Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139015/?format=api
{ "id": 139015, "url": "http://patches.dpdk.org/api/patches/139015/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240401170257.121047-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240401170257.121047-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240401170257.121047-2-stephen@networkplumber.org", "date": "2024-04-01T17:01:52", "name": "[1/2] mempool: replace GCC pragma with cast", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9abb1f1d405b4d6db88921529e5ed5cb1473f8b4", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240401170257.121047-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31653, "url": "http://patches.dpdk.org/api/series/31653/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31653", "date": "2024-04-01T17:01:51", "name": "mempool: patches", "version": 1, "mbox": "http://patches.dpdk.org/series/31653/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139015/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 804D743DAA;\n\tMon, 1 Apr 2024 19:03:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A73E402D2;\n\tMon, 1 Apr 2024 19:03:11 +0200 (CEST)", "from mail-pf1-f182.google.com (mail-pf1-f182.google.com\n [209.85.210.182])\n by mails.dpdk.org (Postfix) with ESMTP id D0EA34028B\n for <dev@dpdk.org>; Mon, 1 Apr 2024 19:03:09 +0200 (CEST)", "by mail-pf1-f182.google.com with SMTP id\n d2e1a72fcca58-6ea9a616cc4so2872513b3a.1\n for <dev@dpdk.org>; Mon, 01 Apr 2024 10:03:09 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n a18-20020aa780d2000000b006e6cc93381esm8101729pfn.125.2024.04.01.10.03.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 01 Apr 2024 10:03:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711990989;\n x=1712595789; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=S5dUAq3LAjAuy8LOJ/UIb1Pod3vsFVofJPHmB2uTlKA=;\n b=pbyBhDnyDtYGeUKgSWzuJbNRyWzSU6rgtQJANQWDsqLX7POpMgEKq0aks8C0X0KfFW\n +tULNmx8hUe0oCCy+UUqN57M9sWKNLThOZLc9NB7rrq+y9osWBXTgVqBiie/xya3Gw7Y\n 3vpnk0azqdoCrVOeu8alR064qbJHHawd6yXMFJHxfl9cM098a3SqsXy+8Qe85KrYhkZe\n I9b7zBRmf2+mWup7dwdlkN8PqnvZT/eFdSsEBRqelmOzBuWvjbKJM48ehT3iHSKxwmkv\n N6aoCHTp6poeP5VDe1azmvuf8wMWAKg369Irly+3N+w/A/grTA39rNrGZ8m43M2p6Cek\n 1W7w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711990989; x=1712595789;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=S5dUAq3LAjAuy8LOJ/UIb1Pod3vsFVofJPHmB2uTlKA=;\n b=K8ZWahTjcytJImNl2sbabL/maDJDH7u7Gy8u4cSkIvb3CtPQgevWc+losOcAAZ+Bhg\n x5aKTZM6NJMtsvdrFKo1DSNfalqA4ielV0/DK0aWEI4bV0zYM7SNZKaJMMW3vTtp5ocM\n Z0NOWvK9n/99Zn56LtHH2xMrkhc7ylRg1O7EGlDq1jduZDsZlwX9FT2E6DZO5R9NgFrR\n 2jDemL/Ufnc2AyfuscO80qJBxGZqfX4zxgAeIqFBTBDGOnzTkwaA0Pf8YeO38e/rOiIW\n oaTH4bOCLRZLMD+kXubMAQU7IbVTDbZkK3U7ZsFB1w8Hb/hBdwHEOKKK7CugVNMaYlB1\n iFsw==", "X-Gm-Message-State": "AOJu0YwLwBsJVDSALAZN5GWT8KUNqs7N/4kAeJU/J2ERmlcWXkXVFV5I\n Zebn+ZmrhUofWh3g/JOWSkVzeFanTBZ4KIVx4o/Jr/tnSqWhYyqC70Y/loZF7XPFyl3P/Y1oglF\n t", "X-Google-Smtp-Source": "\n AGHT+IFb6ekNM/mVfCbYTq5+EBdgUErQgnjkgKGMpOjgONCdPbm+puBY475RIhZlXqdd27hoXMegVw==", "X-Received": "by 2002:a05:6a20:2d12:b0:1a3:6465:208e with SMTP id\n g18-20020a056a202d1200b001a36465208emr11910349pzl.55.1711990988943;\n Mon, 01 Apr 2024 10:03:08 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH 1/2] mempool: replace GCC pragma with cast", "Date": "Mon, 1 Apr 2024 10:01:52 -0700", "Message-ID": "<20240401170257.121047-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240401170257.121047-1-stephen@networkplumber.org>", "References": "<20240401170257.121047-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Building mempool with MSVC generates a warning\nbecause of this pragma (same with clang when debug is enabled).\nThe issue the pragma was working around can be better solved\nby using an additional cast.\n\nFixes: af75078fece3 (\"first public release\")\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/mempool/rte_mempool.c | 10 +---------\n 1 file changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c\nindex 12390a2c81..734e8a2feb 100644\n--- a/lib/mempool/rte_mempool.c\n+++ b/lib/mempool/rte_mempool.c\n@@ -1056,10 +1056,6 @@ rte_mempool_dump_cache(FILE *f, const struct rte_mempool *mp)\n \treturn count;\n }\n \n-#ifndef __INTEL_COMPILER\n-#pragma GCC diagnostic ignored \"-Wcast-qual\"\n-#endif\n-\n /* check and update cookies or panic (internal) */\n void rte_mempool_check_cookies(const struct rte_mempool *mp,\n \tvoid * const *obj_table_const, unsigned n, int free)\n@@ -1074,7 +1070,7 @@ void rte_mempool_check_cookies(const struct rte_mempool *mp,\n \n \t/* Force to drop the \"const\" attribute. This is done only when\n \t * DEBUG is enabled */\n-\ttmp = (void *) obj_table_const;\n+\ttmp = (void *)(uintptr_t)obj_table_const;\n \tobj_table = tmp;\n \n \twhile (n--) {\n@@ -1183,10 +1179,6 @@ mempool_audit_cookies(struct rte_mempool *mp)\n #define mempool_audit_cookies(mp) do {} while(0)\n #endif\n \n-#ifndef __INTEL_COMPILER\n-#pragma GCC diagnostic error \"-Wcast-qual\"\n-#endif\n-\n /* check cookies before and after objects */\n static void\n mempool_audit_cache(const struct rte_mempool *mp)\n", "prefixes": [ "1/2" ] }