Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139002/?format=api
{ "id": 139002, "url": "http://patches.dpdk.org/api/patches/139002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240330164433.50144-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240330164433.50144-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240330164433.50144-7-stephen@networkplumber.org", "date": "2024-03-30T16:42:17", "name": "[v20,06/14] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fbc4ae53bc33cc48298d44fab2e03865203ac018", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240330164433.50144-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31649, "url": "http://patches.dpdk.org/api/series/31649/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31649", "date": "2024-03-30T16:42:11", "name": "Logging unification and improvements", "version": 20, "mbox": "http://patches.dpdk.org/series/31649/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139002/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139002/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADA7943D85;\n\tSat, 30 Mar 2024 17:45:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 687834067E;\n\tSat, 30 Mar 2024 17:44:56 +0100 (CET)", "from mail-pg1-f182.google.com (mail-pg1-f182.google.com\n [209.85.215.182])\n by mails.dpdk.org (Postfix) with ESMTP id 37D93402CC\n for <dev@dpdk.org>; Sat, 30 Mar 2024 17:44:49 +0100 (CET)", "by mail-pg1-f182.google.com with SMTP id\n 41be03b00d2f7-5d3907ff128so2173458a12.3\n for <dev@dpdk.org>; Sat, 30 Mar 2024 09:44:49 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n by1-20020a056a02058100b005dc26144d96sm4192417pgb.75.2024.03.30.09.44.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 30 Mar 2024 09:44:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711817088;\n x=1712421888; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=26JyS8a5xAOFLsVay3Kok3WHu0A/W2PjaWn3v8PwBA0=;\n b=fRmhk+f59GhbuW2UopVoOS3qzLEljlyBAEQA+YtxDY+BP7rBPS9WgHnUr0TujiBO+3\n F3hXkLsoSXgW3Up6t7hMTd2vkernK/NeBnHyI+bx3co2Ue/ScIIRLzTjmKEoal00TzQX\n eKsr/8Mo5KndjydoT90HjkQfIzAcMsEHSX2BmNUYm6X+RBYDsWJn7rzh+QtYT0iMXsJk\n Ir/xqjZjprVIvkdPU3VLcC4X56Wp+WrxVKg3E2Gb7xLTizp9BB9LdVZTZc2FSSqWF9ZH\n 41PSUhJ/FMt43K0DXtdKDpW6Bxr//KQoQlny2wjkhI6rVCbLdhgb9d/oy0mFtYq/RqWR\n O9dg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711817088; x=1712421888;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=26JyS8a5xAOFLsVay3Kok3WHu0A/W2PjaWn3v8PwBA0=;\n b=W6G0fKqw+QtvF2ReA8xAitmvtUF7Hk+CPzCkn/Yo0eTBomZX1bpcgshifW1oknENmr\n FdZdhxWu18Q95MbDiAGyafq3hrGl1REbra18ngmD8QphYLIPW8EOlycKxRyI68lCGzoi\n Sw+OEPt9eQaX0KIuXEGZMYA08f3DlNqperEG9m/iTrC+bi/Bo7w9imm+Hbi6YewyR0IK\n Y2yTyPzvbgB2DMOjeoaofGQ+CkX6VxVQzgur6KtjB69uzuzXBh18zFC4Ehl3D7eOn+V6\n VKzVadeVJgVdYYQF9FmbloAR3Sz7riZMddMDxGVmFQFQYeXsQUzUMnuFMvbziycTNiO4\n K2Ew==", "X-Gm-Message-State": "AOJu0Yw+la6Uyx7kYwLqpj1R+YmGGxfzAXVgY7/IKjf40LqWGhDttrRK\n 6LDcorrV9yl+ESIuQuwu6I4LvBWyR0Ia/wXYQJEwwOlJgie4gtplbtgzN/GdgKgkR7gaN2BMDID\n B", "X-Google-Smtp-Source": "\n AGHT+IFZGPW9sRQTpRnRyK0hujsh3378sta95CT0Io4htLYptnhL0bRGOaw1OSio23U5spWefwJz6w==", "X-Received": "by 2002:a17:90a:ac9:b0:29e:d30:5b2c with SMTP id\n r9-20020a17090a0ac900b0029e0d305b2cmr5329658pje.18.1711817088503;\n Sat, 30 Mar 2024 09:44:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v20 06/14] eal: change rte_exit() output to match rte_log()", "Date": "Sat, 30 Mar 2024 09:42:17 -0700", "Message-ID": "<20240330164433.50144-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240330164433.50144-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240330164433.50144-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/common/eal_common_debug.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..ad2be63cbb 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,18 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar msg[256];\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tvsnprintf(msg, sizeof(msg), format, ap);\n \tva_end(ap);\n \n+\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n+\n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v20", "06/14" ] }