Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138996/?format=api
{ "id": 138996, "url": "http://patches.dpdk.org/api/patches/138996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240330074409.273916-1-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240330074409.273916-1-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240330074409.273916-1-huangdengdui@huawei.com", "date": "2024-03-30T07:44:09", "name": "app/testpmd: handle IEEE1588 init fail", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "86004c3620b0a5f5daff925c01da75831f52fadb", "submitter": { "id": 3066, "url": "http://patches.dpdk.org/api/people/3066/?format=api", "name": "Dengdui Huang", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240330074409.273916-1-huangdengdui@huawei.com/mbox/", "series": [ { "id": 31648, "url": "http://patches.dpdk.org/api/series/31648/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31648", "date": "2024-03-30T07:44:09", "name": "app/testpmd: handle IEEE1588 init fail", "version": 1, "mbox": "http://patches.dpdk.org/series/31648/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138996/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AA7643D8C;\n\tSat, 30 Mar 2024 08:44:15 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D5011402C2;\n\tSat, 30 Mar 2024 08:44:14 +0100 (CET)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id E57EC402B0\n for <dev@dpdk.org>; Sat, 30 Mar 2024 08:44:12 +0100 (CET)", "from mail.maildlp.com (unknown [172.19.163.44])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4V68NS1KVtz1R8tf;\n Sat, 30 Mar 2024 15:41:28 +0800 (CST)", "from dggpeml500011.china.huawei.com (unknown [7.185.36.84])\n by mail.maildlp.com (Postfix) with ESMTPS id 968BD1402DE;\n Sat, 30 Mar 2024 15:44:10 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.2507.35; Sat, 30 Mar 2024 15:44:09 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <aman.deep.singh@intel.com>,\n <yuying.zhang@intel.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH] app/testpmd: handle IEEE1588 init fail", "Date": "Sat, 30 Mar 2024 15:44:09 +0800", "Message-ID": "<20240330074409.273916-1-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the port's timestamping function failed to initialize\n(for example, the device does not support PTP), the packets\nreceived by the hardware do not contain the timestamp.\nIn this case, IEEE1588 packet forwarding should not start.\nThis patch fix it.\n\nPlus, adding a failure message when failed to disable PTP.\n\nFixes: a78040c990cb (\"app/testpmd: update forward engine beginning\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\n---\n app/test-pmd/ieee1588fwd.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c\nindex 3371771751..afea7735c7 100644\n--- a/app/test-pmd/ieee1588fwd.c\n+++ b/app/test-pmd/ieee1588fwd.c\n@@ -197,14 +197,23 @@ ieee1588_packet_fwd(struct fwd_stream *fs)\n static int\n port_ieee1588_fwd_begin(portid_t pi)\n {\n-\trte_eth_timesync_enable(pi);\n-\treturn 0;\n+\tint ret;\n+\n+\tret = rte_eth_timesync_enable(pi);\n+\tif (ret)\n+\t\tprintf(\"Port %u enable PTP failed, ret = %d\\n\", pi, ret);\n+\n+\treturn ret;\n }\n \n static void\n port_ieee1588_fwd_end(portid_t pi)\n {\n-\trte_eth_timesync_disable(pi);\n+\tint ret;\n+\n+\tret = rte_eth_timesync_disable(pi);\n+\tif (ret)\n+\t\tprintf(\"Port %u disable PTP failed, ret = %d\\n\", pi, ret);\n }\n \n static void\n", "prefixes": [] }